Scripting Helpers is winding down operations and is now read-only. More info→

My Badge script isn't working to how I want it to, If you knows how to fix it I would be greatful?

Asked by

Puppy_lovertheawsome 84

2 years ago

Edited 2 years ago

I need help with this badge awarding script, can I please have help with it, I am following a series of tutorials by NetheriteStudio and im trying to fix some buggy script.

01local Tool = script.Parent.Parent
02 
03local Anim = script:WaitForChild("Animation")
04local AnimTrack
05 
06local hitChars = {}
07local debounce = false
08 
09Tool.Activated:Connect(function()
10    if debounce then
11        return
12    end
13 
14    debounce = true
15 
16    local humanoid = Tool.Parent.Humanoid
17    if not AnimTrack then
18        AnimTrack = humanoid:LoadAnimation(Anim)
19    end
20    AnimTrack:Play()
21    wait(0)
22    debounce = false
23end)
24 
25Tool.HitBox.Touched:Connect(function(hit)
26    if hitChars[hit.Parent] or not debounce then
27        return
28    end
29 
30    if hit.Parent:FindFirstChild("Humanoid") then
31        local eChar = hit.Parent
32        local plrChar = Tool.Parent
33 
34        local eHumanRootPart = eChar:FindFirstChild("HumanoidRootPart")
35        local plrHumanRootPart = plrChar:FindFirstChild("HumanoidRootPart")
36        if plrHumanRootPart and eHumanRootPart then
37            script.Disabled = true
38            eChar.Humanoid.Sit = true
39 
40            local force = Instance.new("BodyVelocity", eHumanRootPart)
41            force.MaxForce = Vector3.new(2,2,2) * math.huge
42            local direction = (eHumanRootPart.CFrame.Position - plrHumanRootPart.CFrame.Position).Unit
43            force.Velocity = (direction + Vector3.new(0,1,0)).Unit * 250
44 
45            local rotation = Instance.new("BodyAngularVelocity", eHumanRootPart)
46            rotation.AngularVelocity = Vector3.new(1, 1, 1) * math.pi * math.random(1,5)
47            rotation.MaxTorque = Vector3.new(2,2,2) * math.huge
48            rotation.P = 5000
49 
50            wait(0.35)
51            force:Destroy()
52            rotation:Destroy()
53            eChar.Humanoid.Sit = false
54 
55            local player = game.Players:GetPlayerFromCharacter(Tool.Parent)
56            player.leaderstats.Slaps.Value = player.leaderstats.Slaps.Value + 1
57 
58            local ePlr = game.Player:GetPlayerFromCharacter(eChar)
59            local BS = game:GetService("BadgeService")
60            local id = 2141407136
61 
62            BS:AwardBadge(ePlr.UserId,id)
63        end
64        hitChars[hit.Parent] = true
65        wait(2.5)
66        script.Disabled = false
67        hitChars[hit.Parent] = nil
68    end
69end)
 View all 69 lines...

show full script pls T3_MasterGamer 2189 — 2y

oh kk Puppy_lovertheawsome 84 — 2y

done Puppy_lovertheawsome 84 — 2y

oh also This is in the handle of my glove tool (This is an SB fan game) Puppy_lovertheawsome 84 — 2y

View all comments (7 more)

I am guessing if it is in the handle it might be a local script? I don't believe badges can be given out from the client to prevent exploits. Jay123abc2 241 — 2y

nah its not a local script its a normal script Puppy_lovertheawsome 84 — 2y

Rip I gtg now I will be back another time, Cya! Puppy_lovertheawsome 84 — 2y

Yeh, if it is on a local script that will be why. Badges can not be given from the client. If it is on a server script then it is a different issue. https://create.roblox.com/docs/reference/engine/classes/BadgeService#AwardBadge Jay123abc2 241 — 2y

ok thx be here another time cya Puppy_lovertheawsome 84 — 2y

Can't find the issue, check for any errors. Jay123abc2 241 — 2y

1 answer

Answered by

T3_MasterGamer 2189

2 years ago

Edited 2 years ago

game.Player doesn't exist and should be using game.Players.
ePlr could be an NPC and that could break the script. You should always check if it's an actual player using Players:GetPlayerFromCharacter().
Instead of indexing hit.Parent as a dictionary, you can use table.insert() and table.remove() as an array.
Before awarding a badge, you should use BadgeService:GetBadgeInfoAsync() and BadgeService:UserHasBadgeAsync() to avoid errors.
In case BadgeService:AwardService(), loop it until successful.
When using LoadAnimation(), it is recommended to use Humanoid.Animator instead of Humanoid.
Before playing animations, keep checking AnimationTrack.Length until it is more than zero (fully loaded).
Tip: If you want an animation to play first than other animations, change AnimationTrack.Priority to Enum.AnimationPriority.Action4 (the highest priority).
Disabling a script will make it stop and re-enabling it won't run again.
Use task.wait() instead of wait().

001local Players = game:GetService("Players")
002local BadgeService = game:GetService("BadgeService")
003local Debris = game:GetService("Debris")
004 
005local Tool = script:FindFirstAncestorOfClass("Tool")
006local Anim = script:WaitForChild("Animation")
007 
008local hitChars = {}
009local debounce = false
010 
011local animStopped = Instance.new("BindableEvent")
012 
013Tool.Activated:Connect(function()
014    if debounce then return end
015 
016    debounce = true
017 
018    local humanoid = Tool.Parent:FindFirstChildOfClass("Humanoid")
019    local animator = humanoid:FindFirstChildOfClass("Animator")
020    local AnimTrack = animator:LoadAnimation(Anim)
021    repeat task.wait() until AnimTrack.Length -- loading
022    AnimTrack.Priority = Enum.AnimationPriority.Action4
023    AnimTrack:Play()
024 
025    AnimTrack.Stopped:Connect(function()
026        animStopped:Fire()
027    end)
028    AnimTrack.Ended:Connect(function()
029        animStopped:Fire()
030    end)
031 
032    animStopped.Event:Wait() -- waits until animation has stopped
033    debounce = false
034end)
035 
036local function badgeAvailable(badgeId: number, recipient: Player): boolean
037    local suc1, suc2, info, hasBadge
038 
039    repeat
040        suc1, info = pcall(BadgeService.GetBadgeInfoAsync, BadgeService, badgeId)
041    until suc1 and info
042    repeat
043        suc2, hasBadge = pcall(BadgeService.UserHasBadgeAsync, BadgeService, recipient.UserId, badgeId)
044    until suc2
045 
046    if info.IsEnabled then
047        if hasBadge then
048            return true
049        end
050    end
051 
052    return false
053end
054 
055Tool.HitBox.Touched:Connect(function(hit)
056    if debounce then return end
057 
058    local eChar = hit:FindFirstAncestorOfClass("Model")
059    local ePlr = Players:GetPlayerFromCharacter(eChar)
060    local eHuman = eChar:FindFirstChildOfClass("Humanoid")
061    local eHumanRootPart = eChar:FindFirstChild("HumanoidRootPart")
062 
063    local plrChar = Tool.Parent
064    local plr = Players:GetPlayerFromCharacter(plrChar)
065    local plrHuman = plrChar:FindFirstChildOfClass("Humanoid")
066    local plrHumanRootPart = plrChar:FindFirstChild("HumanoidRootPart")
067 
068    if (eChar and ePlr and eHuman and eHumanRootPart) and (plrChar and plr and plrHuman and plrHumanRootPart) then -- if ePlr and plr are real players
069        if table.find(hitChars, eChar) then return end
070 
071        eHuman.Sit = true
072 
073        local force = Instance.new("BodyVelocity", eHumanRootPart)
074        force.MaxForce = Vector3.new(2,2,2) * math.huge
075        local direction = (eHumanRootPart.CFrame.Position - plrHumanRootPart.CFrame.Position).Unit
076        force.Velocity = (direction + Vector3.new(0,1,0)).Unit * 250
077 
078        local rotation = Instance.new("BodyAngularVelocity", eHumanRootPart)
079        rotation.AngularVelocity = Vector3.new(1, 1, 1) * math.pi * math.random(1,5)
080        rotation.MaxTorque = Vector3.new(math.huge, math.huge, math.huge)
081        rotation.P = 5000
082 
083        Debris:AddItem(force, 0.35)
084        Debris:AddItem(rotation, 0.35)
085 
086        task.wait(0.35)
087        eHuman.Sit = false
088 
089        plr.leaderstats.Slaps.Value += 1
090 
091        task.spawn(function()
092            local badgeId = 2141407136
093            if badgeAvailable(badgeId, ePlr) then
094                local success
095                repeat
096                    success = pcall(BadgeService.AwardBadge, BadgeService, ePlr.UserId, id)
097                until success or (not Players:FindFirstChild(ePlr.Name))
098            end
099        end)
100 
101        table.insert(hitChars, eChar)
102        task.wait(2.5)
103        pcall(table.remove, hitChars, table.find(hitChars, eChar))
104    end
105end)
 View all 105 lines...

tysm bro I thought all of my hard work was wasted! Your a life saver. Puppy_lovertheawsome 84 — 2y

My Badge script isn't working to how I want it to, If you knows how to fix it I would be greatful?

1 answer

Answer this question