How do I fix the swapping function for my Inventory system?

Asked by
2 years ago
I've been working on an inventory system for a survival game I've been working on, and I've been having trouble with it. I've been lately working specifically on the swapping function, where you can select an item, press a button, and then if you press 1 for example, the selected item will go in slot 1 of the hotbar. However, when I programmed the code for the swapping to actually happen, it didn't work. I believe it was due to the updateDisplay function and how it works, since the item's data was still in the hotbar slot.
Code is below (go to lines 116 and 188 ):
001local StarterGui = game:GetService("StarterGui")
002local Players = game:GetService("Players")
003local UIS = game:GetService("UserInputService")
004 
005StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack, false)
006 
007local player = Players.LocalPlayer
008local backpack = player.Backpack
009local char = player.Character
010 
011local GUI = script.Parent.Parent.Inventory
012local hotbar = GUI.Hotbar
013local inventory = GUI.Inventory
014local items = inventory.Items
015 
016local tooltip = inventory.Tooltip
017local itemNameT = inventory.Tooltip.ToolName
018local itemDescription = inventory.Tooltip.Tooltip
019 
020local slot1 = inventory.Items.InventorySlot1
021local slot2 = inventory.Items.InventorySlot2
022local slot3 = hotbar.Frame.HotbarSlot1
023local slot4 = hotbar.Frame.HotbarSlot2
024local openButton = hotbar.OpenInventory
025local equipButton = inventory.EquipHotbarButton
026 
027local unselctedColor = Color3.fromRGB(121, 121, 121)
028local selectedColor = Color3.fromRGB(62, 62, 62)
029 
030local selectedSlot = nil
031 
032 
033local invSlotData = {
034    [slot1] = nil,
035    [slot2] = nil  
036}
037 
038local hotbarSlotData = {
039    [slot3] = nil,
040    [slot4] = nil
041}
042 
043local function scanItems()
044 
045    local items = {}
046 
047    --checks backpack and character for items and adds them to the Items table
048    for i, tool in pairs(backpack:GetChildren()) do
049        if tool.ClassName == "Tool" then
050            table.insert(items, tool)
051        end
052    end
053 
054    for i, tool in pairs(char:GetChildren()) do
055        if tool.ClassName == "Tool" then
056            table.insert(items, tool)
057        end
058    end
059 
060 
061    local invItems = {}
062 
063    --[[looks through Items table, and if a tool has the same name as an index in invItems table, add to the index's count and insert
064    the tool's name into the index's Items table. else, create a new index with the tool's name and set all it's tables to default  --]]
065    for i, tool in pairs(items) do
066        if invItems[tool.Name] then
067            invItems[tool.Name].Count += 1
068            table.insert(invItems[tool.Name].Items, tool)
069 
070        else
071            invItems[tool.Name] = {
072                Count = 1,
073                Items = {tool}
074            }
075        end
076    end
077 
078    return invItems
079end
080 
081local function resetItems()
082    for i, button in pairs(items:GetChildren()) do
083        if button.ClassName == "ImageButton" then
084            button.Image = ""
085            button.CountDisplay.Text = ""
086            button.BackgroundColor3 = Color3.fromRGB(255, 255, 255)
087        end
088    end
089 
090    for i, button in pairs(hotbar.Frame:GetChildren()) do
091        if button.ClassName == "ImageButton" then
092            button.Image = ""
093            button.CountDisplay.Text = ""
094            button.BackgroundColor3 = Color3.fromRGB(255, 255, 255)
095        end
096    end
097end
098 
099local function updateSelected(selectedItem, toolData)
100    --checks all buttons in items frame and resets all background colors to default except sample
101 
102 
103    --[[  selectedItem's background color is changed to selectedColor and selectedSlot is set to toolData.
104    selectedItem's name and tooltip is pulled from toolData and used for tooltip in inventory.--]]
105    selectedSlot = toolData
106 
107 
108    itemNameT.Text = toolData.Items[1].Name
109    itemDescription.Text = toolData.Items[1].ToolTip
110end
111 
112 
113--UPDATE DISPLAY FUNCTION IS HERE, CHECK THIS OUT IF YOURE FIXING SCRIPT
114 
115 
116local function updateDisplay()
117    resetItems()
118 
119    local invItems = scanItems()
120    local connection = nil
121    local equipButtonConnection = nil
122 
123 
124    for toolName, toolData in pairs(invItems) do
125        if invSlotData[slot1] == nil or toolData.Items[1].Name == invSlotData[slot1].Items[1].Name then
126 
127            invSlotData[slot1] = toolData
128 
129            slot1.CountDisplay.Text = toolData.Count
130            slot1.Image = toolData.Items[1].TextureId
131 
132 
133 
134            connection = slot1.MouseButton1Click:Connect(function()
135                updateSelected(slot1, toolData)
136            end)
137 
138        elseif invSlotData[slot2] == nil or toolData.Items[1].Name == invSlotData[slot2].Items[1].Name then
139 
140 
141            invSlotData[slot2] = toolData
142 
143            slot2.CountDisplay.Text = toolData.Count
144            slot2.Image = toolData.Items[1].TextureId
145 
146 
147 
148            connection = slot2.MouseButton1Click:Connect(function()
149                updateSelected(slot2, toolData)
150            end)
151 
152        elseif hotbarSlotData[slot3] == nil or toolData.Items[1].Name == hotbarSlotData[slot3].Items[1].Name then
153 
154 
155            hotbarSlotData[slot3] = toolData
156 
157            slot3.CountDisplay.Text = toolData.Count
158            slot3.Image = toolData.Items[1].TextureId
159 
160 
161 
162            connection = slot3.MouseButton1Click:Connect(function()
163                updateSelected(slot3, toolData)
164            end)
165 
166 
167        elseif hotbarSlotData[slot4] == nil or toolData.Items[1].Name == hotbarSlotData[slot4].Items[1].Name then
168 
169            hotbarSlotData[slot4] = toolData
170 
171            slot4.CountDisplay.Text = toolData.Count
172            slot4.Image = toolData.Items[1].TextureId
173 
174 
175            connection = slot4.MouseButton1Click:Connect(function()
176                updateSelected(slot4, toolData)
177            end)
178 
179        end
180 
181    end
182 
183end
184 
185--SWAPPING ITEMS FUNCTION IS ALSO HERE
186 
187 
188local equipButtonDebounce = false
189 
190local keysToSlots = {
191    [Enum.KeyCode.One] = slot3,
192    [Enum.KeyCode.Two] = slot4,
193}
194 
195local function swapItemSlots()
196 
197    if selectedSlot == nil or equipButtonDebounce == true then
198        equipButton.Text = "Can't Equip to Hotbar"
199        wait(1)
200        equipButton.Text = "Equip to Hotbar"
201 
202        return
203    end
204 
205    equipButtonDebounce = true
206 
207    equipButton.Text = "Press a Number 1-2"
208 
209    local input, gameProcessedEvent = UIS.InputBegan:Wait()
210 
211    equipButton.Text = "Equip to Hotbar"
212 
213 
214 
215    local chosenHotbarSlot = nil
216 
217    for keycode, slot in pairs(keysToSlots) do
218        if input.KeyCode == keycode then
219            chosenHotbarSlot = slot
220            break
221        end
222    end
223 
224    if chosenHotbarSlot == nil then
225        equipButton.Text = "Wrong Button!"
226 
227        task.wait(1)
228 
229        equipButton.Text = "Equip to Hotbar"
230    else
231        for slotF, itemData in pairs(hotbarSlotData) do
232            if itemData.Items[1].Name == selectedSlot.Items[1].Name then
233                hotbarSlotData[slotF] = nil
234                print(hotbarSlotData)
235            end
236 
237        end
238 
239        hotbarSlotData[chosenHotbarSlot] = selectedSlot
240        selectedSlot = nil
241        updateDisplay()
242 
243 
244        print(chosenHotbarSlot)
245        print(invSlotData)
246        print(hotbarSlotData)
247    end
248 
249    equipButtonDebounce = false
250 
251end
252 
253equipButton.MouseButton1Click:Connect(swapItemSlots)
254 
255 
256 
257 
258task.spawn(function()
259    while true do
260        wait(1)
261        updateDisplay()
262    end
263end)
 View all 263 lines...
How do I fix the swapping function for my Inventory system?

1 answer

Answer this question
