Scripting Helpers is winding down operations and is now read-only. More info→

Regen Dilemma, can it be fixed?

Asked by

10 years ago

1 I have a new vehicle regen that is designed not to regen the vehicle if the vehicle is in use. However, when the vehicle is legitimately regenned the vehicle disintegrates to its most basic parts. How can I fix this so the vehicle can be regenned to its original structure rather than fall apart? Here is a copy of the regen script.

01local Vehicle = script.Parent.Vehicle:Clone()
02 
03for i, v in pairs(Vehicle:GetChildren()) do
04    if v:IsA("Script") then
05        v.Disabled = true
06    end
07end
08local CurrentVehicle = script.Parent.Vehicle
09 
10local Regen = script.Parent.Regen
11local ClickDetector = Regen.ClickDetector
12local Display = Regen.Display.Label
13 
14local InUse = false
15local Debounce = false
16 
17function UpdateUse()
18    Display.Text = Debounce and "REGENERATING" or InUse and "VEHICLE IS IN USE" or "REGEN"
19end
20 
21function HandleVehicle(vehicle)
22    InUse = false
23    local seats = {}
24 
25    local function CheckUse()
26        local used = false
27        for i, v in pairs(seats) do
28            if v then
29                used = true
30            end
31        end
32        InUse = used
33        UpdateUse()
34    end
35 
36    local function GetAllSeats(vehicle)
37        for i, v in pairs(vehicle:GetChildren()) do
38            if v:IsA("VehicleSeat") or v:IsA("Seat") then
39                table.insert(seats, false)
40                local id = #seats
41                v.ChildAdded:connect(function(child)
42                    if child.Name == "SeatWeld" then
43                        seats[id] = true
44                        CheckUse()
45                    end
46                end)
47                v.ChildRemoved:connect(function(child)
48                    if child.Name == "SeatWeld" then
49                        seats[id] = false
50                        CheckUse()
51                    end
52                end)
53            elseif v:IsA("Model") then
54                GetAllSeats(v)
55            end
56        end
57    end
58    GetAllSeats(vehicle)
59end
60 
61HandleVehicle(script.Parent.Vehicle)
62 
63ClickDetector.MouseClick:connect(function()
64    if not InUse and not Debounce then
65        Debounce = true
66        UpdateUse()
67        CurrentVehicle:Destroy()
68        CurrentVehicle = Vehicle:Clone()
69        CurrentVehicle.Parent = Workspace
70        for i, v in pairs(CurrentVehicle:GetChildren()) do
71            if v:IsA("Script") then
72                Delay(0.1, function()
73                    v.Disabled = false
74                end)
75            end
76        end
77        HandleVehicle(CurrentVehicle)
78        wait(5)     
79        Debounce = false
80        UpdateUse()
81    end
82end)
 View all 82 lines...

`1`	`Currently, I use the old person299` `regen. Besides the fact that the vehicle can be regened right out from under you, the regen works great. Here is a copy of the person299` `script` `if` `it can help.`

01--Edited Button Regen Script by Person299
02system = script.Parent
03local c  = system:GetChildren()
04for i = 1,#c do
05a = c[i]
06if a.Name ~= "person299" then
07if a.Name ~= "put in only 1 model" then
08model = a
09end
10end
11end
12backup = model:Clone()
13regen = system:findFirstChild("put in only 1 model")
14function checkRegen()
15if regen.Value == 1 then
16if(model.Parent == system) then
17model:Remove()
18wait(1)
19end
20model = backup:Clone()
21model.Parent = system
22model:MakeJoints()
23end
24end
25regen.Changed:connect(checkRegen)
 View all 25 lines...

2 answers

Answered by

Redbullusa 1580

10 years ago

The joints for the vehicle is not connecting when regened.

To make it connect, use the :MakeJoints() method (as shown on Person299's script on line 22) on your model.

01ClickDetector.MouseClick:connect(function()
02    if not InUse and not Debounce then
03        Debounce = true
04        UpdateUse()
05        CurrentVehicle:Destroy()
06        CurrentVehicle = Vehicle:Clone()
07        CurrentVehicle.Parent = Workspace
08    CurrentVehicle:MakeJoints()             -- CurrentVehicle connects its joints at this point
09        for i, v in pairs(CurrentVehicle:GetChildren()) do
10            if v:IsA("Script") then
11                Delay(0.1, function()
12                    v.Disabled = false
13                end)
14            end
15        end
16        HandleVehicle(CurrentVehicle)
17        wait(5)     
18        Debounce = false
19        UpdateUse()
20    end
21end)
 View all 21 lines...

Thank you Redbullusa, It works! In my small scale tests it functions just as well as Person299, time to implement it full scale! I’m also a little annoying because I was so close to fixing it myself. Before I posted this help request I made the very same modification but on line 69 as opposed to line 70 :S RobloxBossk 20 — 10y

You're very welcome. C: Redbullusa 1580 — 10y

Answered by

Irvene 5

10 years ago

You can't compare "and" to a string, it doesn't know what the string means.

Regen Dilemma, can it be fixed?

2 answers

Answer this question