Scripting Helpers is winding down operations and is now read-only. More info→

Why is the if statement I made not working?

Asked by

BunjiBloxxer 51

2 years ago

Edited 2 years ago

I wrote an if statement that is supposed to make a model appear if someone types the correct word into a textbox and presses the enter button:

01local gui = script.Parent
02local frame = gui.JournalFrame
03local player = game.Players.LocalPlayer
04local sound = script.Parent.JournalFrame.X.JournalCloseSound
05local items = frame:GetChildren()
06local Nouns = {"apple", "tree"}
07local RemoteEvent = game.ReplicatedStorage.JournalEvent
08local sound1 = frame.Success
09local sound2 = frame.Book
10local sound3 = frame.Error
11 
12for i, item in pairs(items) do
13    if item:IsA("GuiButton") and frame.Write.Text == Nouns[1] then -- This is the if statement
14        item.Activated:Connect(function()
15            local itemName = item.Name
16            game.ReplicatedStorage.JournalEvent:FireServer(itemName, game.Players.LocalPlayer:GetMouse().hit.Position)
17            player.PlayerGui.JournalGui.JournalFrame.Visible = false
18            player.PlayerGui.MiniJournalGui.MiniJournalFrame.Visible = true
19            player.PlayerGui.MiniJournalGui2.MiniJournalFrame2.Visible = false
20            player.PlayerGui.JournalGui.JournalBackFrame.Visible = false
21            player.PlayerGui.JournalGui.FailMessage.Visible = false
22            sound:Play()
23            wait(1)
24            game.Players.LocalPlayer:GetMouse().Button1Down:Connect(function()
25        end) 
26    end) 
27    elseif item:IsA("GuiButton") then
28        item.Activated:Connect(function()
29            gui.FailMessage.Visible = true
30            sound3:Play()
31            wait(4)
32            gui.FailMessage.Visible = false
33            local itemName = item.Name
34        end)
35    end
36end
 View all 36 lines...

When the person types "apple" into the textbox (named Write) and presses the enter button, it is supposed to spawn in the model, and if they write anything else and press enter, it is supposed to display the fail message, but even if they write "apple" it displays the fail message, why does this happen?

1 answer

Answered by

amanda 1059

2 years ago

Edited 2 years ago

You are checking the contents of the TextBox whenever the script is first loaded. What you are intending to do is check the contents of the TextBox whenever the GuiButton is Activated.

I have not over analyzed or made any additional changes to your code aside from this: Inside the loop, I am declaring a function for each GuiButton found which will be called when that GuiButton is Activated. Inside that function I am checking the contents of the TextBox using your method and then running the appropriate code.

01local gui = script.Parent
02local frame = gui.JournalFrame
03local player = game.Players.LocalPlayer
04local sound = script.Parent.JournalFrame.X.JournalCloseSound
05local items = frame:GetChildren()
06local Nouns = {"apple", "tree"}
07local RemoteEvent = game.ReplicatedStorage.JournalEvent
08local sound1 = frame.Success
09local sound2 = frame.Book
10local sound3 = frame.Error
11 
12for i, item in pairs(items) do
13    if item:IsA("GuiButton") then
14        item.Activated:Connect(function()
15            if frame.Write.Text == Nouns[1] then
16                local itemName = item.Name
17                game.ReplicatedStorage.JournalEvent:FireServer(itemName, game.Players.LocalPlayer:GetMouse().hit.Position)
18                player.PlayerGui.JournalGui.JournalFrame.Visible = false
19                player.PlayerGui.MiniJournalGui.MiniJournalFrame.Visible = true
20                player.PlayerGui.MiniJournalGui2.MiniJournalFrame2.Visible = false
21                player.PlayerGui.JournalGui.JournalBackFrame.Visible = false
22                player.PlayerGui.JournalGui.FailMessage.Visible = false
23                sound:Play()
24                wait(1)
25                game.Players.LocalPlayer:GetMouse().Button1Down:Connect(function()
26                end)
27            else
28                gui.FailMessage.Visible = true
29                sound3:Play()
30                wait(4)
31                gui.FailMessage.Visible = false
32                local itemName = item.Name
33            end
34        end) 
35    end
36end
 View all 36 lines...

Thanks for the help it worked! BunjiBloxxer 51 — 2y

Why is the if statement I made not working?

1 answer

Answer this question