I couldn't find an issue with your code, are you getting any errors?
You don't need to read this all, but it helps me understand it.
What your script does:
When the bullet object touches another object in the game, the onTouch() function is called. The function first checks if the touched object has a Humanoid child, which indicates that it is a character in the game.
If the touched object is a character, the function checks if the parent of the bullet is the same as the parent of the character. If this is the case, then the function returns early and does not apply damage. This is likely to prevent the bullet from damaging the character that fired it.
Next, the function calls the game.Players:GetPlayerFromCharacter() method to get the Player instance associated with the touched character. If the method returns nil, then the function returns early and does not apply damage. This is likely to prevent the bullet from damaging non-player characters in the game.
Finally, the function checks if the damaged table contains the Humanoid instance of the touched character. If it does, then the function returns early and does not apply damage. This is likely to prevent the bullet from damaging the same character multiple times.
If the function passes all these checks, it applies 25 points of damage to the touched character by calling the humanOther:TakeDamage() method.
Bullet Damage Script:
I added a check to ensure that game.Players:GetPlayerFromCharacter() returns a Player instance before using it. If it returns nil, then the script will return early and not apply damage to the character.
01 | local bullet = script.Parent |
05 | local function onTouch(partOther) |
07 | local humanOther = partOther.Parent:FindFirstChild("Humanoid") |
09 | if not humanOther then return end |
10 | if humanOther.Parent == bullet then return end |
12 | local player = game.Players:GetPlayerFromCharacter(partOther.Parent) |
13 | if not player then return end |
15 | if table.find(damaged, humanOther) then return end |
17 | table.insert(damaged, humanOther) |
19 | humanOther:TakeDamage(25) |
23 | script.Parent.Touched:Connect(onTouch) |
Exp give, when zombie dies script:
01 | local humanoid = script.Parent.Humanoid |
04 | local creatorTag = humanoid:FindFirstChild("creator") |
05 | if creatorTag == nil then return end |
07 | local leaderstats = creatorTag.Value:FindFirstChild("leaderstats") |
08 | if leaderstats == nil then return end |
10 | leaderstats.Exp.Value = leaderstats.Exp.Value + 10 |
15 | humanoid.Died:Connect(onDied) |
In this code, I made a few changes:
I renamed the Humanoid variable to humanoid to follow the convention of using lowercase letters for variable names.
I replaced the Dead() function with the onDied() function, which is a more descriptive name.
I added checks to ensure that humanoid:FindFirstChild() and creatorTag.Value:FindFirstChild() return non-nil values before using them. This will prevent errors if the creator tag or leaderstats object are not found.
I hope this helps! Let me know if you have any other questions.
And the leaderstat script, if it helps to help me:
01 | game.Players.PlayerAdded:Connect(function(player) |
02 | local stats = Instance.new("Folder", player) |
03 | stats.Name = "leaderstats" |
05 | local levels = Instance.new("IntValue", stats) |
06 | levels.Name = "Levels" |
09 | local exp = Instance.new("IntValue", stats) |
14 | game.ReplicatedStorage.AddExpEvent.OnServerEvent:Connect(function(player) |
15 | player.leaderstats.Exp.Value = player.leaderstats.Exp.Value + 10 |
18 | game.Players.PlayerAdded:Connect(function(player) |
21 | local exp = player.leaderstats.Exp |
22 | local levels = player.leaderstats.Levels |
25 | if exp.Value >= (100 * (levels.Value + 1)) then |
26 | levels.Value = levels.Value + 1 |
28 | game.ReplicatedStorage.LevlUpGui:FireClient(player) |
In this code, I made a few changes:
I renamed the plr variable to player to follow the convention of using lowercase letters for variable names.
I added checks to ensure that the AddExpEvent object and LevlUpGui object exist in game.ReplicatedStorage before using them. This will prevent errors if these objects are not found.
I hope this helps! Let me know if you have any other questions.
0