Scripting Helpers is winding down operations and is now read-only. More info→

Moving a player until the key is released?

Asked by

Bman8765 270

10 years ago

Okay so I have a Localscript found in the player's screengui in startergui. It's basic function is simple. Move a image frame when you press a letter. Here is my problem, when the user holds down a key I want the player to keep moving until they let go of the key, how exactly would I do this?

The code:

01repeat wait() until game.Players.LocalPlayer.PlayerGui
02----------------------------------------------------------
03-- Disable roblox's dumb stuff
04---------------------------------------------------------- 
05game.StarterGui:SetCoreGuiEnabled("All", false)
06----------------------------------------------------------
07-- Global Variables
08---------------------------------------------------------- 
09local Player = game.Players.LocalPlayer
10local Mouse = Player:GetMouse()
11local sprite = script.Parent.Player
12----------------------------------------------------------
13-- Movement
14----------------------------------------------------------
15function moveLeft()
16    sprite.Position = sprite.Position - UDim2.new(0.01,0,0,0)
17end
18function moveRight()
19    sprite.Position = sprite.Position + UDim2.new(0.01,0,0,0)
20end
21----------------------------------------------------------
22-- Keyboard input
23---------------------------------------------------------- 
24Mouse.KeyDown:connect(function(Key)
25    if Key == "a" then
26        moveLeft()
27    end
28    if Key == "d" then
29        moveRight()
30    end
31end)
 View all 31 lines...

3 answers

Answered by

adark 5487

10 years ago

Here's how I would write this code:

01repeat wait() until game.Players.LocalPlayer.PlayerGui
02----------------------------------------------------------
03-- Disable roblox's dumb stuff
04---------------------------------------------------------- 
05game.StarterGui:SetCoreGuiEnabled("All", false)
06----------------------------------------------------------
07-- Global Variables
08---------------------------------------------------------- 
09local Player = game.Players.LocalPlayer
10local Mouse = Player:GetMouse()
11local sprite = script.Parent.Player
12 
13local keysDown = {}
14----------------------------------------------------------
15-- Movement
16----------------------------------------------------------
17game:GetService("RunService").RenderStepped:connect(function()
18    local  move = 0
19    if keysDown.a then move = move - 1 end
20    if keysDown.d then move = move + 1 end 
21    sprite.Position = sprite.Position + UDim2.new(0.01*move,0,0,0)
22end)
23----------------------------------------------------------
24-- Keyboard input
25---------------------------------------------------------- 
26Mouse.KeyDown:connect(function(Key)
27    keysDown[Key] = true
28end)
29Mouse.KeyUp:connect(function(Key)
30    keysDown[Key] = false
31end)
 View all 31 lines...

This is a variant of what Perci1 suggested you do.

Answered by

Redbullusa 1580

10 years ago

I'd use a 'while' loop and some static boolean values to make sure that it's doing what it should be doing at a given time.

01isGoingLeft = false
02isGoingRight = false
03 
04Mouse.KeyDown:connect(function (Key)
05    if Key:lower() == "a" then
06        isGoingLeft = true
07        while isGoingLeft do
08            if isGoingLeft == false then
09                break
10            end
11            moveLeft()
12            if isGoingLeft == true then
13                wait(.25)
14            elseif isGoingLeft == false then
15                break
16            end
17        end
18    end
19    if Key:lower() == "d" then
20        isGoingRight = true
21        while isGoingRight do
22            if isGoingRight == false then
23                break
24            end
25            moveRight()
26            if isGoingRight == true then
27                wait(.25)
28            elseif isGoingRight == false then
29                break
30            end
31        end
32    end
33end
34 
35Mouse.KeyUp:connect(Key)
36    if Key:lower() == "a" then
37        isGoingLeft = false
38    end
39    if Key:lower() == "d" then
40        isGoingRight = false
41    end
 View all 41 lines...

An easier way to do it (in my opinion) would be to simply place a bool value in the player, then control that with the KeyDown events. Now a while loop can be used to continuously check if that value is true or false. Perci1 4988 — 10y

-2

Answered by

zub74 0

10 years ago

1Mouse.KeyDown:connect(function(Key)
2    if Key== "a" then
3        moveLeft()
4    until Key ~= "a"
5    end

Try that?

It does not work, also you really shouldn't answer a question unless you have a good answer... Bman8765 270 — 10y

Moving a player until the key is released?

3 answers

Answer this question