[SOLVED] I have a very big bug breaking issue. Can only find the solution to this error?

Asked by

2 years ago

Edited by Xapelize 2 years ago

This question has been solved by the original poster.

The scripts that I have will be pretty long so bear with me (however, I will show you which section of the script is mainly important to this issue)

I am trying to make a data storage system in my module script. What I am trying to attempt is saving the players money, however, if I use a certain script, the game can't recognize the value of the money and I get an error message saying this: ServerScriptService.Components.Button:35: attempt to compare number <= nil (this error message applies to another module script btw)

The script below works fine for other things except for the money system: (look near the bottom of script)

001local Players = game:GetService("Players")
002local DataStoreService = game:GetService("DataStoreService")
003local PlayerData = DataStoreService:GetDataStore("PlayerData")
004 
005local function LeaderboardSetup(value)
006    local leaderstats = Instance.new("Folder")
007    leaderstats.Name = "leaderstats"
008 
009    local money = Instance.new("IntValue")
010    money.Name = "Money"
011    money.Value = value
012    money.Parent = leaderstats
013    return leaderstats
014end
015 
016local function LoadData(player)
017    local success, result = pcall(function()
018        return PlayerData:GetAsync(player.UserId)
019    end)
020    if not success then
021        warn(result)
022    end
023    return success, result
024end
025 
026local function SaveData(player, data)
027    local success, result = pcall(function()
028        PlayerData:SetAsync(player.UserId, data)
029    end)
030    if not success then
031        warn(result)
032    end
033    return success
034end
035 
036local sessionData = {}
037 
038local playerAdded = Instance.new("BindableEvent")
039local playerRemoving = Instance.new("BindableEvent")
040 
041local PlayerManager = {}
042 
043PlayerManager.PlayerAdded = playerAdded.Event
044PlayerManager.PlayerRemoving = playerRemoving.Event
045 
046function PlayerManager.Start()
047    for _, player in ipairs(Players:GetPlayers()) do
048        coroutine.wrap(PlayerManager.OnPlayerAdded)(player)
049    end
050 
051    Players.PlayerAdded:Connect(PlayerManager.OnPlayerAdded)
052    Players.PlayerRemoving:Connect(PlayerManager.OnPlayerRemoving)
053 
054    game:BindToClose(PlayerManager.OnClose)
055end
056 
057function PlayerManager.OnPlayerAdded(player)
058    player.CharacterAdded:Connect(function(character)
059        PlayerManager.OnCharacterAdded(player, character)
060    end)
061 
062    local success, data = LoadData(player)
063    sessionData[player.UserId] = success and data or {
064        Money = 0,
065        UnlockIds = {}
066    }
067 
068    local leaderstats = LeaderboardSetup(PlayerManager.GetMoney(player))
069    leaderstats.Parent = player
070 
071    playerAdded:Fire(player)
072end
073 
074function PlayerManager.OnCharacterAdded(player, character)
075    local humanoid = character:FindFirstChild("Humanoid")
076    if humanoid then
077        humanoid.Died:Connect(function()
078            wait(3)
079            player:LoadCharacter()
080        end)
081    end
082end
083 
084function PlayerManager.GetMoney(player)
085--vv HERES THE SCRIPT BEFORE THE CHANGE vv--
086    local leaderstats = player:FindFirstChild("leaderstats")
087    if leaderstats then
088        local money = leaderstats:FindFirstChild("Money")
089        if money then
090            return money.Value
091        end
092    end
093    return 0
094--^^ HERES THE SCRIPT BEFORE THE CHANGE ^^--
095end
096 
097function PlayerManager.SetMoney(player, value)
098    if value then
099        sessionData[player.UserId].Money = value
100 
101        local leaderstats = player:FindFirstChild("leaderstats")
102        if leaderstats then
103            local money = leaderstats:FindFirstChild("Money")
104            if money then
105                money.Value = value
106            end
107        end    
108    end
109end
110 
111function PlayerManager.OnPlayerRemoving(player)
112    SaveData(player, sessionData[player.UserId])
113    playerRemoving:Fire(player)
114end
115 
116function PlayerManager.OnClose()
117    for _, player in ipairs(Players:GetPlayers()) do
118        PlayerManager.OnPlayerAdded(player)
119    end
120end
121 
122return PlayerManager
 View all 122 lines...

However, the script below breaks the money system and can't recognize it: (look near the bottom of script again)

001local Players = game:GetService("Players")
002local DataStoreService = game:GetService("DataStoreService")
003local PlayerData = DataStoreService:GetDataStore("PlayerData")
004 
005local function LeaderboardSetup(value)
006    local leaderstats = Instance.new("Folder")
007    leaderstats.Name = "leaderstats"
008 
009    local money = Instance.new("IntValue")
010    money.Name = "Money"
011    money.Value = value
012    money.Parent = leaderstats
013    return leaderstats
014end
015 
016local function LoadData(player)
017    local success, result = pcall(function()
018        return PlayerData:GetAsync(player.UserId)
019    end)
020    if not success then
021        warn(result)
022    end
023    return success, result
024end
025 
026local function SaveData(player, data)
027    local success, result = pcall(function()
028        PlayerData:SetAsync(player.UserId, data)
029    end)
030    if not success then
031        warn(result)
032    end
033    return success
034end
035 
036local sessionData = {}
037 
038local playerAdded = Instance.new("BindableEvent")
039local playerRemoving = Instance.new("BindableEvent")
040 
041local PlayerManager = {}
042 
043PlayerManager.PlayerAdded = playerAdded.Event
044PlayerManager.PlayerRemoving = playerRemoving.Event
045 
046function PlayerManager.Start()
047    for _, player in ipairs(Players:GetPlayers()) do
048        coroutine.wrap(PlayerManager.OnPlayerAdded)(player)
049    end
050 
051    Players.PlayerAdded:Connect(PlayerManager.OnPlayerAdded)
052    Players.PlayerRemoving:Connect(PlayerManager.OnPlayerRemoving)
053 
054    game:BindToClose(PlayerManager.OnClose)
055end
056 
057function PlayerManager.OnPlayerAdded(player)
058    player.CharacterAdded:Connect(function(character)
059        PlayerManager.OnCharacterAdded(player, character)
060    end)
061 
062    local success, data = LoadData(player)
063    sessionData[player.UserId] = success and data or {
064        Money = 0,
065        UnlockIds = {}
066    }
067 
068    local leaderstats = LeaderboardSetup(PlayerManager.GetMoney(player))
069    leaderstats.Parent = player
070 
071    playerAdded:Fire(player)
072end
073 
074function PlayerManager.OnCharacterAdded(player, character)
075    local humanoid = character:FindFirstChild("Humanoid")
076    if humanoid then
077        humanoid.Died:Connect(function()
078            wait(3)
079            player:LoadCharacter()
080        end)
081    end
082end
083 
084function PlayerManager.GetMoney(player)
085--vv HERES THE SCRIPT THAT CHANGES AND BREAKS THE MONEY SYSTEM vv--
086      return sessionData[player.UserId].Money
087--^^HERES THE SCRIPT THAT CHANGES AND BREAKS THE MONEY SYSTEM^^--
088end
089 
090function PlayerManager.SetMoney(player, value)
091    if value then
092        sessionData[player.UserId].Money = value
093 
094        local leaderstats = player:FindFirstChild("leaderstats")
095        if leaderstats then
096            local money = leaderstats:FindFirstChild("Money")
097            if money then
098                money.Value = value
099            end
100        end    
101    end
102end
103 
104function PlayerManager.OnPlayerRemoving(player)
105    SaveData(player, sessionData[player.UserId])
106    playerRemoving:Fire(player)
107end
108 
109function PlayerManager.OnClose()
110    for _, player in ipairs(Players:GetPlayers()) do
111        PlayerManager.OnPlayerAdded(player)
112    end
113end
114 
115return PlayerManager
 View all 115 lines...

I'm really sorry if this is hard to follow through without much context, but any help would be extremely appreciated!

[SOLVED] I have a very big bug breaking issue. Can only find the solution to this error?

1 answer

Answer this question