Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
0

Why my plugin keeps adding an extra line to a script source?

Asked by
AProgrammR 398 Moderation Voter
3 years ago
Edited 3 years ago

I am working on a plugin that helps you edit and fix your code.

I made a 'replace keyword' system but when a keyword is replaced in another script source, an extra line comes in the source.

view source
01local rptext = ui.Frame.Replace.Text
02local withtext = ui.Frame.With.Text
03 
04 
05local lines = {}
06 
07for line in string.gmatch(item.Source, "[^\n]*") do
08    if string.find(line,rptext) then
09        local modifiedline = string.gsub(line,rptext,withtext)
10 
11        table.insert(lines, modifiedline)
12 
13    else
14        table.insert(lines, line)
15 
View all 21 lines...

1 answer

Log in to vote
0
Answered by
imKirda 4491 Moderation Voter Community Moderator
3 years ago
Edited 3 years ago

i was trying to find the cause of the issue for a long time but it's kind of hard, i will make an update if i find out about it. what i could find out was that it seems to match some character after some non-empty newlines which returns nil when put into string.byte.

the solution for your case is to just string.split, there really is no need for gmatch, split the string by newlines:

view source
01local rptext = ui.Frame.Replace.Text
02local withtext = ui.Frame.With.Text
03 
04local lines = string.split(item.Source, "\n")
05 
06for i, line in ipairs(lines) do
07    lines[i] = string.gsub(line, rptext, withtext)
08end
09 
10item.Source = table.concat(lines, "\n")

notice there is no reason to check if string.find finds something, gsub won't replace anything if it's not found, you are redundantly doing 2 pattern searches.

now let's get to feedback part, your plugin is absolute trash... like who can't just click Ctrl + H you self appointed programmer ;-;

Ad

Answer this question