Scripting Helpers is winding down operations and is now read-only. More info→

Custom toolbar isn't working properly, help?

Asked by

AProgrammR 398

3 years ago

Edited 3 years ago

Hi. I tried making a toolbar but for some reason, it didn't add the tool. In line 63, it's not changing nil to a tool or printing. Also, no errors in the output

001game.StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack,false)
002 
003-- Tables and vars
004local num = {
005 
006    '1',
007    '2',
008    '3',
009    '4',
010    '5',
011    '6',
012    '7',
013    '8',
014    '9',
015}
016 
017local numinwords = {
018 
019    'One',
020    'Two',
021    'Three',
022    'Four',
023    'Five',
024    'Six',
025    'Seven',
026    'Eight',
027    'Nine',
028}
029 
030local tools = {
031    One = nil ,
032    Two = nil ,
033    Three = nil ,
034    Four = nil ,
035    Five = nil ,
036    Six = nil ,
037    Seven = nil ,
038    Eight = nil ,
039    Nine = nil ,
040 
041}
042 
043local uis = game:GetService('UserInputService')
044 
045local plr = game.Players.LocalPlayer
046 
047local backpack = game.Players.LocalPlayer:WaitForChild('Backpack')
048 
049local frame = script.Parent
050 
051local char = plr.Character
052 
053 
054for i, v in pairs(backpack:GetChildren()) do
055    tools[i] = v
056end
057--Events
058backpack.ChildAdded:Connect(function(tool)
059    print('ok')
060    for i, v in pairs(tools) do
061 
062        if v == nil then
063            print('ok2') -- It's not printing 'ok2'
064            v = tool
065 
066        end
067    end
068 
069    for i, v in pairs(tools) do
070        print(tostring(v))
071    end
072 
073end)
074backpack.ChildRemoved:Connect(function(tool)
075    print('ok')
076    for i, v in pairs(tools) do
077        if v == tool then
078            v = nil -- It's not changing it to nil when removed
079 
080        end
081    end
082 
083    for i, v in pairs(tools) do
084        print(tostring(v))
085    end
086end)
087 
088 
089for i, v in pairs(frame:GetChildren()) do
090    if v:IsA('ImageButton') then
091        print('ok')
092        uis.InputBegan:Connect(function(input)
093 
094            if input.KeyCode == Enum.KeyCode[v.Name] then
095                print('ok')
096 
097                if tools[v.Name] ~= nil then
098 
099                    char.Humanoid:UnequipTool()
100                    char.Humanoid:EquipTool(tools[v.Name])
101                end
102            end
103 
104        end)
105    end
106end
107 
108 
109for i, v in pairs(frame:GetChildren()) do
110    if v:IsA('ImageButton') then
111        v.MouseButton1Click:Connect(function()
112                if tools[v.Name] ~= nil then
113                    char.Humanoid:UnequipTool()
114                    char.Humanoid:EquipTool(tools[v.Name])
115                end
116 
117 
118        end)
119    end
120end
 View all 120 lines...

Any help/suggestion is appreciated.

1 answer

Answered by

imKirda 4491

3 years ago

Edited 3 years ago

for i, v creates you 2 local variables, i and v, when you are assigning different value to these variables you are changing only variables themselves, if you want to change the key in table, you must index the table with that key:

`1`	`tools[i]` `=` `nil` `-- It's changing it to nil when removed`

Same for the second loop:

`1`	`-- v = tool`

`2`	`tools[i]` `=` `tool`

It's also true that when you are setting table's key to nil and loop through it, it will ignore the index with nil value so v == nil is not really possible in your case, I suggest you doing something like:

`1`	`tools[i]` `=` `"None"` `-- It's changing it to nil when removed`

And in check part:

`1`	`if` `v` `==` `"None"` `then`

You possibly have unexpected behavior here:

01local tools = {
02    One = nil ,
03    Two = nil ,
04    Three = nil ,
05    Four = nil ,
06    Five = nil ,
07    Six = nil ,
08    Seven = nil ,
09    Eight = nil ,
10    Nine = nil ,
11}
12 
13for i, v in pairs(backpack:GetChildren()) do
14    tools[i] = v
15end

If you have 3 tools in backpack named "Rocket', "Gun" and "Car" then your table will look like this after the loop:

01tools = {
02    One = nil ,
03    Two = nil ,
04    Three = nil ,
05    Four = nil ,
06    Five = nil ,
07    Six = nil ,
08    Seven = nil ,
09    Eight = nil ,
10    Nine = nil ,
11    [1] = Rocket (Instance),
12    [2] = Gun (Instance),
13    [3] = Car (Instance)
14}

When using print I don't recommend using tostring since it automatically converts arguments to string form, however, instead of converting tables to table_x3e48239482 it converts them to { ... } which are tables that you can open in output and see their content, similar to instances I believe instead of printing their name it will print the instance and you can click it which will show it in explorer.

Thanks and i just realise i also forgot to use 'break AProgrammR 398 — 3y

For the last part about print, I think that's incorrect. I've had some problems where it tries to print an instance so I have to use tostring(). PaleNoobs 37 — 3y

Custom toolbar isn't working properly, help?

1 answer

Answer this question