Scripting Helpers is winding down operations and is now read-only. More info→

I am very new to scripting and wondering if I can get some help making my code better?

Asked by

tightanfall 110

3 years ago

Edited 3 years ago

01local Table = {}
02local Players = game:GetService("Players")
03local playercount = 0
04 
05local function playerlistprint()
06    print("Current Players:")
07    for i, v in pairs(Table) do
08        print(i.." = "..v)
09    end
10end
11Players.PlayerAdded:Connect(function(user)
12    playercount = playercount + 1
13    table.insert(Table, user.Name)
14    print(Table[playercount].." has joined")
15    playerlistprint()
16end)
17 
18Players.PlayerRemoving:Connect(function(user)
19    table.remove(Table, playercount)
20    playercount = playercount - 1
21    print(Table[playercount])
22    playerlistprint()
23end)
 View all 23 lines...

The script works I am just wondering what kind of better way I could go about getting all of the current players names into a table and printing them when one leaves or joins. And when a new player joins I print the entire list of players with join order.

I skimmed Gazza's post and I think he might've mentioned this but I'd use a dictionary. Table[plr.Name] = true...... print(Table["greatneil80"]).... true, it'd save a lot of time and effort. greatneil80 2647 — 3y

2 answers

Answered by

TGazza 1336

3 years ago

The following code looks complicated at first, I've expanded on your example to include a timer. Your way is good and as you say it works but the script might get out of sync with too many players leaving and rejoining or even adding the same player to your Table But with a different index!.

The following code will fix this issues by using the Names of the players as index. For example

`1`	`table.insert(Table,user.Name)`

inserts the user at the end of the table Table = {} this is great in an ideal world but knowing the real world, things happen, like players leaving before they get registered etc... Or they join for a second then leave due to connection problems. So the following code is my attempt at fixing and coding for these problems. And added a 30-second cool down timer for lag drops.

Brace your self for the code! It's quite complex! :P

001local Table = {}
002local Players = game:GetService("Players")
003local playercount = 0
004 
005--// New Varables for the modifications
006--// remove the player that left after this many seconds!
007local RemovePlayerTimer = 30 -- in seconds!
008 
009--// the Lag table for players that just left
010local playersLeftTab = {}
011 
012--// your function as before but modified to shout out who just left and uses your `playercount` Variable to keep track of how many players that are registered.
013 
014local function playerlistprint()
015    print("Current Players: [Active: ",playercount,"], Just Left: [",#playersLeftTab,"]")
016    for i, v in pairs(Table) do
017        print(i," = ",v)
018    end
019end
020 
021--// main PlayersAdded even hookup
022Players.PlayerAdded:Connect(function(user)
023 
024    --// Increase the index of the actual `playercount`
025    playercount = playercount + 1
026 
027    --// check to see if the new player thats joined isnt in the Lag table thats just lagged out and just dropped connection.
028    local PlrIndex = table.find(playersLeftTab,user.Name)
029 
030    -- if they are part of that Lag table then remove them from it! 
031    if(PlrIndex ~= nil) then
032        table.remove(playersLeftTab,PlrIndex)
033 
034    end
035 
036    --// check to see if the user is already Registered, if not then add them!
037    if(Table[user.Name]== nil) then
038--Syntax: Table[Player.Name] = Player in game.Players
039        Table[user.Name] = user
040 
041    --// print out to the output that this player has just joined and is new!
042        print(user.Name.." has joined")
043    else
044        --// if they are part of the `Table` table then just print this out
045        print(user.Name.." has Re-Joined")
046    end
047 
048    --// call your custon player print function
049    playerlistprint()
050end)
051 
052-- PlayerRemoving event hookup (the fun, tricky bit!)
053Players.PlayerRemoving:Connect(function(user)
054    -- if the player leaving is part of the Global `Table` (they should be, but sometimes it may bug out) then continue to add them to the Lag table.
055    if(Table[user.Name] ~= nil)then
056        --// add this player at the end of the Lag table, Indexing isn't important in this table since its only holding the name and the time they left in `tick()`'s
057        table.insert(playersLeftTab, {
058            Name = user.Name,
059            Time = RemovePlayerTimer,
060            Ticker = tick()
061        }
062        ) 
063 
064    end
065--// decrease the physical playercount since someone just left!
066    playercount = playercount - 1
067    --// print this out
068    print(user.Name.." Has Left!")
069    --// update output with the list of players with your custom function
070    playerlistprint()
071end)
072 
073--// while do loop for sorting out the lag table and count up to the lag timeout named `RemovePlayerTimer`
074 
075while true do
076    --// grab the current tick!
077    local NowTick = tick()
078    --// loop through the playersLeftTab table (if this table holds no-one, then this code is just skipped)
079    for k,v in pairs(playersLeftTab) do
080        --// grab the embedded table structure Name, Time and Tick
081        --// the user Name
082        local Name = v.Name
083 
084        --// The Lag timer see (local RemovePlayerTimer = 30 -- in seconds!) above
085        local Time = v.Time
086 
087        --// the tick this player left
088        local Tick = v.Ticker
089 
090        --// Workout the difference between the start and left ticks of each players
091        local DTick = NowTick - Tick
092 
093        --if (DTick is greater or equal to RemovePlayerTimer  or Time variable, then remove them from the global Table, table registry.
094        if(DTick >= Time) then
095            Table[Name] = nil
096            --// next remove them from the Lag Table...
097            table.remove(playersLeftTab,k)
098            --// list the remaning players using your custom function
099            playerlistprint()
100        end
101    end
102-- wait 1 roblox tick
103    wait()
104end
 View all 104 lines...

I've tried to comment what bit does what as plainly as i can. Feel free to ask if you need help! :) The above code works when put into the ServerScriptService Service. I've tested it online and it appears to work well. (had two accounts sign in to the game then one leaves then re-joins before the 30 secs. The script successfully detects this and if they leave and let the 30 secs count down the script forgets them!)

Hope this helps!

Wow, thank you so much! I will try my best to understand whats going on! tightanfall 110 — 3y

Answered by

Soban06 410

3 years ago

Simple use PlayerAdded and PlayerRemoving event like this:

1game.Players.PlayerAdded:Connect(function(player)
2    print(player.Name.."just joined the game!")
3end)
4 
5game.Players.PlayerRemoving:Connect(function(player)
6    print(player.Name.."just left the game!")
7end)

These 2 events check whenever someone joins or leaves the game. The parameter player is the player who left or joined the game.

Hope it helps

Im not sure if you read the full code (no worries if you didnt). But what's happening is I am compiling all of the names of the players into a table and printing all of their names and join order. Shown at line 14. tightanfall 110 — 3y

I edited it to make it easier to understand tightanfall 110 — 3y

I am very new to scripting and wondering if I can get some help making my code better?

2 answers

Answer this question