My automatic gun will not work?

Asked by
3 years ago
Edited 3 years ago
So here's the deal; I tried making an automatic gun but failed. If I hold my mouse button it will work how I intended, but as soon as I spam the gun it shoots extremely fast. Is there any way fix to this? Any answer is appreciated!
Script (You might have to press view source for this one):
001--[[ Values ]]--
002-- Booleans
003local canIdle = true
004local canShoot = true
005local shooting = false
006local canReload = false
007local isRunning = false
008 
009local canStillShoot = true
010 
011-- Numbers
012local spread = 0
013 
014-- Ammo
015local maxAmmo = 30
016local ammo = maxAmmo
017local reloading = false
018--[[ Math ]]--
019 
020--[[ Services ]]--
021local userInputService = game:GetService("UserInputService")
022 
023--[[ Player Variables ]]--
024local player = game:GetService("Players").LocalPlayer
025local character = player.Character or player.CharacterAdded:Wait()
026local playerGui = player:WaitForChild("PlayerGui")
027 
028-- Character
029local humanoid = character:WaitForChild("Humanoid")
030 
031-- Gui
032local gunGui = playerGui:WaitForChild("GunGui")
033local mainFrame = gunGui:WaitForChild("MainFrame")
034local ammoGui = mainFrame:WaitForChild("Ammo")
035 
036--[[ Variables ]]--
037local mod = script.Parent:WaitForChild("Model")
038 
039local equipAnim = humanoid:LoadAnimation(script.Parent:WaitForChild("Equip"))
040local idleAnim = humanoid:LoadAnimation(script.Parent:WaitForChild("Idle"))
041local shootAnim = humanoid:LoadAnimation(script.Parent:WaitForChild("Shoot"))
042local reloadAnim = humanoid:LoadAnimation(script.Parent:WaitForChild("Reload"))
043 
044--[[ Functions ]]--
045 
046--[[ Script ]]--
047script.Parent.Equipped:Connect(function(mouse)
048    canReload = true
049    ammoGui.Text = ammo.." / "..maxAmmo
050 
051    canIdle = true
052 
053    script.Parent.Unequipped:Connect(function()
054        canIdle = false
055        canReload = false
056        canShoot = false
057        shooting = false
058 
059        ammoGui.Text = "---"
060 
061        equipAnim:Stop()
062        idleAnim:Stop()
063        shootAnim:Stop()
064    end)
065 
066    humanoid.Died:Connect(function()
067        canReload = false
068        canIdle = false
069        canShoot = false
070        shooting = false
071    end)
072 
073    equipAnim:Play()
074 
075    wait(equipAnim)
076 
077    if canIdle then
078        idleAnim:Play()
079    end
080 
081    local function Reload()
082        if canReload then
083            ammoGui.Text = "---"
084            reloading = true
085            reloadAnim:Play()
086 
087            wait(reloadAnim.Length)
088 
089            ammo = maxAmmo
090            ammoGui.Text = ammo.." / "..maxAmmo
091            reloading = false
092        end
093    end
094 
095    mouse.Button1Down:Connect(function()
096        if not canStillShoot then return end
097        canStillShoot = false
098        canShoot = true
099        mouse.Button1Up:Connect(function()
100            shooting = false
101            canShoot = false
102 
103            canStillShoot = true
104        end)
105 
106        if canShoot and ammo > 0 and not reloading then
107            canShoot = false
108            shooting = true
109 
110            while shooting and not reloading do
111                ammo = ammo - 1
112                ammoGui.Text = ammo.." / "..maxAmmo
113 
114                canShoot = false
115 
116                shootAnim:Play()
117 
118                humanoid.Running:Connect(function(speed)
119                    if speed <= 0 then
120                        isRunning = true
121                        spread = 6
122                        print("Running")
123                    end
124                end)
125 
126                if not isRunning then
127                    if humanoid:GetState() == Enum.HumanoidStateType.None then
128                        spread = 3
129                        print("None")
130                    elseif humanoid:GetState() == Enum.HumanoidStateType.Jumping or humanoid:GetState() == Enum.HumanoidStateType.FallingDown or  humanoid:GetState() == Enum.HumanoidStateType.Freefall then
131                        spread = 12
132                        print("Jumping")
133                    else
134                        spread = 3
135                        print("Else")
136                    end
137                end
138 
139                local ranSpreadX, ranSpreadY, ranSpreadZ = math.random(-spread, spread), math.random(-spread, spread), math.random(-spread, spread)
140 
141                game.ReplicatedStorage:WaitForChild("RemoteEvents"):WaitForChild("RaycastEvent"):FireServer(script.Parent:WaitForChild("Flame").Position, mouse.Hit.Position, math.random(2,8), Vector3.new(ranSpreadX, ranSpreadY, ranSpreadZ))
142 
143                wait(shootAnim.Length)
144 
145                canShoot = true
146            end
147        elseif not reloading and canShoot then
148            Reload()
149        end
150    end)
151 
152    userInputService.InputBegan:Connect(function(input)
153        if input.KeyCode == Enum.KeyCode.R and not reloading then
154            Reload()
155        end
156    end)
157end)
 View all 157 lines...
im gonna be honest, i kinda gave up when I saw you had 157 lines. Can you shrink the script a bit? Xyternal 247 — 3y
My automatic gun will not work?

1 answer

Answer this question
