Scripting Helpers is winding down operations and is now read-only. More info→

gives me 2 wood instead of 1 wood, I need it to be 1 wood?

Asked by

xxaxxaz 42

3 years ago

Edited 3 years ago

I was following a tutorial with a bit of changes, but when I pressed F it would five me double the amount of wood, and when I press anything else then F or click the wood I get the normal amount. I just want it to give me the normal amount. btw there is not a error.

01local UIS = game:GetService("UserInputService")
02local ReplicatedStorage = game:GetService("ReplicatedStorage")
03local PickupItem = ReplicatedStorage:WaitForChild("Remotes"):WaitForChild("PickupItem")
04local pickupKey = "F"
05 
06local player = game.Players.LocalPlayer
07local mouse = player:GetMouse()
08 
09local PlayerGui = player:WaitForChild("PlayerGui")
10local PickupInfoGui = PlayerGui:WaitForChild("PickupInfoGui")
11 
12UIS.InputChanged:Connect(function(input)
13    if mouse.Target then
14        if mouse.Target:FindFirstChild("Pickable") then
15            local item = mouse.Target
16            PickupInfoGui.Adornee = item
17            PickupInfoGui.ObjectName.Text = item.Name
18            PickupInfoGui.Enabled = true
19        else
20            PickupInfoGui.Adornee = nil
21            PickupInfoGui.Enabled = false
22        end
23    end
24end)
25 
26--I think the problem is these 2 if statements.
27UIS.InputEnded:Connect(function(input) --this one has a enum keycode for F
28    if input.KeyCode == Enum.KeyCode.F then
29        if mouse.Target then
30            if mouse.Target:FindFirstChild("Pickable") then
31                local item = mouse.Target
32                if item then
33                    local distanceFromItem = player:DistanceFromCharacter(item.Position)
34                    if distanceFromItem < 30 then
35                    PickupItem:FireServer(item)
36 
37                    end
38                end
39            end
40        end
41    end
42end)
43UIS.InputEnded:Connect(function()--this one has a if item.Touched
44    if mouse.Target then
45        if mouse.Target:FindFirstChild("Pickable") then
46            local item = mouse.Target
47            if item then
48                if item.Touched then
49                    local DistanceFromItem = player:DistanceFromCharacter(item.Position)
50                    if DistanceFromItem < 30 then
51                        PickupItem:FireServer(item)
52                    end
53                end
54            end
55        end
56    end
57end)
 View all 57 lines...

sorry about the grammer for the title, I had to shorten it so it was under 100 characters long. xxaxxaz 42 — 3y

You seem to be firing the even twice UIS.input ended event twice as line 27-42 is fired and then likes 43-57 fire and since the checks are the same its gonna pass and thus the collecting event is fired twice so your collection doubles. Zeppelin0330 38 — 3y

yes but one of them say a if command in it to see if it was clicked. xxaxxaz 42 — 3y

2 answers

Answered by

dylindude 64

3 years ago

Try adding an F button on mobile so then on the screen for mobile players, instead of having to click it they can just click the extra F

Answered by

Zeppelin0330 38

3 years ago

Lines 27- 42 and 43-57 are fired at the same time and so your checks in both pass since they are identical you would have both events fire which would as a result double the collection. I suggest you to remove lines 43-57 and change your lines 27 -42 to:

01UIS.InputEnded:Connect(function(input)
02        if input.KeyCode == Enum.KeyCode.F or input.UserInputType = Enum.UserInputType.MouseButton1 then
03            if mouse.Target then
04            if mouse.Target:FindFirstChild("Pickable") then
05                    local item = mouse.Target
06                    if item then
07                        local distanceFromItem = player:DistanceFromCharacter(item.Position)
08                 if distanceFromItem < 30 then
09                        PickupItem:FireServer(item)
10 
11                        end
12                    end
13                end
14            end
15        end
16    end)

they are not indinticle xxaxxaz 42 — 3y

but thx for trying xxaxxaz 42 — 3y

gives me 2 wood instead of 1 wood, I need it to be 1 wood?

2 answers

Answer this question