Scripting Helpers is winding down operations and is now read-only. More info→

[SOLVED] Why does my character not heal more than once?

Asked by

grandiosav4 62

3 years ago

Edited 3 years ago

So, I am making a simple game about collecting apples to heal yourself, you need to collect enough apples in order to not die. You take x amount of damage per second.

And the problem is that when I collect an apple the first time everything goes as planned and I get healed, but the second time I collect an apple I do not heal. I have not seen anyone else get the same issue and was wondering how to fix this. I also do not get any errors in the output.

Part of a script that tells a value to get updated to 20

`1`	`game.ReplicatedStorage.heal.Value` `=` `20`

LocalScript that handles the new value and updates your health

1local humanoid = game.Players.LocalPlayer.Character.Humanoid
2local heal = game:GetService("ReplicatedStorage"):WaitForChild("heal")
3while wait() do
4    humanoid.Health = humanoid.Health + game.ReplicatedStorage.heal.Value
5    if heal.Value >= 1 then heal.Value = 0 end
6end

oh i probably should've mentioned that you collect the apples by touching them, not clicking and the script that tells the localscript to heal you is in the apple

UPDATE : Ok so i found that the local script that handles the new value doesnt see that the value has changed the second time i grab an apple. Does anyone know why this is happening?

Log:

11:56.573  applePickupScript thinks that heal.Value = 20  -  Server
11:56.574  Script says that actall value is 20  -  Server - Script:2 -- Script that i used for debugging checking which script is right.
11:56.591  LocalScript thinks that heal.Value = 0  -  Client - LocalScript:6

Check out this post for the soultion to my problem https://scriptinghelpers.org/questions/123520/solved-why-does-my-localscript-not-see-that-ive-changed-a-value

2 answers

Answered by

IlLupoMannaro34 7

3 years ago

maybe you could place a serverscript inside the apples

assuming you have a clickdetector inside it:

1script.Parent.ClickDetector.MouseClick:Connect(function(plr)
2local Hum = plr.Character:FindFirstChild("Humanoid")
3Hum.Health = Hum.Health + 20
4 
5end)

i havent tested it, frankly i dont know if it works but you could try.

i hope i helped

oh i probably should've mentioned that you collect the apples by touching them, not clicking and the script that tells the localscript to heal you is in the apple. grandiosav4 62 — 3y

Heal them from server scripts. if its touch change the first line to script.Parent.Touched instead of click detector.mouseclick BulletproofVast 1033 — 3y

You can directly heal the player when they touch instead of updating a value. touched param is the part that touched (probably the players legs/feet) so do if touch.parent (which is the players character) :findfirstchild'humanoid' then add the health to the humanoid BulletproofVast 1033 — 3y

I tried healing the player directly from the server script but that didn't work either grandiosav4 62 — 3y

Answered by

Xapelize 2658

3 years ago

You should try directly heal for the person touched, not updating the value since you need to loop through, and if the value updates the script is also looping and heal the player, what you are gonna do is heal him ONCE only for each apple

here is the script, put it inside apple so it's serversided

1script.Parent.Touched:Connect(function(hit) -- If hit
2    if hit.Parent:FindFirstChild("Humanoid") == true then -- Check if humanoid exists
3        local Humanoid = hit.Parent.Humanoid -- Locate the Humanoid
4 
5        Humanoid.Health = Humanoid.Health + 20 -- Heal the player 20 health
6        script.Parent:Destroy() -- Destroy the apple (Because it's eaten (Who want to eat your eaten apple????))
7    end
8end

[SOLVED] Why does my character not heal more than once?

2 answers

Answer this question