Scripting Helpers is winding down operations and is now read-only. More info→

Why does the animation not stop even though :Stop() is called?

Asked by

vonotige 49

3 years ago

I am trying to make a trash can that you can push around and I'm stuck on the idle animation. This is the code:

01isPushed = script.Parent.Pushing
02proximity = script.Parent.BodyAttach.ProximityPrompt
03idleAnimation = script.Parent.BodyAttach.Idle
04 
05function onTrigger(player)
06    if isPushed.Value == false then
07        local character = player.Character
08        local humanoid = character:WaitForChild("Humanoid")
09        local animator = humanoid:WaitForChild("Animator")
10        local animateScript = character:WaitForChild("Animate")
11        defaultAnim1 = animateScript.idle.Animation1.AnimationId
12        defaultAnim2 = animateScript.idle.Animation2.AnimationId
13        animateScript.idle.Animation1.AnimationId = idleAnimation.AnimationId
14        animateScript.idle.Animation2.AnimationId = idleAnimation.AnimationId
15        for i,track in pairs(animator:GetPlayingAnimationTracks()) do
16            track:Stop(0)
17        end
18        local playerTorso = player.Character:WaitForChild("UpperTorso")
19        M6D = Instance.new("Motor6D", playerTorso)
20        M6D.Name = "TrashGrip"
21        playerTorso.TrashGrip.Part0 = playerTorso
22        playerTorso.TrashGrip.Part1 = script.Parent.BodyAttach
23        proximity.Style = Enum.ProximityPromptStyle.Custom
24        isPushed.Value = true
25    else
26        local character = player.Character
27        local humanoid = character:WaitForChild("Humanoid")
28        local animator = humanoid:WaitForChild("Animator")
29        local animateScript = character:WaitForChild("Animate")
30        animateScript.idle.Animation1.AnimationId = defaultAnim1
31        animateScript.idle.Animation2.AnimationId = defaultAnim2
32        for i,track in pairs(animator:GetPlayingAnimationTracks()) do
33            track:Stop(0)
34        end
35        M6D:Destroy()
36        M6D = nil
37        proximity.Style = Enum.ProximityPromptStyle.Default
38        isPushed.Value = false
39    end
40end
41 
42proximity.Triggered:Connect(function(player)
43    onTrigger(player)
44end)
 View all 44 lines...

As you can see there is a loop in both cases that should stop all animations that are playing. But it doesn't stop the idle animation and it only changes if the character moves and becomes idle again.

3 answers

Answered by

Shounak123 461

3 years ago

Edited 3 years ago

I think in line 16 and 33, you put track:Stop(0)when it should be track:Stop() If you remove the zero then your script will be working fine.

I tried that, but it didn't change anything. Also :Stop() and :Stop(0) should theoretically do the same thing. vonotige 49 — 3y

Answered by

vonotige 49

3 years ago

Instead of stopping all animations on the player, I instead opted to play the idle animation until the player moves. This is done by checking if humanoid.MoveDirection is not equal to 0,0,0

Answered by

1JBird1 64

3 years ago

instead of getting the animation tracks from the animator, get it from the humanoid instead.

so it would probably look like this:

1for i,track in pairs(humanoid:GetPlayingAnimationTracks()) do
2 if track.Animation.AnimationId == “rbxasset//insert_animation_id” then
3  track:Stop()
4 end
5end

Why does the animation not stop even though :Stop() is called?

3 answers

Answer this question