Scripting Helpers is winding down operations and is now read-only. More info→

How should I let the script be able to reveal a value's value?

Asked by

3 years ago

So I'm making a trading system for Evercyan's RPG Kit and I noticed a problem. My script wasn't detecting a value's value. Here is the script:

01local player1 = script.Parent.Parent.Parent.Parent
02local playername = player1.TradePlayer
03local player2 = game.Players:WaitForChild(playername.Value)
04local readyon = false
05local confirmon = false
06while true do
07    wait()
08    if script.Parent.Visible == true then
09    if readyon == false then
10        if player1.PlayerGui.NotifGUI.Trading.Ready.Text == "Ready" and player2.PlayerGui.NotifGUI.Trading.Ready.Text == "Ready" then
11            readyon = true
12            player1.PlayerGui.NotifGUI.Trading.Ready.Text = "Confirm"
13            player2.PlayerGui.NotifGUI.Trading.Ready.Text = "Confirm"
14            confirmon = true
15        end
16    end
17    if confirmon == true then
18        if player1.PlayerGui.NotifGUI.Trading.Ready.Visible == false and player2.PlayerGui.NotifGUI.Trading.Ready.Visible == false then
19            confirmon = false
20            readyon = false
21            local gui1 = script.Parent
22            local gui2 = player2.PlayerGui.NotifGUI.Trading
23            local sword1 = gui1.SwordA
24            local sword2 = gui1.SwordB
25            local sword3 = gui1.SwordC
26            local sword4 = gui1.SwordD
27            local sword5 = gui1.SwordE
28            local othersword1 = gui2.SwordA
29            local othersword2 = gui2.SwordB
30            local othersword3 = gui2.SwordC
31            local othersword4 = gui2.SwordD
32            local othersword5 = gui2.SwordE
33            if not sword1.Text == "Empty Slot" then
34                player1.StarterGear:WaitForChild(sword1.Text):Destroy()
35            end
36            if not sword2.Text == "Empty Slot" then
37                player1.StarterGear:WaitForChild(sword2.Text):Destroy()
38            end
39            if not sword3.Text == "Empty Slot" then
40                player1.StarterGear:WaitForChild(sword3.Text):Destroy()
41            end
42            if not sword4.Text == "Empty Slot" then
43                player1.StarterGear:WaitForChild(sword4.Text):Destroy()
44            end
45            if not sword5.Text == "Empty Slot" then
46                player1.StarterGear:WaitForChild(sword5.Text):Destroy()
47            end
48            if not othersword1.Text == "Empty Slot" then
49                local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword1.Text):Clone()
50                tool.Parent = player1.StarterGear
51            end
52            if not othersword2.Text == "Empty Slot" then
53                local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword2.Text):Clone()
54                tool.Parent = player1.StarterGear
55            end
56            if not othersword3.Text == "Empty Slot" then
57                local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword3.Text):Clone()
58                tool.Parent = player1.StarterGear
59            end
60            if not othersword4.Text == "Empty Slot" then
61                local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword4.Text):Clone()
62                tool.Parent = player1.StarterGear
63            end
64            if not othersword5.Text == "Empty Slot" then
65                local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword5.Text):Clone()
66                tool.Parent = player1.StarterGear
67                end
68                player1:LoadCharacter()
69                player2:LoadCharacter()
70        end
71        end
72    end
73end
 View all 73 lines...

what value? tell me the line too. btw use "local player1 = game.Players.LocalPlayer" instead of that messy one (bad practice) acediamondn123 147 — 3y

It's not a local script and playername is the value. For some reason when it does have a value and I print it's value it says it's "" for no reason at all. CandyWreckEpicness 115 — 3y

1 answer

Answered by

CandyWreckEpicness 115

3 years ago

I realized my mistake. You have to put it after the if visible thing.

01local readyon = false
02local confirmon = false
03while true do
04    wait()
05    if script.Parent.Visible == true then
06        local player1 = script.Parent.Parent.Parent.Parent
07        local playername = script.Parent.Parent.Parent.Parent.TradePlayer.Value
08        local player2 = game.Players:WaitForChild(playername)
09        if readyon == false then
10            if player1.PlayerGui.NotifGUI.Trading.Ready.Text == "Ready" and player2.PlayerGui.NotifGUI.Trading.Ready.Text == "Ready" then
11                readyon = true
12                player1.PlayerGui.NotifGUI.Trading.Ready.Text = "Confirm"
13                player2.PlayerGui.NotifGUI.Trading.Ready.Text = "Confirm"
14                confirmon = true
15            end
16        end
17        if confirmon == true then
18            if player1.PlayerGui.NotifGUI.Trading.Ready.Visible == false and player2.PlayerGui.NotifGUI.Trading.Ready.Visible == false then
19                confirmon = false
20                readyon = false
21                local gui1 = script.Parent
22                local gui2 = player2.PlayerGui.NotifGUI.Trading
23                local sword1 = gui1.SwordA
24                local sword2 = gui1.SwordB
25                local sword3 = gui1.SwordC
26                local sword4 = gui1.SwordD
27                local sword5 = gui1.SwordE
28                local othersword1 = gui2.SwordA
29                local othersword2 = gui2.SwordB
30                local othersword3 = gui2.SwordC
31                local othersword4 = gui2.SwordD
32                local othersword5 = gui2.SwordE
33                if not sword1.Text == "Empty Slot" then
34                    player1.StarterGear:WaitForChild(sword1.Text):Destroy()
35                end
36                if not sword2.Text == "Empty Slot" then
37                    player1.StarterGear:WaitForChild(sword2.Text):Destroy()
38                end
39                if not sword3.Text == "Empty Slot" then
40                    player1.StarterGear:WaitForChild(sword3.Text):Destroy()
41                end
42                if not sword4.Text == "Empty Slot" then
43                    player1.StarterGear:WaitForChild(sword4.Text):Destroy()
44                end
45                if not sword5.Text == "Empty Slot" then
46                    player1.StarterGear:WaitForChild(sword5.Text):Destroy()
47                end
48                if not othersword1.Text == "Empty Slot" then
49                    local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword1.Text):Clone()
50                    tool.Parent = player1.StarterGear
51                end
52                if not othersword2.Text == "Empty Slot" then
53                    local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword2.Text):Clone()
54                    tool.Parent = player1.StarterGear
55                end
56                if not othersword3.Text == "Empty Slot" then
57                    local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword3.Text):Clone()
58                    tool.Parent = player1.StarterGear
59                end
60                if not othersword4.Text == "Empty Slot" then
61                    local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword4.Text):Clone()
62                    tool.Parent = player1.StarterGear
63                end
64                if not othersword5.Text == "Empty Slot" then
65                    local tool = game.ReplicatedStorage.GameItems:WaitForChild(othersword5.Text):Clone()
66                    tool.Parent = player1.StarterGear
67                end
68                sword1.Parent.Visible = false
69                player1:LoadCharacter()
70            end
71        end
72    end
73end
 View all 73 lines...

How should I let the script be able to reveal a value's value?

1 answer

Answer this question