Can someone help me understand why this isn't working? Big juicy monkey brain no work right

Asked by

4 years ago

This question has been solved by the original poster.

I have a character ability system that works for the most part, however, for some reason I can't get my head around, this won't work. The RemoteEvent I have set up is only supposed to execute once, and then check that the ability that it's linked to is disabled, yet after the first time it completely breaks, especially if you spam it. Obviously hints towards something not being reset properly, but it is? Idk but here's the code:

001-----------------------
002-- General Variables --
003-----------------------
004 
005local player = game:GetService("Players"):WaitForChild(script.Parent.Name)
006local character = workspace:WaitForChild(player.Name)
007local humanoid = character:WaitForChild("Humanoid")
008 
009local RunService = game:GetService("RunService")
010local ServerStorage = game:GetService("ServerStorage")
011 
012local Events = game:GetService("ReplicatedStorage").RemoteEventsAndFunctions
013 
014local SetHUDProgressBar = Events.SetHUDProgressBar
015 
016local AbilityEvents = Events.Abilities
017 
018local disableActions = script.DisableActions
019 
020local ability1 = script.Ability1
021local ability2 = script.Ability2
022local ability3 = script.Ability3
023local abilitySlots = {ability1, ability2, ability3}
024 
025local activateAbility1Cooldown = false
026local activateAbility2Cooldown = false
027local activateAbility3Cooldown = false
028local ability1Cooldown = 0
029local ability2Cooldown = 0
030local ability3Cooldown = 0
031local ability1Disabled = false
032local ability2Disabled = false
033local ability3Disabled = false
034 
035----------------------------------
036-- Character specific variables --
037----------------------------------
038 
039local SlamEvent = AbilityEvents.Slam
040local ChargeEvent = AbilityEvents.Charge
041local PunchEvent = AbilityEvents.Punch
042 
043local slamFolder = script.BruteMoveset.Slam
044local slamAttackTime = slamFolder.AttackTime.Value
045local slamRecoveryTime = slamFolder.RecoveryTime.Value
046 
047local slamAnim = slamFolder.Animations.Slam
048local slamRecovery = slamFolder.Animations.SlamRecovery
049local slamAnimTrack = humanoid:LoadAnimation(slamAnim)
050local slamAnimRecoveryTrack = humanoid:LoadAnimation(slamRecovery)
051 
052--------------------
053-- Base functions --
054--------------------
055 
056local function GetAbilitySlot(abilityFolder)
057    for i, v in ipairs(abilitySlots) do
058        if v.Value == abilityFolder then
059            return i
060        else
061            return -1
062        end
063    end
064end
065 
066local function ActivateCooldown(slotIndex)
067    if slotIndex == 0 then
068        ability1Cooldown = abilitySlots[0].Value.Cooldown.Value
069        activateAbility1Cooldown = true
070    elseif slotIndex == 1 then
071        ability2Cooldown = abilitySlots[1].Value.Cooldown.Value
072        activateAbility2Cooldown = true
073    elseif slotIndex == 2 then
074        ability3Cooldown = abilitySlots[2].Value.Cooldown.Value
075        activateAbility3Cooldown = true
076    end
077end
078 
079local function GetAbilityDisabled(slotIndex)
080    if slotIndex == 0 then
081        return ability1Disabled
082    elseif slotIndex == 1 then
083        return ability2Disabled
084    elseif slotIndex == 2 then
085        return ability3Disabled
086    end
087end
088 
089local function SetAbilityDisabled(slotIndex, value)
090    if slotIndex == 0 then
091        ability1Disabled = value
092    elseif slotIndex == 1 then
093        ability2Disabled = value
094    elseif slotIndex == 2 then
095        ability3Disabled = value
096    end
097end
098 
099local function SpawnAOE(size, cframe)
100    local newAOE = ServerStorage.GameplayObjects.DestructiveAOE:Clone()
101    newAOE.Instigator.Value = player.Character
102    newAOE.Size = Vector3.new(size, size, size)
103    newAOE.Parent = workspace
104    newAOE.CFrame = cframe
105    newAOE.BreakWelds.Disabled = false
106end
107 
108----------------------------------
109-- Character specific functions --
110----------------------------------
111 
112SlamEvent.OnServerEvent:Connect(function(_player)
113    local slotIndex = GetAbilitySlot(slamFolder)
114    local abilityDisabled = GetAbilityDisabled(slotIndex)
115 
116    if _player == player and slotIndex ~= -1 and abilityDisabled == false then
117        SetAbilityDisabled(slotIndex, true)
118        disableActions.Value = true
119 
120        SetHUDProgressBar:FireClient(_player, slotIndex, 1, false, 0)
121 
122        slamAnimTrack:Play()
123        slamAnimTrack:AdjustSpeed(1/slamAttackTime - (1/slamAttackTime) * 0.2)
124 
125        slamAnimTrack:GetMarkerReachedSignal("AboutToSlam"):Connect(function(stringParam)
126            slamAnimTrack:AdjustSpeed(1)
127        end)
128 
129        slamAnimTrack.Stopped:Connect(function()
130            SpawnAOE(slamFolder.AOESize.Value, character.HumanoidRootPart.CFrame * CFrame.new(0,-9,-10))
131            slamAnimRecoveryTrack:Play()
132            slamAnimRecoveryTrack:AdjustSpeed(1/slamRecoveryTime)
133 
134            slamAnimRecoveryTrack.Stopped:Connect(function()
135                disableActions.Value = false
136                ActivateCooldown(slotIndex)
137                SetHUDProgressBar:FireClient(_player, slotIndex, 0, true, abilitySlots[slotIndex].Value.Cooldown.Value)
138            end)
139        end)
140    end
141end)
142 
143RunService.Stepped:Connect(function(_time, step)
144    if activateAbility1Cooldown == true and ability1Disabled == true then
145        ability1Cooldown = ability1Cooldown - step
146 
147        if ability1Cooldown <= 0 then
148            activateAbility1Cooldown = false
149            ability1Disabled = false
150        end
151    end
152 
153    if activateAbility2Cooldown == true and ability2Disabled == true then
154        ability2Cooldown = ability2Cooldown - step
155 
156        if ability2Cooldown <= 0 then
157            activateAbility2Cooldown = false
158            ability2Disabled = false
159        end
160    end
161 
162    if activateAbility3Cooldown == true and ability3Disabled == true then
163        ability3Cooldown = ability3Cooldown - step
164 
165        if ability3Cooldown <= 0 then
166            activateAbility3Cooldown = false
167            ability3Disabled = false
168        end
169    end
170end)
 View all 170 lines...

"pairs" is used for things like the GetChildren() function. But "ipairs" are used to loop through tables efficiently. Shounak123 461 — 4y

Can someone help me understand why this isn't working? Big juicy monkey brain no work right

1 answer

Answer this question