Scripting Helpers is winding down operations and is now read-only. More info→

How to load a function after GetAsync?

Asked by

iMazariuz 36

4 years ago

Edited 4 years ago

Detailed explanation here. I created a character customization menu and i stored the data on Server Storage. And then i created a function to load those each time the character respawns, which is player.Character.CharacterAdded. It works. The thing is, this script runs before the getAsync could get any data from the server so the first time a player joined. They will not load their customised character.

Now i temporarily fixed this by waiting around (5) to (10) after a character has been added, and then loading it. It works, but it isn't exactly giving my game a polished feel. Because it also affects the player respawn. Their custom char wont load until 5-10 sec.

Full script over here: https://pastebin.com/wKAkBTQn

(sorry if you cringe while reading the script. It's only been a few days since i started roblox studio with no experience in scripting at all so bear with me :> )

Alright. What should i do to make it run the load function after only after the data has been loaded from the server.

Any help would be greatly appreciated.

Can you show the full script? The error is located at line 36 but you didn't provide any of lines 36. If you did send the script, please tell us what line its starting at Xapelize 2658 — 4y

You may need to share the full script for different reasons - Single blocks of scripts have linear evaluation, and the CharacterAdded is only bound after the info is loaded. I fail to see how this could be resolved by a wait. User#6546 35 — 4y

Line 36 is just the function to load the player's color selection, which on first time joining will results in nil becuase the function has been loaded before th server could fetch the player's customization save. But sure, let me share the whole script. iMazariuz 36 — 4y

1 answer

Answered by

Yuuwa0519 197

4 years ago

Edited 4 years ago

I think a module made by evaera called "Promise", a library ported from Java? (not too sure), which is a future-proofing method may be handy here. in fact, the examples they provide uses a http service get request, which is similar to datastore get request, so it may be very useful for you :D

https://devforum.roblox.com/t/promises-and-why-you-should-use-them/350825

01--Example usage of promise with datastore, if you are confused with http example
02 
03--Settings
04local DSS_NAME = "PlayerDataV1"
05local DATA_PREFIX = "_DataV1"
06 
07--Services
08local DSS = game:GetService("DataStoreService")
09local Players = game:GetService("Players")
10 
11--Modules / Libraries
12local Promise = require(path.to.promiseLibrary) --i'd recommend having it in replicated storage
13 
14--Var
15local PlrDataStore = DSS:GetDataStore(DSS_NAME)
16 
17--Funcs
18local dataGet(key)
19    return Promise.async(function(resolve, reject)
20        local success, result = pcall(PlrDataStore, PlrDataStore, key)
21 
22        if success then
23            resolve(result)
24        else
25            reject(result)
26        end
27    end)
28end
29 
30local function LoadData(plr)
31    dataGet(plr.Name .. DATA_PREFIX)
32        :andThen(function(body)
33            --andThen() only runs when resolve() is called in dataGet()
34            --do the plr.CharacterData. stuff here
35 
36            return body --returning body allows the next andThen() to read the body 
37        end)
38        :andThen(function(body)
39            --promise allows you to chain stuff, so you can do multiple stuff
40        end)
41        :catch(function(warning)
42            --catch() is only ran when reject() is called in dataGet()
43            --the data wasn't loaded, so either kick a player or retry the load data.
44            warn(warning)
45            LoadData(plr)
46        end)    
47        :finally(function(body)
48            --Finally is ran when the other calls above are all done running whether it successes or fails.
49            print("Done Doing the Process of Promise!!")
50        end)
51end
52 
53--Main
54Players.PlayerAddedConnect(LoadData)
 View all 54 lines...

Yes, its very complicated, but trust me the Promise is one of the most useful library as roblox involves many asynchronous calls (mainly data store, other like remote functions, etc)

Alright i'll look into it, thank you. I'll mark this as an answer as soon as i get it to work :) iMazariuz 36 — 4y

How to load a function after GetAsync?

1 answer

Answer this question