Scripting Helpers is winding down operations and is now read-only. More info→

DataStore not saving data correctly?

Asked by

Fixer1987 95

4 years ago

I've been trying to create a random name generator for all players whenever they firstly join the game, then save it through DataStore. However, each times I play the game I will just get a new name EVEN if the output says (4 times lol) the data has been saved. Help?

01local DataStoreService = game:GetService("DataStoreService")
02local dataStore = DataStoreService:GetDataStore("MyDataStore")
03 
04local function saveData(player)
05 
06    local tableToSave = {
07        player.Character:WaitForChild("Values").Name.Value; 
08        player.Character:WaitForChild("Values").Surname.Value
09    }
10 
11    local success, err = pcall(function()
12        dataStore:SetAsync(player.UserId, tableToSave)
13    end)
14 
15    if success then
16        print("Data has been saved!")
17    else
18        print("Data hasn't been saved!")
19        warn(err)       
20    end
21end
22 
23game.Players.PlayerAdded:Connect(function(player)
24    local data 
25    local success, err = pcall(function()
26 
27        data = dataStore:GetAsync(player.UserId)
28 
29    end)
30 
31    local character = player.Character or player.CharacterAdded:Wait()
32    local Name = player.Character:WaitForChild("Values").Name.Value
33    local Surname = player.Character:WaitForChild("Values").Surname.Value
34    local Names = {"Guren", "Yuuichiro"}
35    local randomName = Names[math.random(1, #Names)]
36    local Surnames = {"Ichinose", "Hyakuya"}
37    local randomSurname = Surnames[math.random(1, #Surnames)]
38 
39    if success and Name ~= nil then
40        Name = data[1]
41        Surname = data[2]
42        print(Name, Surname)
43 
44    else       
45        Surname = tostring(randomSurname)
46        Name = tostring(randomName)
47        print(Name, Surname)
48    end
49 
50end)
51 
52game.Players.PlayerRemoving:Connect(function(player) 
53    local success, err  = pcall(function()
54        saveData(player)
55    end)
56 
57    if success then
58        print("Data has been saved")
59    else
60        print("Data has not been saved!")
61    end
62end)
63 
64game:BindToClose(function()
65    for _, player in pairs(game.Players:GetPlayers()) do
66        local success, err  = pcall(function()
67            saveData(player)
68        end)
69 
70        if success then
71            print("Data has been saved")
72        else
73            print("Data has not been saved!")
74        end
75    end
76end)
 View all 76 lines...

2 answers

Answered by

incurszio 70

4 years ago

This should fix the error you're having, let me know if there are still any errors.

01local DataStoreService = game:GetService("DataStoreService")
02local dataStore = DataStoreService:GetDataStore("MyDataStore3")
03local players = 0
04 
05game.Players.PlayerAdded:Connect(function(player)
06 
07    players = players + 1
08    local key = "Player_"..player.UserId
09 
10    local data 
11    local success, err = pcall(function()
12 
13        data = dataStore:GetAsync(key)
14 
15    end)
16 
17    local character = player.Character or player.CharacterAdded:Wait()
18    local Name = player.Character:WaitForChild("Values"):FindFirstChild("Name")
19    local Surname = player.Character:WaitForChild("Values"):FindFirstChild("Surname")
20    local Names = {"Guren", "Yuuichiro"}
21    local randomName = Names[math.random(1, #Names)]
22    local Surnames = {"Ichinose", "Hyakuya"}
23    local randomSurname = Surnames[math.random(1, #Surnames)]
24 
25    if data then
26        Name.Value = data["Name"]
27        Surname.Value = data["Surname"]
28        print("loaded previous data "..data["Name"].." "..data["Surname"])
29    else       
30        Surname.Value = randomSurname
31        Name.Value = randomName
32        print("loads new data "..Name.Value.." "..Surname.Value)
33    end
34 
35end)
36 
37local function create_table(player)
38    local character = player.Character or player.CharacterAdded:Wait()
39    local player_stats = {}
40    for _, stat in pairs(character:FindFirstChild("Values"):GetChildren()) do
41        player_stats[stat.Name] = stat.Value
42    end
43    return player_stats
44end
45 
46local bindableEvent = Instance.new("BindableEvent")
47 
48game.Players.PlayerRemoving:Connect(function(player) 
49    local player_stats = create_table(player)
50    local key = "Player_"..player.UserId -- this is the key we use to save the data
51 
52    local success, err  = pcall(function()
53        dataStore:SetAsync(key, player_stats)
54        players = players - 1
55        bindableEvent:Fire()
56    end)
57 
58    if success then
59        print("Data has been saved")
60    else
61        warn(err)
62    end
63end)
64 
65game:BindToClose(function()
66    while players > 0 do
67        bindableEvent.Event:Wait()
68    end
69end)
 View all 69 lines...

It does! Thank you a lot. <3 (no homo) Fixer1987 95 — 4y

If I want to change my name, do I just use the server output to modify the name value in my character? Fixer1987 95 — 4y

Yes, you could do it via remote-events, and if you want to reset stats just do this. dataStore:RemoveAsync(key) incurszio 70 — 4y

Answered by

cheslin23t 4

4 years ago

There is nothing wrong with this script. It is the script of how you set those values

There is no script that sets those values, as I aforementioned the values are all set in the script and require no other script. Fixer1987 95 — 4y

DataStore not saving data correctly?

2 answers

Answer this question