How do I prevent Guis from cloning the same Gui twice?

Asked by

4 years ago

Edited 4 years ago

So uh I have an inventory script and a backpack gui. Everything functions however in this link you will see a weird bug where all the items cloned twice. Does anyone know how to delete extra clones?

https://gyazo.com/22c8c5ba3b43124ef87678666f3f45cf

this is the backpack script:

01local player = game.Players.LocalPlayer
02local character = player.Character
03local items = {}
04local buttons = {}
05game.StarterGui:SetCoreGuiEnabled(Enum.CoreGuiType.Backpack,false) -- Makes the original backpack gui invisible
06 
07function search()
08    for i,v in pairs(game.Players.LocalPlayer.Backpack:GetChildren()) do -- Find all item in a specific location
09        if v:isA("Tool") then -- If the item found is a "Tool"
10            table.insert(items,v) -- We're going to put all the tools found in a table.
11        end
12    end
13end
14 
15function refresh()
16    for i,v in pairs(buttons) do -- Finds all items in the table
17        v:Destroy() -- Destroy 'em all
18    end
19    for i,v in pairs(items) do -- Finds all items in the table
20        local button = script.Sample:Clone() -- clones the sample button inside the localscript
21        button.Name = v.Name -- sets the cloned button's name to the name of the item
22        button.LayoutOrder = i
23        button.Parent = script.Parent.Handler -- Sets the parent of the cloned button to the handler
24        button.Image = v.TextureId -- Sets the image of the button to the texture id of the tool
25        button.ZIndex = 7
26        button.BackgroundColor3 = Color3.fromRGB(50,50,50)
27        button.BorderColor3 = Color3.fromRGB(25,25,25)
28        button.BorderMode = Enum.BorderMode.Inset
29        button.BorderSizePixel = 5
30        table.insert(buttons,button) -- Inserts the button to our table "buttons"
31        button.MouseButton1Click:connect(function()
32            if script.Parent.Handler.Selected.Value == nil or script.Parent.Handler.Selected.Value ~= v then -- Checks if the selected value is nothing or if the selected value is not the button
33                script.Parent.Frame.ItemName.Text = v.Name -- Sets the TextLabel's Text to the name of the tool/button
34                script.Parent.Frame.ImageLabel.Image = v.TextureId -- Sets the image label's image to the texture id of the tool
35                script.Parent.Handler.Selected.Value = v
36                if script.Parent.Handler.Selected.Value ~= script.Parent.Handler.Equipped.Value then --if the selected value is not the same as the equipped value then
37                    script.Parent.Handler.Location.Value = v.Parent -- Sets the value of our location to the parent of the tool whether it is in the backpack or in the character
38                    script.Parent.Frame.Equip.Text = "Equip" -- Self explanatory
39                elseif script.Parent.Handler.Selected.Value == script.Parent.Handler.Equipped.Value then -- If the selected value is the same as the equipped value then...
40                    script.Parent.Handler.Location.Value = v.Parent
41                    script.Parent.Frame.Equip.Text = "Unequip"
42                end
43            end
44        end)
45    end
46end
47 
48function backpackRefresh()
49    items = {}
50    search(character)
51    search(player.Backpack)
52    refresh()
53end
54 
55backpackRefresh()
56 
57player.Backpack.ChildAdded:connect(backpackRefresh)
58player.Backpack.ChildRemoved:connect(backpackRefresh)
59 
60character.ChildAdded:connect(backpackRefresh)
61character.ChildRemoved:connect(backpackRefresh)
 View all 61 lines...

can you put the codes in a code block? Struggage 10 — 4y

btw the game is treating the extra clones the same way as the normal clones. for example if the normal clone dissapears the extra also dissapears NGC4637 602 — 4y

How do I prevent Guis from cloning the same Gui twice?

1 answer

Answer this question