Getting user input without a tool?

Asked by

10 years ago

I am currently working on a feature where you can click on certain objects and interact with them in different ways (this is why I have many variables set up, and are not being used). I have first started making interaction with an enemy possible (through setting a combat variable to true and making selection box to red, though I hope to expand it later). When testing this script, scrolling over an NPC will not allow you to see a selectionbox, and clicking it will do nothing, it also shows no errors. I would GREATLY appreciate it if you could figure out what is wrong with the following code:

01-- Setting all variables
02local player = game.Players.LocalPlayer
03local character = player.Character
04if not character or character.Parent == nil then
05    character = player.CharacterAdded:wait()
06end
07local charpos = character.Torso.Position
08local mouse = player:GetMouse()
09local selection = Instance.new("SelectionBox", player.PlayerGui)
10selection.Color = BrickColor.new("Medium stone grey")
11local combat = script.combat
12local talking = script.talking
13local reading = script.reading
14local questing = script.questing
15 
16--check target and make variables when mouse moves
17mouse.Move:connect(function()
18    local target = mouse.Target
19    local hum = target.Parent:FindFirstChild("Humanoid")
20    local hrp = target.Parent:FindFirstChild("HumanoidRootPart")
21    local enemy = target.Parent:FindFirstChild("enemy")
22    local friend = target.Parent:FindFirstChild("friendly")
23    local quest = target.Parent:FindFirstChild("quest")
24    local book = target.Parent:FindFirstChild("book")
25    --check if the target is an npc and not a player
26    if target.Parent:IsA("Model") and hum ~= nil and hrp ~= nil then
27        selection.Adornee = target.Parent
28        -- if the target has the enemy value in it
29        if target.Parent.enemy == true then
30            --and the player clicks on target
31            mouse.Button1Down:connect(function()
32                --and the player is close enough
33                local targetpos = target.Parent.Torso.Position
34                if player:DistanceFromCharacter(targetpos) < 40 then
35                    --set combat equal to true, and make the selectionbox red
36                    combat.Value = true
37                    selection.Ardornee = target.Parent
38                    selection.Color = BrickColor.new("Bright red")
39                end
40            end)
41        end
42    end
43end)
 View all 43 lines...

Thank you for reading :)

Line 28, you misspelled Adornee and spelled "Ardornee". Also, on line 25 you assumed the target's parent is a player and it has a Torso. I would recommend checking that first. Another tip is for line 34 where you check the magnitude from the character's position and the target's position. That is a rather inaccurate method, I highly recommend using DistanceFromCharacter instead. Aethex 256 — 10y

Thanks for the corrections, however, it still doesn't seem to work, and no errors are occurring. Also, I put the line of code that declares targetpos in a place where it is guaranteed to have a torso. novipak 70 — 10y

Line 37 is also spelled as "Ardornee" when it should be Adornee. Aethex 256 — 10y

It might also help to find out what is working and what is not by printing to the output. You can check to make sure the function is being called correctly, and each if statement is correct or not. Aethex 256 — 10y

View all comments (2 more)

I might also add that on line 18, you check the mouse's target object; however, it is possible for the target to be nil, so you should check for that in the case the mouse is not hovering over any object. Aethex 256 — 10y

You just assume 'target.Parent.enemy' exists even when it may not. Perci1 4988 — 10y

Getting user input without a tool?

2 answers

Answer this question