Scripting Helpers is winding down operations and is now read-only. More info→

Why does my tool not change a value within a part after colliding with it?

Asked by

EiOooAxea 70

4 years ago

Edited 4 years ago

So basically i have an axe and a tree with a NumberValue that's name is "Health" and when I slash with the axe and the head of the axe collides with the tree its supposed to do 5 dmg but it doesn't even detect the number value

script:

01Properties = {
02    debounce = true, -- Leave this on true.
03    sound_fx = true, -- If you don't want sound to play when tool is activated set this to false.
04    anim_check = true, -- If you don't want animation to play when tool is activated set this to false.
05    ToolDrop = false, -- Set this to true if you want to be able to drop the tool by pressing BackSpace.
06    soundID = 6042531284, -- Sound Id.
07    AnimID = 6461572129, -- Your Animtion id.
08    debounce_lenght = 1, -- how long it will take before you can click again, aka cooldown so you can't spam click the tool.
09    soundDelay = 0.25, -- How long to wait before playing sound
10    enableTrail = true, -- Enable trail thing
11    trail = script.Parent.Head.Trail, -- the trail thing
12    damage = 5 -- how much dmg the thing does
13}
14 
15local Tool = script.Parent
16local Handle = Tool:WaitForChild("Handle")
17local BaseUrl = "rbxassetid://"
18local anim = Tool:WaitForChild("Animation")
19local Players = game:GetService("Players")
20 
21 
22if Properties.sound_fx then
23    sound = Handle:WaitForChild("Sound")
24    sound.SoundId = BaseUrl .. Properties.soundID
25    sound.MaxDistance = 100
26    sound.RollOffMode = Enum.RollOffMode.InverseTapered
27end
28 
29 
30 
31if Properties.anim_check then  
32    anim.AnimationId = BaseUrl .. Properties.AnimID
33end
34 
35 
36if Properties.ToolDrop == true then
37    Tool.CanBeDropped = true
38end
39 
40Tool.Equipped:Connect(function(Mouse) -- When you equip the tool
41    local player = Players:GetPlayerFromCharacter(Tool.Parent) -- gets the player
42    if Properties.anim_check == true then animation = player.Character.Humanoid:LoadAnimation(anim)end -- loads animation
43 
44    Tool.Activated:Connect(function() -- when you click with the tool
45        if Properties.debounce then
46            Properties.debounce = false
47            if Properties.anim_check == true then animation:Play()end
48            if Properties.sound_fx == true then wait(Properties.soundDelay) sound:Play()end
49 
50            if Properties.enableTrail == true then
51                Properties.trail.Enabled = true
52                wait(0.2)
53                Properties.trail.Enabled = false
54            end
55 
56            script.Parent.Head.Touched:Connect(function(Hit)
57                print(Hit.Name)
58                if Hit:FindFirstChild("NumberValue") and Hit:FindFirstChild("NumberValue").Name == "Health" then
59                    local temp = Hit:FindFirstChild("NumberValue")
60                    print(temp.Name .. ": " .. temp.Value)
61                    temp.Value = temp.Value - Properties.damage
62                end
63            end)
64 
65            wait(Properties.debounce_lenght)    
66            Properties.debounce = true
67        end
68    end)
69end)
70Tool.Unequipped:Connect(function()
71    if Properties.anim_check == true then animation:Stop()end
72    if Properties.sound_fx then sound:Stop()end
73end)
 View all 73 lines...

LocalScript or ServerScript? OhManXDXD 445 — 4y

Also is the name of the NumberValue “NumberValue”? OhManXDXD 445 — 4y

Server script and read the description EiOooAxea 70 — 4y

1 answer

Answered by

OhManXDXD 445

4 years ago

I think the problem here is, you are looking for a child named “NumberValue” but not a NumberValue itself.

Use FindFirstChildWhichIsA() to find a type of child instead of the name of a child

01Properties = {
02    debounce = true, -- Leave this on true.
03    sound_fx = true, -- If you don't want sound to play when tool is activated set this to false.
04    anim_check = true, -- If you don't want animation to play when tool is activated set this to false.
05    ToolDrop = false, -- Set this to true if you want to be able to drop the tool by pressing BackSpace.
06    soundID = 6042531284, -- Sound Id.
07    AnimID = 6461572129, -- Your Animtion id.
08    debounce_lenght = 1, -- how long it will take before you can click again, aka cooldown so you can't spam click the tool.
09    soundDelay = 0.25, -- How long to wait before playing sound
10    enableTrail = true, -- Enable trail thing
11    trail = script.Parent.Head.Trail, -- the trail thing
12    damage = 5 -- how much dmg the thing does
13}
14 
15local Tool = script.Parent
16local Handle = Tool:WaitForChild("Handle")
17local BaseUrl = "rbxassetid://"
18local anim = Tool:WaitForChild("Animation")
19local Players = game:GetService("Players")
20 
21 
22if Properties.sound_fx then
23    sound = Handle:WaitForChild("Sound")
24    sound.SoundId = BaseUrl .. Properties.soundID
25    sound.MaxDistance = 100
26    sound.RollOffMode = Enum.RollOffMode.InverseTapered
27end
28 
29 
30 
31if Properties.anim_check then  
32    anim.AnimationId = BaseUrl .. Properties.AnimID
33end
34 
35 
36if Properties.ToolDrop == true then
37    Tool.CanBeDropped = true
38end
39 
40Tool.Equipped:Connect(function(Mouse) -- When you equip the tool
41    local player = Players:GetPlayerFromCharacter(Tool.Parent) -- gets the player
42    if Properties.anim_check == true then animation = player.Character.Humanoid:LoadAnimation(anim)end -- loads animation
43 
44    Tool.Activated:Connect(function() -- when you click with the tool
45        if Properties.debounce then
46            Properties.debounce = false
47            if Properties.anim_check == true then animation:Play()end
48            if Properties.sound_fx == true then wait(Properties.soundDelay) sound:Play()end
49 
50            if Properties.enableTrail == true then
51                Properties.trail.Enabled = true
52                wait(0.2)
53                Properties.trail.Enabled = false
54            end
55 
56            script.Parent.Head.Touched:Connect(function(Hit)
57                print(Hit.Name)
58                if Hit:FindFirstChildWhichIsA("NumberValue") and Hit:FindFirstChildWhichIsA("NumberValue").Name == "Health" then
59                    local temp = Hit:FindFirstChildWhichIsA("NumberValue")
60                    print(temp.Name .. ": " .. temp.Value)
61                    temp.Value = temp.Value - Properties.damage
62                end
63            end)
64 
65            wait(Properties.debounce_lenght)    
66            Properties.debounce = true
67        end
68    end)
69end)
70Tool.Unequipped:Connect(function()
71    if Properties.anim_check == true then animation:Stop()end
72    if Properties.sound_fx then sound:Stop()end
73end)
 View all 73 lines...

Ty it works now, i just gotta add a de bounce system to it somehow,im not super familiar with how to make a debounce system so any help is appreciated EiOooAxea 70 — 4y

It looks like there is already a debounce implemented OhManXDXD 445 — 4y

there isnt? EiOooAxea 70 — 4y

Properties.debounce OhManXDXD 445 — 4y

View all comments (7 more)

wait nvm thats for the animation etc but i need to de bounce the damage etc EiOooAxea 70 — 4y

i added a simple debounce but it didnt seem to work for whatever reason EiOooAxea 70 — 4y

it does the damage 2 times EiOooAxea 70 — 4y

sometimes it does once, sometimes twice and sometimes 3 times EiOooAxea 70 — 4y

https://pastebin.com/eAfPbzif EiOooAxea 70 — 4y

nvm i fixed the debounce somehow lol EiOooAxea 70 — 4y

Why does my tool not change a value within a part after colliding with it?

1 answer

Answer this question