So, the code you have would essentially do this:
1 | local plrs = Players:GetChildren() |
2 | local n = math.random(1, #plrs) |
4 | game.ReplicatedStorage.StringValues.Player1.Value = n.Name |
5 | local n2 = math.random(1, #plrs) |
7 | game.ReplicatedStorage.StringValues.Player2.Value = n2.Name |
Therefore you're trying to say for example 3.Name, which of course doesn't make sense. If you want to get the actual player object, you need to index the table plrs using the nth value you got from before.
As so:
1 | local plrs = Players:GetPlayers() |
2 | local n = math.random(1, #plrs) |
3 | game.ReplicatedStorage.StringValues.Player1.Value = plrs[n].Name |
4 | local n2 = math.random(1, #plrs) |
5 | game.ReplicatedStorage.StringValues.Player2.Value = plrs[n].Name |
However my final solution is simple. First principle of programming: DRY
Don't
Repeat
Yourself
And using that rule, we can use a simple for loop to make this more elegant and easier to adjust should we want to add more players to StringValues.
1 | local plrs = Players:GetChildren() |
4 | for i = 1, numPlayers do |
5 | local n = math.random(1, #plrs) |
6 | local val = game.ReplicatedStorage.StringValues:FindFirstChild(string.format("Player%d",n)) |
7 | val.Value = plrs[n].Name |
I hope this helps and answers your question, if it did, please make sure to accept it :)
0
