Scripting Helpers is winding down operations and is now read-only. More info→

Data doesn't save upon rejoining, anyone knows why?

Asked by

4 years ago

01local dataStoreService = game:GetService("DataStoreService")
02local killSave = dataStoreService:GetDataStore("PlayerKills")
03 
04game.Players.PlayerAdded:Connect(function(player)
05 
06    local totalKills
07    local success, err = pcall(function()
08        totalKills = killSave:GetASync("Player_"..player.UserId)
09    end)
10 
11    local leaderstats = Instance.new("Folder")
12    leaderstats.Name = "leaderstats"
13    leaderstats.Parent = player
14 
15    local kills = Instance.new("IntValue")
16    kills.Name = "Kills"
17    if success then
18        kills.Value = totalKills
19    else
20        kills.Value = 0
21    end
22    kills.Parent = leaderstats
23 
24    local rank = Instance.new("StringValue")
25    rank.Name = "Rank"
26    rank.Value = "Human"
27    rank.Parent = leaderstats
28 
29    local function updateKills(newKills)
30        if newKills then
31            if newKills >= 25 then
32                rank.Value = "Supreme"
33            end
34            if newKills >= 100 then
35                rank.Value = "Sage"
36            end
37        end
38    end
39 
40    updateKills()
41    kills.Changed:Connect(updateKills)
42 
43end)
44 
45local function save(player)
46    local success, err = pcall(function()
47        killSave:SetAsync("Player_"..player.UserId, player.leaderstats.Kills.Value)
48    end)
49    if success then
50        print("saved successfully")
51    else
52        print("failed to save")
53    end
54end
55 
56local function autosave()
57    while wait(15) do
58        for i, player in pairs(game:GetService("Players"):GetPlayers()) do
59            print("saving")
60            save(player)
61        end
62    end
63end
64 
65spawn(autosave)
66 
67game.Players.PlayerRemoving:Connect(function(player)
68    save(player)
69end)
 View all 69 lines...

I have API Services allowed so I have no clue what causes the data to not store.

Are you only testing on roblox studio? I had a similar problem where data wont save but when I tested in the actual game it suddenly worked. Rayguyban2 89 — 4y

1 answer

Answered by

Galvarino 25

4 years ago

Edited 4 years ago

The PlayerRemoving event is, in some cases, not quite enough to save all data, as the server closing itself will kill this script when it tries to save the data. Sure, you are hardly saving much with that save() function, but saving to datastores can take a really long time as it takes a long time to communicate with the servers. I resolved this problem myself by using the methods in this tutorial, where it is explained that you should use :BindToClose() in addition to PlayerRemoving. Hopefully this helps!

Edit: here is exactly how I do this in my game.

1game.Players.PlayerRemoving:Connect(function()
2    SaveData(Player)
3end)
4 
5game:BindToClose(function()
6    SaveData(Player)
7end)

Also also; this fix SHOULD work 100% of the time, and if you expect the data to always save when a player leaves, then there is no need for that autosave function you have. And use coroutines instead for the future! Galvarino 25 — 4y

You have to define Player. You can't just say that, you have to loop through game.Players:GetPlayers() and save for each player. rabbi99 714 — 4y

Didn't work, could you try to edit the script for me if I did something wrong because I'm new to scripting and still make a lot of mistakes. Vbrostiic 0 — 4y

Data doesn't save upon rejoining, anyone knows why?

1 answer

Answer this question