Scripting Helpers is winding down operations and is now read-only. More info→

Why is this error coming up if my script is correct?

Asked by

TeaWithMee 76

4 years ago

Error: attempt to index nil with 'TorsoPart Code: Local Script ?

1game.ReplicatedStorage.Event1.OnClientEvent:Connect(function(plr)
2    local player = game.Players.LocalPlayer.Name --Find Player name
3    local char = game.Workspace:FindFirstChild(player) --Get the player in workspace
4 
5    print("Flipped")
6    wait(6)
7    char.TorsoPart.ProximityPrompt.Enabled = false
8    end)

Before this fires i have code that clones a part in the workspace which has a proximity prompt inside it, it clones it into the players model and positions inside of the players uppertorso.

so all i am looking for is why is my code not working even though when i manually check in the explorer tab the TorsoPart is inside of the model

2 answers

Answered by

Nicklaus_s 17

4 years ago

TorsoPart does not exist, it probably has different name, you might be looking for "UpperTorso", or "LowerTorso", OR "Torso".

i understand the error but i created the part and put it inside of the players model so its there. and if you check through the explorer tab you can see its there TeaWithMee 76 — 4y

There is no 'TorsoPart' in Characters. You are probably looking for 'UpperTorso' or 'LowerTorso' (in R15 Characters) or for 'Torso' (in R6 Characters). Jermartynojm 0 — 4y

Answered by

imKirda 4491

4 years ago

Edited 4 years ago

Because your script is not correct, attempt to index nil means you did

`1`	`nil.TorsoPart....`

Which is not acceptable in Luau. Your char variable is nil which means the gamers character is not yet spawned. You have few problems in your code, first is at at the first line and that's OnClientEvent does not return plr argument because you know who the LocalPlayer is, second is that the way you get Character is by accessing Player.Character, doing workspace:FindFirstChild(player.Name) is bad. It will work fine in most cases, but it's not preferred.

To fix that you need to check if the character exists or wait until your character gets spawned, i don't know your situation so you need to choose one. So first one is to check if character is not nil:

01game.ReplicatedStorage.Event1.OnClientEvent:Connect(function()
02    local player = game.Players.LocalPlayer -- get the Player, not his name
03    local char = player.Character -- refers to player's character or nil if character is not in the world
04 
05    print("Flipped")
06    wait(6)
07 
08    --/Simple if statement will prevent your script from erroring because
09    --\it will only pass if given condition is not false and not nil. In this case
10    --\it will pass if [char] is not nil, exactly what you need.
11    if (char) then
12        char.TorsoPart.ProximityPrompt.Enabled = false
13    end
14end)

This will prevent the script from erroring but this might not be what you wanted, let's say you want to wait for the character to add, this is why you use CharacterAdded event, it fires when character spawns and returns the character.

01game.ReplicatedStorage.Event1.OnClientEvent:Connect(function()
02    local player = game.Players.LocalPlayer
03 
04    --/Will refer to current character OR will wait until new character
05    --\is spawned and refer to it
06    local char = player.Character or player.CharacterAdded:Wait()
07 
08    print("Flipped")
09    wait(6)
10 
11    --/If statement is still needed because after waiting 6 seconds
12    --\state of the character could have changed
13    if (char) then
14        char.TorsoPart.ProximityPrompt.Enabled = false
15    end
16end)

In case your character does not exist yet, it will yield until CharacterAdded fires because i used :Wait(), it's a function of RBXScriptSignal which yields until it fires and returns what the signal returns, in this case it returns character.

or statement is very simple

1local Something = nil or false
2local Number = nil or 5
3local String = "String" or "String2"
4local Bool = false or true
5 
6print(Something, Number, String, Bool)
7-- false, 5, "String", true

In case of variables it checks if first given statement is not false and not nil, if it's not it will assign variable to it, but if it is false or nil then it will assign variable to value given after the or, no matter what it is, nil or false, it will assign it.

the 2nd one down works like my original one but when i reset or get killed the error comes up. even though i have it so the part inserts into the player every time they respawn or come into the game TeaWithMee 76 — 4y

Oh right because when you reset your character does not become nil, it's parented to nil instead, so you need to check if char.Parent is not nil on line 13 in my second example; change it to: if (char.Parent) then ... imKirda 4491 — 4y

that works, there is no error but when i respawn nothing happens even though it worked the first time when i first joined TeaWithMee 76 — 4y

theen you need to make sure you are actually firing [Event1], it's possible that something is wrong with the script firing it. imKirda 4491 — 4y

Why is this error coming up if my script is correct?

2 answers

Answer this question