Scripting Helpers is winding down operations and is now read-only. More info→

How to put debounces to multiple functions efficiently?

Asked by

Dehydrocapsaicin 483

4 years ago

So I'm trying to make a combat system with multiple attacks and I don't want players to be spamming the same attack over and over again.

Was:

01local UIS = game:GetService("UserInputService")
02 
03local cooldown = false
04 
05local function attack1()
06 
07    if not cooldown then
08        cooldown = true
09        --block of codes
10        wait()
11        cooldown = false
12    end
13 
14end
15 
16local function attack2()
17 
18    if not cooldown then
19        cooldown = true
20        --block of codes
21        wait()
22        cooldown = false
23    end
24 
25end
26 
27local function attack3()
28 
29    if not cooldown then
30        cooldown = true
31        --block of codes
32        wait()
33        cooldown = false
34    end
35 
36end
37 
38local function attack4()
39 
40    if not cooldown then
41        cooldown = true
42        --block of codes
43        wait()
44        cooldown = false
45    end
46 
47end
48 
49UIS.InputBegan:Connect(function(input, gameProcessed)
50    if input.UserInputType == Enum.UserInputType.Keyboard then
51        if input.KeyCode == Enum.KeyCode.Q then
52            attack1()
53        end
54 
55        if input.KeyCode == Enum.KeyCode.E then
56            attack2()
57        end
58 
59        if input.KeyCode == Enum.KeyCode.Z then
60            attack3()
61        end
62 
63        if input.KeyCode == Enum.KeyCode.C then
64            attack4()
65        end
66    end
67end
 View all 67 lines...

Attempt No. 1; I thought it was perfect but it didn't work. Please let me know if you do know why.

01local UIS = game:GetService("UserInputService")
02 
03local function attack1()
04    local cooldown = false
05 
06    if not cooldown then
07        cooldown = true
08        --block of codes
09        wait()
10        cooldown = false
11    end
12 
13end
14 
15local function attack2()
16    local cooldown = false
17 
18    if not cooldown then
19        cooldown = true
20        --block of codes
21        wait()
22        cooldown = false
23    end
24 
25end
26 
27local function attack3()
28    local cooldown = false
29 
30    if not cooldown then
31        cooldown = true
32        --block of codes
33        wait()
34        cooldown = false
35    end
36 
37end
38 
39local function attack4()
40    local cooldown = false
41 
42    if not cooldown then
43        cooldown = true
44        --block of codes
45        wait()
46        cooldown = false
47    end
48 
49end
50 
51UIS.InputBegan:Connect(function(input, gameProcessed)
52    if input.UserInputType == Enum.UserInputType.Keyboard then
53        if input.KeyCode == Enum.KeyCode.Q then
54            attack1()
55        end
56 
57        if input.KeyCode == Enum.KeyCode.E then
58            attack2()
59        end
60 
61        if input.KeyCode == Enum.KeyCode.Z then
62            attack3()
63        end
64 
65        if input.KeyCode == Enum.KeyCode.C then
66            attack4()
67        end
68    end
69end
 View all 69 lines...

Attempt No. 2

01local UIS = game:GetService("UserInputService")
02 
03local cooldown = false
04local cooldown2 = false
05local cooldown3 = false
06local cooldown4 = false
07 
08local function attack1()
09 
10    if not cooldown then
11        cooldown = true
12        --block of codes
13        wait()
14        cooldown = false
15    end
16 
17end
18 
19local function attack2()
20 
21    if not cooldown2 then
22        cooldown2 = true
23        --block of codes
24        wait()
25        cooldown2 = false
26    end
27 
28end
29 
30local function attack3()
31 
32    if not cooldown3 then
33        cooldown3 = true
34        --block of codes
35        wait()
36        cooldown3 = false
37    end
38 
39end
40 
41local function attack4()
42 
43    if not cooldown4 then
44        cooldown4 = true
45        --block of codes
46        wait()
47        cooldown4 = false
48    end
49 
50end
51 
52UIS.InputBegan:Connect(function(input, gameProcessed)
53    if input.UserInputType == Enum.UserInputType.Keyboard then
54        if input.KeyCode == Enum.KeyCode.Q then
55            attack1()
56        end
57 
58        if input.KeyCode == Enum.KeyCode.E then
59            attack2()
60        end
61 
62        if input.KeyCode == Enum.KeyCode.Z then
63            attack3()
64        end
65 
66        if input.KeyCode == Enum.KeyCode.C then
67            attack4()
68        end
69    end
70end
 View all 70 lines...

Now, the second attempt actually did work. But I want to know if there's a more efficient/simple way to do it. Thank you.

do you want them all to have cooldown's together or individually? - I'm guessing individually, if so I'd say this way is efficient, I have no clue why attempt one wouldn't work UNLESS the local cooldown interfered with the other functions. shadowstorm440 590 — 4y

I want them to have cooldowns individually, Sir. Dehydrocapsaicin 483 — 4y

I'd say it's efficient enough, lua is not so easy when it comes to putting in things like if statements or debounces. shadowstorm440 590 — 4y

Aight, Sir. Thanks! Dehydrocapsaicin 483 — 4y

1 answer

Answered by

User#40702 85

4 years ago

You could use a table to store all the cooldowns and the function.

01local attacks = {
02    attack1 = {
03        cooldown = false,
04        run = function()
05            -- Code here
06        end
07    },
08    attack2 = {
09        cooldown = false,
10        run = function()
11            -- Code here
12        end
13    },
14    attack3 = {
15        cooldown = false,
16        run = function()
17            -- Code here
18        end
19    },
20    attack4 = {
21        cooldown = false,
22        run = function()
23            -- Code here
24        end
25    }
26}
27 
28local function attack(name)
29    if not attacks[name].cooldown then
30        attacks[name].cooldown = true
31        attacks[name].run()
32        attacks[name].cooldown = false
33    end
34end
35 
36game:GetService("UserInputService").InputBegan:Connect(function(input, gameProcessed)
37    if input.UserInputType == Enum.UserInputType.Keyboard then
38        if input.KeyCode == Enum.KeyCode.Q then
39            attack("attack1")
40        end
41 
42        if input.KeyCode == Enum.KeyCode.E then
43            attack("attack2")
44        end
45 
46        if input.KeyCode == Enum.KeyCode.Z then
47            attack("attack3")
48        end
49 
50        if input.KeyCode == Enum.KeyCode.C then
51            attack("attack4")
52        end
53    end
54end
 View all 54 lines...

This is something I would do.

How to put debounces to multiple functions efficiently?

1 answer

Answer this question