Scripting Helpers is winding down operations and is now read-only. More info→

I am trying to code a role picker. Can anybody help?

Asked by

4 years ago

So basically, I am trying to code a role picker. There is one person chosen to be a werewolf, one person chosen to be a villager, one person chosen to be a clairvoyant, one person chosen to be a witch, one person chosen to be a jester and one person chosen to be a clown. I also want to make it so that there is only one person per role, no one can have the same role as the other. Everything in this script works except for the role picker (at the bottom of the script). Can anybody help me? Here is the whole script that I have made:

001--Variables
002local ReplicatedStorage = game:GetService("ReplicatedStorage")
003 
004local ServerStorage = game:GetService("ServerStorage")
005 
006local Status = game.ReplicatedStorage.Status
007--Script
008while true do
009 
010    Status.Value = "Waiting for enough players to play"
011    repeat wait(1) until game.Players.NumPlayers >= 2
012    Status.Value = "Intermission"
013    wait(30)
014    Status.Value = "Get ready!"
015    wait(4)
016 
017    local plrs = {}
018 
019    for i, player in pairs(game.Players:GetPlayers()) do
020        if player then
021            table.insert(plrs,player) -- Add each player into plrs table
022        end
023    end
024 
025    local GameZone = game.Workspace.GameZone
026 
027    local ClonedGameZone = GameZone:Clone()
028    ClonedGameZone.Parent = workspace
029 
030    --Teleporting players to the gamezone
031    local Seats = ClonedGameZone:FindFirstChild("Seats")
032    if not Seats then
033        print("Seats not found")
034    end
035 
036    local AvailableSeats = Seats:GetChildren()
037    for i, player in pairs(plrs) do
038        if player then
039            character = player.Character
040 
041            if character then
042                -- Teleport them
043 
044                character:FindFirstChild("HumanoidRootPart").CFrame = AvailableSeats[1].CFrame + Vector3.new(0,10,0)
045                table.remove(AvailableSeats,1)
046 
047                character.Humanoid.WalkSpeed = 0
048                character.Humanoid.JumpPower = 0
049 
050                local GameTag = Instance.new("BoolValue")
051                GameTag.Name = "GameTag"
052                GameTag.Parent = player.Character   
053            else
054                -- There is no character
055                if not player then
056                    table.remove(plrs,i)
057                end
058            end
059        end
060    end
061    wait(4)
062    if #plrs == 2 then
063        Status.Value = "Choosing roles.."
064        wait(1)
065 
066        local Enemies = {}
067        local Allies = {}
068        local Neutrals = {}
069 
070        local WerewolfNumber = math.random(1, #plrs)
071        local Werewolf = #plrs[WerewolfNumber]
072        table.remove(plrs,WerewolfNumber)
073        WerewolfNumber.PlayerGui.MainFrame.Visible = true
074        WerewolfNumber.PlayerGui.MainFrame.Role.Text = "A WEREWOLF"
075        WerewolfNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(203, 0, 4)
076        WerewolfNumber.PlayerGui.MainFrame.Description.Text = "You are an enemy. You can kill anyone except your teammate: the Clown. Blend in with the allies to not look suspicious, try not to get voted out and win by killing all allies until there is one left. Good luck."
077        table.insert(Enemies,WerewolfNumber)
078 
079        local ClownNumber = math.random(1, #plrs)
080        local Clown = #plrs[ClownNumber]
081        table.remove(plrs,ClownNumber)
082        ClownNumber.PlayerGui.MainFrame.Visible = true
083        ClownNumber.PlayerGui.MainFrame.Role.Text = "A CLOWN"
084        ClownNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(253, 102, 8)
085        ClownNumber.PlayerGui.MainFrame.Description.Text = "You are an enemy. Only once in the whole game, you can kill anyone, except for your teammate: the Werewolf, when it's their turn to play. Blend in with the allies to not look suspicious, try not to get voted out and win by killing all allies until there is one left. Good luck."
086        table.insert(Enemies,ClownNumber)
087 
088        local VillagerNumber = math.random(1, #plrs)
089        local Villager = #plrs[VillagerNumber]
090        table.remove(plrs,VillagerNumber)
091        VillagerNumber.PlayerGui.MainFrame.Visible = true
092        VillagerNumber.PlayerGui.MainFrame.Role.Text = "A VILLAGER"
093        VillagerNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(206, 205, 134)
094        VillagerNumber.PlayerGui.MainFrame.Description.Text = "You are an ally. You do not have a turn to play during the night so you cannot do anything. However, your goal is to try to vote out the enemies (the Werewolf and the Clown). Good luck."
095        table.insert(Allies,VillagerNumber)
096 
097        local JesterNumber = math.random(1, #plrs)
098        local Jester = #plrs[JesterNumber]
099        table.remove(plrs,JesterNumber)
100        JesterNumber.PlayerGui.MainFrame.Visible = true
101        JesterNumber.PlayerGui.MainFrame.Role.Text = "A JESTER"
102        JesterNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(4, 61, 206)
103        JesterNumber.PlayerGui.MainFrame.Description.Text = "You are neutral. Your goal is to get voted out. However, you don't win when you get killed. Act suspicious and blend in with the enemies. Good luck."
104        table.insert(Neutrals,JesterNumber)
105 
106        local WitchNumber = math.random(1, #plrs)
107        local Witch = #plrs[WitchNumber]
108        table.remove(plrs,WitchNumber)
109        WitchNumber.PlayerGui.MainFrame.Visible = true
110        WitchNumber.PlayerGui.MainFrame.Role.Text = "A WITCH"
111        WitchNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(80, 0, 206)
112        WitchNumber.PlayerGui.MainFrame.Description.Text = "You are an ally. After the werewolves have killed someone, you can either revive the victim with your reviving potion that you can use only once in the entire game, kill someone other than the victim with your killing potion that you can use only once in the entire game, or not do anything. Try to vote out the enemies. Good luck."
113        table.insert(Allies,WitchNumber)
114 
115        local ClairvoyantNumber = math.random(1, #plrs)
116        local Clairvoyant = #plrs[ClairvoyantNumber]
117        table.remove(plrs,ClairvoyantNumber)
118        ClairvoyantNumber.PlayerGui.MainFrame.Visible = true
119        ClairvoyantNumber.PlayerGui.MainFrame.Role.Text = "A CLAIRVOYANT"
120        ClairvoyantNumber.PlayerGui.MainFrame.Role.TextColor3 = Color3.fromRGB(252, 0, 215)
121        ClairvoyantNumber.PlayerGui.MainFrame.Description.Text = "You are an ally. When it's your turn to play during the night, you can choose someone to see their role, so choose wisely. Try to vote out the enemies. Good luck."
122        table.insert(Allies,ClairvoyantNumber)
123    end
124 
125end
 View all 125 lines...

2 answers

Answered by

R1ceNice 20

4 years ago

1local WerewolfNumber = math.random(1, #plrs)
2local Werewolf = #plrs[WerewolfNumber]
3table.remove(plrs,WerewolfNumber)
4WerewolfNumber.PlayerGui.MainFrame.Visible = true -- Number is a number!
5WerewolfNumber.PlayerGui.MainFrame.Role.Text = "A WEREWOLF"
6....

should be

1local WerewolfNumber = math.random(1, #plrs)
2local Werewolf = #plrs[WerewolfNumber]
3table.remove(plrs,WerewolfNumber)
4Werewolf.PlayerGui.MainFrame.Visible = true -- Now we are referencing the player object
5Werewolf.PlayerGui.MainFrame.Role.Text = "A WEREWOLF"

Answered by

chess123mate 5873

4 years ago

(This is a comment)

Some tips:

Open the Output window if you haven't already so that you can see what errors occur
It's bad practice to update the UI on the server (though it'll work okay in this case). You can use RemoteEvents to avoid this.
You have a lot of duplicate code (ie code that is very similar). If you learn how to use tables/dictionaries (and/or functions), you'll be able to reduce this duplication.

ex:

01local ReplicatedStorage = game:GetService("ReplicatedStorage")
02local ServerStorage = game:GetService("ServerStorage")
03local Status = game.ReplicatedStorage.Status
04 
05local Roles = { -- List of roles in order to hand them out
06    {
07        RoleText = "A WEREWOLF",
08        TextColor3 = Color3.fromRGB(203, 0, 4),
09        Description = "You are an enemy. You can kill anyone except your teammate: the Clown. Blend in with the allies to not look suspicious, try not to get voted out and win by killing all allies until there is one left. Good luck.",
10        Team = "Enemies",
11    },
12    {
13        RoleText = "A VILLAGER",
14        TextColor3 = Color3.fromRGB(206, 205, 134),
15        Description = "You are an ally. You do not have a turn to play during the night so you cannot do anything. However, your goal is to try to vote out the enemies (the Werewolf and the Clown). Good luck.",
16        Team = "Allies",
17    },
18    -- TODO repeat for each other role
19}
20 
21while true do
22    -- ... (TODO I removed the code above the role-giving-out-section for clarity, but you should put it back)
23    wait(4)
24    if #plrs == 2 then
25        Status.Value = "Choosing roles.."
26        wait(1) -- NOTE: You don't have to wait here, it just makes everything take longer
27        local teams = {
28            Enemies = {},
29            Allies = {},
30            Neutrals = {},
31        }
32        for _, role in ipairs(Roles)
33            local num = math.random(1, #plrs)
34            local player = table.remove(plrs, num)
35            local MainFrame = player.PlayerGui.MainFrame
36            MainFrame.Visible = true
37            MainFrame.Role.Text = role.RoleText
38            MainFrame.Role.TextColor3 = role.TextColor3
39            MainFrame.Description.Text = role.Description
40            table.insert(teams[role.Team], player)
41            if #plrs == 0 then -- no more players; stop giving out roles
42                break
43            end
44        end
45        -- if you want your Enemies/etc variables, you can do this:
46        local Enemies = teams.Enemies
47        local Allies = teams.Allies
48        local Neutrals = teams.Neutrals
49        -- and then use them here
50        -- of course, you could also just use teams.Enemies or teams["Enemies"]
51    end
52end
 View all 52 lines...

Notice how much less code that last if statement takes up? This lets you change how it works in one place rather than several. Also, you can now easily change the order of roles, or add new roles.

It may be beneficial to put those roles in a ModuleScript so that other scripts can use them.

I am trying to code a role picker. Can anybody help?

2 answers

Answer this question