Scripting Helpers is winding down operations and is now read-only. More info→

How do i fix my punch script?

Asked by

ItzSulfonic 61

4 years ago

Edited 4 years ago

Theres a few problems with my script 1. The animation is spammable 2. the player does damage just by walking up to a player when the right hand touches. But i want it to only do damage when the punch animation is played

01canDoDmg = true
02dmg = 25
03 
04local Plr = game.Players.LocalPlayer
05local UserInputService = game:GetService("UserInputService")
06local Char = Plr.Character or Plr.CharacterAdded:Wait()
07local Humanoid = Char:WaitForChild("Humanoid")
08local Anim = Instance.new("Animation")
09Anim.AnimationId = "rbxassetid://6203475027"
10local track = Humanoid:LoadAnimation(Anim)
11 
12UserInputService.InputBegan:Connect(function(InputObject)
13    if InputObject.UserInputType == Enum.UserInputType.MouseButton1 then
14        track:Play()
15        script.Parent.RightHand.Touched:connect(function(hit)
16            if hit.Parent.Humanoid and canDoDmg == true then
17               hit.Parent.Humanoid:TakeDamage(dmg)
18            end
19        end)
20        wait(10)
21    end
22end)
 View all 22 lines...

2 answers

Answered by

Cynical_Innovation 595

4 years ago

Edited 4 years ago

A number of issues, and they can be easily solved

01local canDoDmg = false
02local dmg = 25
03local db = false
04 
05local Plr = game.Players.LocalPlayer
06local UserInputService = game:GetService("UserInputService")
07local Char = Plr.Character or Plr.CharacterAdded:Wait()
08local Humanoid = Char:WaitForChild("Humanoid")
09local Anim = Instance.new("Animation")
10Anim.AnimationId = "rbxassetid://6203475027"
11local track = Humanoid:LoadAnimation(Anim)
12 
13UserInputService.InputBegan:Connect(function(InputObject)
14    if InputObject.UserInputType == Enum.UserInputType.MouseButton1 and db == false then
15        track:Play()
16    canDoDmg = true
17    db = true
18        script.Parent.RightHand.Touched:connect(function(hit)
19            if hit.Parent.Humanoid and canDoDmg == true then
20               hit.Parent.Humanoid:TakeDamage(dmg)
21            end
22        end)
23    delay(1, function()
24        canDoDmg = false
25        db = false
26    end)
27        wait(10)
28    end
29end)
 View all 29 lines...

Explanation of what I changed: I added a debounce / cooldown to you code to make it so that you cannot spam it (look for the delay thing inside the script) Also made it so that you can only do damage when you punch Also added local in your variables, good coding practice

Let me know if you have any errors

Answered by

TGazza 1336

4 years ago

try this:

01canDoDmg = true
02dmg = 25
03 
04local Plr = game.Players.LocalPlayer
05local UserInputService = game:GetService("UserInputService")
06local Char = Plr.Character or Plr.CharacterAdded:Wait()
07local Humanoid = Char:WaitForChild("Humanoid")
08local Anim = Instance.new("Animation")
09Anim.AnimationId = "rbxassetid://6203475027"
10local track = Humanoid:LoadAnimation(Anim)
11local strike = false -- make a variable to stop spamming of our fire button
12 
13local TouchedEvent = nil -- make a container for our touched event so we can Disconnect() it later.
14UserInputService.InputBegan:Connect(function(InputObject)
15    if InputObject.UserInputType == Enum.UserInputType.MouseButton1 then
16        if(strike == false) then -- to stop spamming of our fire button
17            track:Play()
18            strike = true
19            if(track.IsPlaying == true) then -- check to see if our punch animation is playing if so hook up our touched event
20                TouchedEvent = script.Parent.RightHand.Touched:connect(function(hit)
21                    if hit.Parent.Humanoid and canDoDmg == true then
22                        hit.Parent.Humanoid:TakeDamage(dmg)
23                    end
24                end)
25            else
26                if(TouchedEvent ~= nil) then -- probably not needed but here just encase! :)
27                    TouchedEvent:Disconnect() -- Disconnect the touched event when the animation ends 
28                end
29            end
30            wait(10) -- might be a little long before striking again
31            strike = false
32        end
33    end
34end)
 View all 34 lines...

Hope this helps! :)

This one does damage to the player just by walking up to them without playing the animation ItzSulfonic 61 — 4y

How do i fix my punch script?

2 answers

Answer this question