Fog and Ambient doesn't reset to normal?

Asked by

4 years ago

Edited 4 years ago

I was coding something for some guy. He doesn't know how to script, so I decided to give him my services. However, with this generator model, I put the broken version in ReplicatedStorage and the fixed version in Workspace. it worked, until I put fog and ambience configs and settings in. Code here.

Fix code

01local ClickDetector = script.Parent.ClickDetector -- The Detector for when the player clicks. Recommended to stay as it is.
02 
03local printText = "Remote event fired successfully!" -- Put the print text here, when the buttons are fired they will print this text in the Developer Console
04 
05local brokenAmbient = "0,0,0" -- Put the RGB color of the ambient you've choosed when the generator is broken\
06local brokenFogEnd = 350 -- The fog when it is broken
07local brokenBrightness = 0 -- Change this brightness to your choosing when the generator is broken.
08local fixedAmbient = "255,255,255" -- Put the RGB color of the fixed ambient/your default ambient
09local fixedBrightness = 1 -- Change this brightness to your choosing when the generator is fixed/default.
10local fixedFogEnd = 750 -- The fog when it is fixed
11 
12 
13local ReplicatedStorage = game:GetService("ReplicatedStorage") -- Replicated storage
14local GeneratorFolder = game:GetService("Workspace").Generators
15 
16 
17local Fixed = GeneratorFolder:WaitForChild("Fixed") -- The fixed generator
18local Broken = ReplicatedStorage:WaitForChild("Broken") -- The broken generator
19 
20local LeverSound = script.Parent:WaitForChild("LeverPulled") -- When the lever is pressed it will play a lever pulling sound
21local SoundBroken = script.Parent:WaitForChild("PowerFailure") -- When the red button is pressed this will play
22local SoundFixed = script.Parent:WaitForChild("PowerFixed") -- When the green button is pressed this will play
23local SoundDeny = script.Parent:WaitForChild("AccessDenied") -- If the brickcolor that isn't allowed to break it presses the lever, it will play this
24 
25local MetalHolder = script.Parent.Parent["Metal thing"] -- The metalholder
26local Circle = script.Parent.Parent["Circle thing"] -- The weird thing thats red
27 
28local RemoteEvent = game.ReplicatedStorage:WaitForChild("450GKDGKC") -- The remote event to stop exploiters from exploiting the game so easily.
29 
30local TeamColorBreak = "Institutional white" -- Put the teamcolor here that is allowed to break the machine.
31 
32function onClick(plr)
33    if plr and plr.TeamColor == BrickColor.new(TeamColorBreak) then
34        RemoteEvent:FireAllClients()
35        print(printText)
36        LeverSound:Play()
37        wait(0.5)
38        SoundDeny:Play()
39    else
40        game.Lighting.FogEnd = fixedFogEnd
41        game.Lighting.Brightness = fixedBrightness
42        game.Lighting.Ambient = Color3.fromRGB(fixedAmbient)
43        RemoteEvent:FireAllClients()
44        print(printText)
45        LeverSound:Play()
46        wait(0.5)
47        SoundFixed:Play()
48        Fixed.Parent = GeneratorFolder
49        Broken.Parent = ReplicatedStorage
50        ClickDetector.MaxActivationDistance = 0
51        script.Parent.Parent.Parent.Lever.Hitbox.ClickDetector.MaxActivationDistance = 4
52    end
53end
54ClickDetector.MouseClick:Connect(onClick)
 View all 54 lines...

Broken:

01local ClickDetector = script.Parent.ClickDetector -- The Detector for when the player clicks. Recommended to stay as it is.
02 
03local printText = "Remote event fired successfully!" -- Put the print text here, when the buttons are fired they will print this text in the Developer Console
04 
05local brokenAmbient = "0,0,0" -- Put the RGB color of the ambient you've choosed when the generator is broken\
06local brokenFogEnd = 350 -- The fog when it is broken
07local brokenBrightness = 0 -- Change this brightness to your choosing when the generator is broken.
08local fixedAmbient = "255,255,255" -- Put the RGB color of the fixed ambient/your default ambient
09local fixedBrightness = 1 -- Change this brightness to your choosing when the generator is fixed/default.
10local fixedFogEnd = 750 -- The fog when it is fixed
11 
12 
13local ReplicatedStorage = game:GetService("ReplicatedStorage") -- Replicated storage
14local GeneratorFolder = game:GetService("Workspace").Generators
15 
16 
17local Fixed = GeneratorFolder:WaitForChild("Fixed") -- The fixed generator
18local Broken = ReplicatedStorage:WaitForChild("Broken") -- The broken generator
19 
20local LeverSound = script.Parent:WaitForChild("LeverPulled") -- When the lever is pressed it will play a lever pulling sound
21local SoundBroken = script.Parent:WaitForChild("PowerFailure") -- When the red button is pressed this will play
22local SoundFixed = script.Parent:WaitForChild("PowerFixed") -- When the green button is pressed this will play
23local SoundDeny = script.Parent:WaitForChild("AccessDenied") -- If the brickcolor that isn't allowed to break it presses the lever, it will play this
24 
25local MetalHolder = script.Parent.Parent["Metal thing"] -- The metalholder
26local Circle = script.Parent.Parent["Circle thing"] -- The weird thing thats red
27 
28local RemoteEvent = game.ReplicatedStorage:WaitForChild("450GKDGKC") -- The remote event to stop exploiters from exploiting the game so easily.
29 
30local TeamColorBreak = "Institutional white" -- Put the teamcolor here that is allowed to break the machine.
31 
32function onClick(plr)
33    if plr and plr.TeamColor == BrickColor.new(TeamColorBreak) or plr.Name == "Simpoxus" or "mord3chai" or "Froggy_Fellow" then
34        game.Lighting.FogEnd = brokenFogEnd
35        game.Lighting.Brightness = brokenBrightness
36        game.Lighting.Ambient = Color3.fromRGB(brokenAmbient)
37        RemoteEvent:FireAllClients()
38        print(printText)
39        LeverSound:Play()
40        wait(0.5)
41        SoundBroken:Play()
42        Fixed.Parent = ReplicatedStorage
43        Broken.Parent = GeneratorFolder
44        ClickDetector.MaxActivationDistance = 0
45        script.Parent.Parent.Parent.Lever2.Hitbox.ClickDetector.MaxActivationDistance = 4
46    else
47        RemoteEvent:FireAllClients()
48        print(printText)
49        LeverSound:Play()
50        wait(0.5)
51        SoundDeny:Play()
52    end
53end
54ClickDetector.MouseClick:Connect(onClick)
 View all 54 lines...

**It's really odd, and I don't know why the fog and ambience stays the same after I press the fix lever.

If you can help me correct my code with any mistakes, do so.

Once again, thanks!**

Update 1: I noticed this only happened in his game, not mine which is really weird.

Fog and Ambient doesn't reset to normal?

If you can help me correct my code with any mistakes, do so.

Answer this question