Problem Bindable Event firing more than 1 time?
So I am making a voting system for my game, that two scripts communicate with each other: the main game script and the voting script. In the voting script I have some code to run when a bindable event, "Voting", fires. The problem is that the bindable event is firing multiple times and the global variables bug.
Look:
001 | local AvMinigames = game.ServerStorage.Minigames.Images:GetChildren() |
002 | local display = script.Parent.Tela.SurfaceGui.Tela |
003 | local votesBEV = game.ReplicatedStorage.voting |
004 | local buttons = script.Parent:GetChildren() |
005 | local PlayerLocks = {} |
006 | local VotesWithMinigames = {} |
007 | local PlayerVotes = {} |
008 | local ButTouchedEVS = {} |
011 | local function beVisible(bool) |
013 | display.Visible = true |
014 | for i, v in pairs(buttons)do |
015 | v.SurfaceGui.Nome.Visible = true |
018 | display.Visible = false |
019 | for i, v in pairs(buttons)do |
020 | v.SurfaceGui.Nome.Visible = false |
025 | for i, v in pairs(display:GetChildren()) do |
026 | if v.ClassName == "ImageLabel" then |
027 | displays[#displays + 1] = v |
031 | for i, v in pairs(buttons) do |
032 | if v.ClassName ~= "Part" then |
033 | table.remove(buttons, i) |
037 | for i, v in pairs(buttons) do |
038 | if v.Name == "Tela" then |
039 | table.remove(buttons, i) |
043 | game.Players.PlayerRemoving:Connect(function(player) |
044 | if table.find(PlayerLocks, player) ~= nil then |
045 | local minigame = PlayerVotes[player] |
047 | VotesWithMinigames[minigame] = VotesWithMinigames[minigame] - 1 |
049 | display[minigame]:WaitForChild("Votos").Text = VotesWithMinigames[minigame] |
051 | PlayerVotes[player] = nil |
055 | votesBEV.Event:Connect(function(caso) |
056 | AvMinigames = game.ServerStorage.Minigames.Images:GetChildren() |
059 | local function checktouch(part, button) |
060 | if part.Parent:FindFirstChild("Humanoid") then |
061 | local character = part.Parent |
062 | if table.find(PlayerLocks, character.Name) == nil then |
063 | PlayerLocks[#PlayerLocks + 1] = character.Name |
065 | local minigame = button.SurfaceGui.Nome.Text |
067 | if VotesWithMinigames[minigame] == nil then |
069 | PlayerVotes[character.Name] = minigame |
071 | VotesWithMinigames[minigame] = 1 |
073 | display[minigame]:WaitForChild("Votos").Text = VotesWithMinigames[minigame] |
076 | PlayerVotes[character.Name] = minigame |
078 | VotesWithMinigames[minigame] = VotesWithMinigames[minigame] + 1 |
080 | display[minigame]:WaitForChild("Votos").Text = VotesWithMinigames[minigame] |
087 | for i, v in pairs(displays) do |
088 | local imagenum = math.random(1, #AvMinigames) |
090 | displays[i].Image = AvMinigames[imagenum].Image |
092 | v.Name = AvMinigames[imagenum].Name |
094 | script.Parent:FindFirstChild(i).SurfaceGui.Nome.Text = AvMinigames[imagenum].Name |
096 | print("Image of minigame ".. AvMinigames[imagenum].Name.. " removed from the possibilities of minigames. ".. i) |
098 | table.remove(AvMinigames, imagenum) |
102 | for i, v in pairs(buttons) do |
103 | ButTouchedEVS[#ButTouchedEVS + 1] = v.Touched:Connect(function(touchedpart) |
104 | checktouch(touchedpart, v) |
108 | elseif caso == 2 then |
114 | VotesWithMinigames["Test"] = false |
116 | for minigame, votes in pairs(VotesWithMinigames) do |
117 | if minigame ~= "Test" then |
118 | VotesWithMinigames["Test"] = true |
120 | MostVoted = {minigame, votes} |
122 | if votes == MostVoted[2] then |
123 | if not #MostVoted > 2 then |
124 | MostVoted[3] = minigame |
128 | elseif #MostVoted == 4 then |
129 | MostVoted[5] = minigame |
133 | elseif votes > MostVoted[2] then |
134 | table.clear(MostVoted) |
136 | MostVoted = {minigame, votes} |
138 | print("Minigame ".. minigame.. " with ".. votes.. " votes.") |
143 | for minigame, votes in pairs(VotesWithMinigames) do |
144 | print(tostring(votes)) |
145 | if minigame == "Test" and votes == false then |
146 | local random = math.random(1,3) |
148 | VotesWithMinigames["Test"] = nil |
150 | MostVoted[1] = buttons[random].SurfaceGui.Nome.Text |
154 | print("Voting not done. Random minigame chosen: ".. MostVoted[1]) |
158 | if #MostVoted > 2 then |
159 | if #MostVoted == 4 then |
160 | local random = math.random(1,2) |
162 | table.remove(MostVoted, 3) |
164 | table.remove(MostVoted, 4) |
167 | table.remove(MostVoted, 1) |
169 | table.remove(MostVoted, 2) |
172 | elseif #MostVoted == 6 then |
173 | local random = math.random(1,3) |
175 | table.remove(MostVoted, 3) |
177 | table.remove(MostVoted, 4) |
179 | table.remove(MostVoted, 5) |
181 | table.remove(MostVoted, 6) |
183 | elseif random == 2 then |
184 | table.remove(MostVoted, 1) |
186 | table.remove(MostVoted, 2) |
188 | table.remove(MostVoted, 5) |
190 | table.remove(MostVoted, 6) |
192 | elseif random == 3 then |
193 | table.remove(MostVoted, 1) |
195 | table.remove(MostVoted, 2) |
197 | table.remove(MostVoted, 3) |
199 | table.remove(MostVoted, 4) |
205 | print("Most voted minigame: ".. MostVoted[1].. " with ".. MostVoted[2].. " votes.") |
206 | _G.minigamec = game.Workspace.Minijogos[MostVoted[1]] |
208 | VotesWithMinigames = {} |
212 | for i, v in pairs(displays)do |
You don't need to understand the script, it's fine in itself, but the problem is what the output is indicating:
14:56:58.258 false - Server - Voto:144
14:56:58.259 Voting not done. Random minigame chosen: Sinking tiles - Server - Voto:154
14:56:58.259 1 - Server - Voto:144
14:56:58.260 Most voted minigame: Sinking tiles with 0 votes. - Server - Voto:205
14:56:58.260 true - Server - Voto:144
14:56:58.260 Most voted minigame: Furnace jumps with 1 votes. - Server - Voto:205
14:56:58.475 false - Server - Voto:144
14:56:58.476 Voting not done. Random minigame chosen: Furnace jumps - Server - Voto:154
14:56:58.476 Most voted minigame: Furnace jumps with 0 votes. - Server - Voto:205
You see? The output indicates that the piece of code is running 2 or 3 times and the minigame selection bugs.
1