Scripting Helpers is winding down operations and is now read-only. More info→

[SOLVED] How do I use GetChildren() and change children's properties?

Asked by

Dave_Robertson 42

4 years ago

Edited 4 years ago

Coin Collection script needs help. I collect coins but parts don't change transparency. Only 1 part changes transparency

Edit: WizyTheNinja's answer worked but it gave me more than 1 coin, here is the script for only 1 coin

01local db = true
02script.Parent.Touched:Connect(function(hit)
03    if hit.Parent:FindFirstChild("Humanoid") ~= nil then
04        if db == true then
05            db = false
06            local coinparts = script.Parent.Parent.Coins:GetChildren()
07 
08            for i, v in pairs(coinparts) do
09                v.Transparency = 1
10                local player = game.Players:GetPlayerFromCharacter(hit.Parent)
11                script.CollectedSound:Play()
12                v.Transparency = 1
13            end
14            local player = game.Players:GetPlayerFromCharacter(hit.Parent)
15            player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + 1
16            wait(math.random(5,15))
17            for i,v in pairs(coinparts) do
18                db = true
19                v.Transparency = 0
20            end
21        end
22    end
23end)
 View all 23 lines...

Explorer: https://prnt.sc/w7yqsn (I forgot to put it in explorer but the only thing in the script is CollectedSound, which plays)

01local db = true
02script.Parent.Touched:Connect(function(hit)
03    if hit.Parent:FindFirstChild("Humanoid") ~= nil then
04        if db == true then
05            db = false
06            local coinparts = script.Parent.Parent.Coins:GetChildren()
07 
08            for i, v in pairs(coinparts) do
09                v.Transparency = 1
10                local player = game.Players:GetPlayerFromCharacter(hit.Parent)
11                player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + 1
12                script.CollectedSound:Play()
13                v.Transparency = 1
14                wait(math.random(5,15))
15                db = true
16                v.Transparency = 0
17            end
18 
19        end
20    end
21end)
 View all 21 lines...

Are you sure the parts aren't turning invisible at all? From the looks of your code, you are waiting 5-15 seconds inbetween each part WizyTheNinja 834 — 4y

I literally said only 1 part changes transparency on the second sentence. If you read what I wrote in the first sentence, you will be able that I am trying to make a coin collection part. It has debounce and I want it to turn all the parts visible after 5 to 15 seconds. The parts should become invisible when I touch them and after 5 to 15 seconds they become visible, debounce = true. @WizyTheNinja Dave_Robertson 42 — 4y

Lua is not an asynchronous language. Your loop turns a part invisible, waits 5-15 seconds, turns the part visible again and then repeats for the next children. Correct me if I'm wrong, but I don't think this is the code behavior you intended. @Dave_Robertson SimplyConst 0 — 4y

I understand exactly what you are trying to do, but I dont think you do. You are running a loop that changes ONE parts transparency, and then waits 5-15 seconds. The problem isn't that they arent going invisible, the problem is you arent doing every one, then waiting 5-15 seconds. WizyTheNinja 834 — 4y

2 answers

Answered by

WizyTheNinja 834

4 years ago

First lets bust down your code and see whats wrong with it.

01local db = true
02script.Parent.Touched:Connect(function(hit)
03    if hit.Parent:FindFirstChild("Humanoid") ~= nil then
04        if db == true then
05            db = false
06            local coinparts = script.Parent.Parent.Coins:GetChildren()
07 
08            for i, v in pairs(coinparts) do -- Start loop
09                v.Transparency = 1 -- Change transparency
10                local player = game.Players:GetPlayerFromCharacter(hit.Parent)
11                player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + 1
12                script.CollectedSound:Play()
13                v.Transparency = 1
14                wait(math.random(5,15)) -- wait 5-15 seconds
15                db = true
16                v.Transparency = 0
17            end -- end of loop. The layout of this is your problem. Lua will not run through all of the parts and perform each line for all children then move on. It will run all the lines for one child  at a time.
18 
19        end
20    end
21end)
22 
23--This layout will do the following
24--1. Find child
25--2. Change child transparency to 1, aswell as reward cash
26--3. Wait 5-15 seconds
27--4. Turn child back visible
28--5. Find next child and repeat steps 2-5
 View all 28 lines...

Now for a working bit of code

01local db = true
02script.Parent.Touched:Connect(function(hit)
03    if hit.Parent:FindFirstChild("Humanoid") ~= nil then
04        if db == true then
05            db = false
06            local coinparts = script.Parent.Parent.Coins:GetChildren()
07 
08            for i, v in pairs(coinparts) do -- Start loop to turn parts invisible
09                v.Transparency = 1 -- Change transparency
10                local player = game.Players:GetPlayerFromCharacter(hit.Parent)
11                player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + 1
12                script.CollectedSound:Play()
13                v.Transparency = 1
14            end -- End of first loop
15            wait(math.random(5,15)) -- wait 5-15 seconds inbetween loops
16            for i,v in pairs(coinparts) do -- Start another loop to turn parts back visible
17                db = true
18                v.Transparency = 0
19            end -- End of second loop. This is how you would have to set it up if you want the turn all parts invisible, wait 5-15 seconds, then turn them back visible. 
20        end
21    end
22end)
23--This layout will do the following
24--1.Iterate through all children turning each one invisibile and rewarding cash
25--2. waits 5-15 seconds
26--3. Iterates through all the children again, this time turning each one visible
 View all 26 lines...

It changes the transparency but gives me more than 1 cash Dave_Robertson 42 — 4y

Nvm, fixed it by putting local player = game.Players:GetPlayerFromCharacter(hit.Parent), player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + 1 at the end of the loop Dave_Robertson 42 — 4y

Answered by

Dovydas1118 1495

4 years ago

You can use an in pairs loop, which loops through a table. There's 2 values in the for loop, i and v. i means index, which is just a number, and not the value we need. the v means value, which is a type of value. It can be any value (boolean, number, string, instance, etc.) Let me give you an example:

1local coinparts = script.Parent.Parent.Coins:GetChildren() --This returns a table, by the way.
2 
3for i, v in pairs(coinsparts) do --This looks complicated. I've already explained i and v, but the coinparts is the actual table itself. Put it in these brackets.
4    v.Transparency = 1 --I recommend using v:IsA("ClassName") as well, so that the script doesn't error out.
5end

I did what you wrote but It only changes the transparency of 1 coin. Pls help Dave_Robertson 42 — 4y

[SOLVED] How do I use GetChildren() and change children's properties?

2 answers

Answer this question