Scripting Helpers is winding down operations and is now read-only. More info→

Need help with auto turret i made to test out raycasting, how should i fix this?

Asked by

4 years ago

So i wanted to make something and I have also followed a tutorial however it is not working and everything i do to it wont fix it and another thing is the while wait() do loop is only playing once and i am also not getting any errors in output.

01local turret = script.Parent
02 
03local bulletdamage = 15
04local bulletspeed = 150
05local aggrodist = 75
06local firerate = .3
07local bullet = game.ReplicatedStorage:WaitForChild("Bullet")
08 
09while wait(firerate) do
10    print("Checking")
11    local target = nil
12    for i,v in pairs(game.Workspace:GetChildren()) do
13        local human = v:WaitForChild("Humanoid")
14        local root = v:WaitForChild("HumanoidRootPart")
15        if human and root and human.Health > 0 then
16            if (root.Position - turret.Position).magnitude < aggrodist then
17                target = root
18            end
19        end
20    end
21 
22if target then
23        local root = target
24        turret.CFrame = CFrame.new(turret.Position, root.Position)
25        local NewBullet = bullet:Clone()
26        NewBullet.Parent = workspace
27        NewBullet.Position = turret.Position
28 
29        NewBullet.Velocity = turret.CFrame.LookVector * bulletspeed
30 
31        NewBullet.Touched:Connect(function(hit)
32            local hum = hit.Parent:WaitForChild("Humanoid")
33            if hum then
34                hum:TakeDamage(bulletdamage)
35                NewBullet:Destroy()
36            elseif hit ~= turret then
37                NewBullet:Destroy()
38            end
39        end)
40    end
41end
 View all 41 lines...

i think its a problem with the for i,v in pairs(game.Workspace:GetChildren()) do since after that line you have one that waits for a humanoid. what if V is some random part in the workspace? the script would stop there untill you add a humanoid into that. marsdonh 36 — 4y

to test this can you put a print(v.Name) right after the for i,v in pairs(game.Workspace:GetChildren()) do line. then tell me what is prints. marsdonh 36 — 4y

It printed 'Camera' so I should probably do something like if v.Name ~= "Camera" or something like that. munkuush 22 — 4y

Ok so it didnt print camera this time but it printed Baseplate so i should find a way to use something like :IsA() or something like that munkuush 22 — 4y

2 answers

Answered by

munkuush 22

4 years ago

Just realised that instead of doing 'WaitForChild' i could do 'FindFirstChild', so it wont have to wait for it and instead it will just search for it while also allowing it to run other things in workspace to search for.

Answered by

marsdonh 36

4 years ago

so the problem with this is that the for loop will run through everything in the workspace. but the right after it

`1`	`local` `human` `=` `v:WaitForChild("Humanoid")`

is waiting for a instance called Humanoid but v could be some random part in the workspace. for this example v = Camera. but there is no instance called Humanoid under camera. so the loop would just stop here until a Humanoid instance pops up. to fix this you can make it so that if there is no humanoid under the instance then continue the loop and go to the next instance. i cant think of a better way someone else may but this is how i would do it.

01local turret = script.Parent
02 
03local bulletdamage = 15
04local bulletspeed = 150
05local aggrodist = 75
06local firerate = .3
07local bullet = game.ReplicatedStorage:WaitForChild("Bullet")
08local findhumanoid = function(part)
09    for i, v in pairs(part:GetChildren()) do
10        if v.Name == "Humanoid" then
11            return(v)
12        else
13            return(v)
14        end
15    end
16end
17local HumanoidRootPart = function(part)
18    for i, v in pairs(part:GetChildren()) do
19        if v.Name == "HumanoidRootPart" then
20            return(true)
21        else
22            return(false)
23        end
24    end
25end
26while wait(firerate) do
27    local target = nil
28for i,v in pairs(game.Workspace:GetChildren()) do
29    local found1 = findhumanoid(v)
30        if found1.Name == "Humanoid" then
31            local human = found1
32        local found2 = HumanoidRootPart(v)
33            if found2.Name == "HumanoidRootPart" then
34                root = found2
35                if human and root and human.Health > 0 then
36                    if (root.Position - turret.Position).magnitude < aggrodist then
37                        target = root
38                    end
39                end
40        end
41    end
42end
43 
44if target then
45    local root = target
46    turret.CFrame = CFrame.new(turret.Position, root.Position)
47    local NewBullet = bullet:Clone()
48    NewBullet.Parent = workspace
49    NewBullet.Position = turret.Position
50 
51    NewBullet.Velocity = turret.CFrame.LookVector * bulletspeed
52 
53    NewBullet.Touched:Connect(function(hit)
54        local hum = hit.Parent:WaitForChild("Humanoid")
55        if hum then
56            hum:TakeDamage(bulletdamage)
57            NewBullet:Destroy()
58        elseif hit ~= turret then
59            NewBullet:Destroy()
60        end
61    end)
62end
63end
 View all 63 lines...

if you have any problems comment on this response

Need help with auto turret i made to test out raycasting, how should i fix this?

2 answers

Answer this question