Scripting Helpers is winding down operations and is now read-only. More info→

code isn't working to make the gravity and lighting and map colour back to normal?

Asked by

4 years ago

Hello everyone, I am making a game where when you press a button something happens, there is a problem though, I have made my game so the has a 50 50 chance of going low gravity and when it does go low gravity it will make the map grey and make some parts/models visible, although most of the code worked some didn't, as you can see on line 36 I made it so it goes back to normal (the time of day and the parts disappear again and gravity goes back to normal after 12 seconds), all of the code making it turn into low gravity and using the if statement to make the parts visible worked but the if statment on line 36 making it back to normal didn't . The scripit is a normal script not a local or module, its parent is the button you press to do the 5050 chance. Hopefully this isn't just roblox and you scripters can help me out, thank you!

The script is below, line 36 is the if statement that was supposed to make it back to normal.

01local lighting = game.Lighting
02local button = script.Parent
03local ClickDetector = Instance.new("ClickDetector")
04ClickDetector.Parent = button
05ClickDetector.MaxActivationDistance = 15
06 
07ClickDetector.MouseClick:Connect(function()
08    print("Button has been clicked.")
09    button.Transparency = 1
10    game.Workspace.Stand.Transparency = 1
11    game.Workspace.Stand.CanCollide = false
12    button.CanCollide = false
13    wait(0.4)
14    local variable = math.random(1, 2)
15    if variable == 1 then
16        lighting.FogEnd = 12
17    else
18        game.Workspace.Gravity = 30
19    end
20    if game.Workspace.Gravity == 30 then do
21            game.Workspace.World.BrickColor = BrickColor.new("Mid gray")
22            game.Workspace.SA.Transparency = 0
23            game.Workspace.SA.CanCollide = true
24            game.Workspace.SpaceRock.Transparency = 0
25            game.Workspace.SpaceRock.CanCollide = true
26            game.Workspace.Z.Transparency = 0
27            game.Workspace.Z.CanCollide = true
28            game.Workspace.SRock.Transparency = 0
29            game.Workspace.SRock.CanCollide = true
30            game.Workspace.L.Transparency = 0
31            game.Workspace.L.CanCollide = true
32            game.Workspace.Y.Transparency = 0
33            game.Workspace.Y.CanCollide = true
34            lighting.TimeOfDay = 1
35 
36            if game.Workspace.Gravity == 30 then
37                wait(12)
38                button.Transparency = 0
39                button.CanCollide = true
40                game.Workspace.Stand.Transparency = 0
41                game.Workspace.Stand.CanCollide = true
42                game.Workspace.Gravity = 128
43                lighting.TimeOfDay = 14
44            end
45        end
46    end
47    if lighting.FogEnd == 12 then do
48            game.Workspace.FindMe.Transparency = 0
49            game.Workspace.FindMe.CanCollide = true
50            game.Workspace.FindMe.ClickDetector.MouseClick:Connect(function()
51                lighting.FogEnd = 1000
52                button.CanCollide = true
53                button.Transparency = 0
54                game.Workspace.Stand.Transparency = 0
55                game.Workspace.Stand.CanCollide = true
56                game.Workspace.FindMe.CanCollide = false
57                game.Workspace.FindMe.Transparency = 1
58            end)
59        end
60    end
61end)
 View all 61 lines...

2 answers

Answered by

BestCreativeBoy 1395

4 years ago

Edited 4 years ago

I am sure why you are using if workspace.Gravity == 30 then do, instead you should not add do there. Also, you are checking your Gravity value twice in the same code which is pretty much useless. Well, you can try doing :

01if game.Workspace.Gravity == 30 then
02            game.Workspace.World.BrickColor = BrickColor.new("Mid gray")
03            game.Workspace.SA.Transparency = 0
04            game.Workspace.SA.CanCollide = true
05            game.Workspace.SpaceRock.Transparency = 0
06            game.Workspace.SpaceRock.CanCollide = true
07            game.Workspace.Z.Transparency = 0
08            game.Workspace.Z.CanCollide = true
09            game.Workspace.SRock.Transparency = 0
10            game.Workspace.SRock.CanCollide = true
11            game.Workspace.L.Transparency = 0
12            game.Workspace.L.CanCollide = true
13            game.Workspace.Y.Transparency = 0
14            game.Workspace.Y.CanCollide = true
15            lighting.TimeOfDay = 1
16 
17            wait(12)
18 
19            button.Transparency = 0
20            button.CanCollide = true
21            game.Workspace.Stand.Transparency = 0
22            game.Workspace.Stand.CanCollide = true
23            game.Workspace.Gravity = 128
24            lighting.TimeOfDay = 14
25        end
26    end
27 
28-- Also, remove do from 'Line 47'.
29if lighting.FogEnd == 12 then
 View all 29 lines...

Now, I am going to simplify your code, so it doesn't look messy. For this, we will be creating two custom functions for Gravity and Fog.

01function Gravity()
02            game.Workspace.World.BrickColor = BrickColor.new("Mid gray")
03            game.Workspace.SA.Transparency = 0
04            game.Workspace.SA.CanCollide = true
05            game.Workspace.SpaceRock.Transparency = 0
06            game.Workspace.SpaceRock.CanCollide = true
07            game.Workspace.Z.Transparency = 0
08            game.Workspace.Z.CanCollide = true
09            game.Workspace.SRock.Transparency = 0
10            game.Workspace.SRock.CanCollide = true
11            game.Workspace.L.Transparency = 0
12            game.Workspace.L.CanCollide = true
13            game.Workspace.Y.Transparency = 0
14            game.Workspace.Y.CanCollide = true
15            lighting.TimeOfDay = 1
16 
17            wait(12)
18 
19            button.Transparency = 0
20            button.CanCollide = true
21            game.Workspace.Stand.Transparency = 0
22            game.Workspace.Stand.CanCollide = true
23            game.Workspace.Gravity = 128
24            lighting.TimeOfDay = 14
25end
26 
27local function InsideMouseClick()
28    lighting.FogEnd = 1000
29                button.CanCollide = true
30                button.Transparency = 0
31                game.Workspace.Stand.Transparency = 0
32                game.Workspace.Stand.CanCollide = true
33                game.Workspace.FindMe.CanCollide = false
34                game.Workspace.FindMe.Transparency = 1
35end
36 
37function Fog()
38    if lighting.FogEnd == 12 then
39            game.Workspace.FindMe.Transparency = 0
40            game.Workspace.FindMe.CanCollide = true
41            game.Workspace.FindMe.ClickDetector.MouseClick:Connect(InsideMouseClick)
42        end
43end
44 
45local variable = math.random(1, 2)
46    if variable == 1 then
47        Fog()
48    else
49        Gravity() -- It fires our function that we made above
50    end
 View all 50 lines...

This is how your code might look:

01--//Variables
02local lighting = game.Lighting
03local button = script.Parent
04local ClickDetector = Instance.new("ClickDetector")
05ClickDetector.Parent = button
06ClickDetector.MaxActivationDistance = 15
07 
08--// Functions
09function Gravity()
10        workspace.Gravity = 30
11            game.Workspace.World.BrickColor = BrickColor.new("Mid gray")
12            game.Workspace.SA.Transparency = 0
13            game.Workspace.SA.CanCollide = true
14            game.Workspace.SpaceRock.Transparency = 0
15            game.Workspace.SpaceRock.CanCollide = true
16            game.Workspace.Z.Transparency = 0
17            game.Workspace.Z.CanCollide = true
18            game.Workspace.SRock.Transparency = 0
19            game.Workspace.SRock.CanCollide = true
20            game.Workspace.L.Transparency = 0
21            game.Workspace.L.CanCollide = true
22            game.Workspace.Y.Transparency = 0
23            game.Workspace.Y.CanCollide = true
24            lighting.TimeOfDay = 1
25 
26            wait(12)
27 
28            button.Transparency = 0
29            button.CanCollide = true
30            game.Workspace.Stand.Transparency = 0
31            game.Workspace.Stand.CanCollide = true
32            game.Workspace.Gravity = 128
33            lighting.TimeOfDay = 14
34end
35 
36local function InsideMouseClick()
37    lighting.FogEnd = 1000
38                button.CanCollide = true
39                button.Transparency = 0
40                game.Workspace.Stand.Transparency = 0
41                game.Workspace.Stand.CanCollide = true
42                game.Workspace.FindMe.CanCollide = false
43                game.Workspace.FindMe.Transparency = 1
44end
45 
46function Fog()
47        lighting.FogEnd = 12
48            game.Workspace.FindMe.Transparency = 0
49            game.Workspace.FindMe.CanCollide = true
50            game.Workspace.FindMe.ClickDetector.MouseClick:Connect(InsideMouseClick)
51end
52 
53--//Main
54ClickDetector.MouseClick:Connect(function()
55    print("Button has been clicked.")
56    button.Transparency = 1
57    game.Workspace.Stand.Transparency = 1
58    game.Workspace.Stand.CanCollide = false
59    button.CanCollide = false
60    wait(0.4)
61    local variable = math.random(1, 2)
62    if variable == 1 then
63        Fog()
64    else
65        Gravity()
66    end
67end)
 View all 67 lines...

Lemme know if it helps!

Thank you! You neated up my code and made everything better. I have added some of my own code to it and your way of presenting it and I was able to ressolve the issue. TgaTheGoldenArmour 15 — 4y

Answered by

bruno13bruno13 78

4 years ago

So LUA can interpret the code as if Gravity is a member of Workspace and not a propriety.

Just say if the variable = 1, then you put all the fog code into it. And if the avriable is 2, you put all the Gravity code into it:

01local lighting = game.Lighting
02local button = script.Parent
03local ClickDetector = Instance.new("ClickDetector")
04ClickDetector.Parent = button
05ClickDetector.MaxActivationDistance = 15
06 
07ClickDetector.MouseClick:Connect(function()
08    print("Button has been clicked.")
09    button.Transparency = 1
10    game.Workspace.Stand.Transparency = 1
11    game.Workspace.Stand.CanCollide = false
12    button.CanCollide = false
13    wait(0.4)
14    local variable = math.random(1, 2)
15    if variable == 1 then
16        lighting.FogEnd = 12
17    game.Workspace.FindMe.Transparency = 0
18          game.Workspace.FindMe.CanCollide = true
19          game.Workspace.FindMe.ClickDetector.MouseClick:Connect(function()
20           lighting.FogEnd = 1000
21           button.CanCollide = true
22                button.Transparency = 0
23                game.Workspace.Stand.Transparency = 0
24                game.Workspace.Stand.CanCollide = true
25                game.Workspace.FindMe.CanCollide = false
26                game.Workspace.FindMe.Transparency = 1
27    else
28        game.Workspace.Gravity = 30
29           game.Workspace.World.BrickColor = BrickColor.new("Mid gray")
30            game.Workspace.SA.Transparency = 0
31            game.Workspace.SA.CanCollide = true
32            game.Workspace.SpaceRock.Transparency = 0
33            game.Workspace.SpaceRock.CanCollide = true
34            game.Workspace.Z.Transparency = 0
35            game.Workspace.Z.CanCollide = true
36            game.Workspace.SRock.Transparency = 0
37            game.Workspace.SRock.CanCollide = true
38            game.Workspace.L.Transparency = 0
39            game.Workspace.L.CanCollide = true
40            game.Workspace.Y.Transparency = 0
41            game.Workspace.Y.CanCollide = true
42            lighting.TimeOfDay = 1
43 
44 
45              wait(12)
46                button.Transparency = 0
47                button.CanCollide = true
48                game.Workspace.Stand.Transparency = 0
49              game.Workspace.Stand.CanCollide = true
50              game.Workspace.Gravity = 128
51             lighting.TimeOfDay = 1
52    end
53end)
 View all 53 lines...

It's probably a LUA glitch treating proprieties as instances, I've had this error before.

code isn't working to make the gravity and lighting and map colour back to normal?

2 answers

Answer this question