Scripting Helpers is winding down operations and is now read-only. More info→

Getting DataStore Error "DataStore Request Added To Queue, further requests will be dropped"?

Asked by

Soban06 410

4 years ago

I have these 2 files (which I will show soon after explaining), called Leader board and Skips. The Leader board files simply creates a leader board and the skips script creates skips inside the player. I am using datastores on both of these scripts (leader board and skips).

I have recently implemented BindToClose() function in my Data Store.

Leaderboard Script:

01local DataStoreService = game:GetService("DataStoreService")
02local myDataStore = DataStoreService:GetDataStore("LeaderboardSavingSystem")
03 
04 
05game.Players.PlayerAdded:Connect(function(player)
06    local leaderstats = Instance.new("Folder", player)
07    leaderstats.Name = "leaderstats"
08 
09    local Checkpoint = Instance.new("IntValue", leaderstats)
10    Checkpoint.Name = "Stage"
11    Checkpoint.Value = 0
12 
13    local coins = Instance.new("IntValue", leaderstats)
14    coins.Name = "Coins"
15    coins.Value = 0
16 
17    local rebirth = Instance.new("IntValue", leaderstats)
18    rebirth.Name = "Rebirth"
19    rebirth.Value = 0
20 
21    --Checkpoint Section
22    player.CharacterAdded:Connect(function(character)
23 
24        repeat wait() until player.character ~= nil
25        local checkpoint = game.Workspace.Checkpoints:FindFirstChild(Checkpoint.Value)
26        -- print("Checkpoint: "..tostring(checkpoint))
27        -- print("Coins: "..tostring(coins.Value))
28        character:WaitForChild("HumanoidRootPart").CFrame = CFrame.new(checkpoint.Position + Vector3.new(0, 2, 0))
29 
30    end)
31 
32    --Checkpoint Section End's here
33 
34 
35    --Data Saving
36 
37    local data
38    local success, errormessage = pcall(function()
39 
40        data = myDataStore:GetAsync(player.UserId)      
41 
42    end)
43 
44    if success and data then
45 
46        coins.Value = data.Coins
47        Checkpoint.Value = data.Checkpoint
48        rebirth.Value = data.Rebirth
49 
50    end
51 
52 
53end)
54 
55 
56 
57game.Players.PlayerRemoving:Connect(function(player)
58    local success, errormessage = pcall(function()
59 
60        local data = {
61 
62            Coins = player.leaderstats.Coins.Value;
63            Checkpoint = player.leaderstats.Stage.Value;
64            Rebirth = player.leaderstats.Rebirth.value;
65 
66        }
67 
68        myDataStore:SetAsync(player.UserId, data)
69 
70 
71 
72    end)
73 
74        if success then
75            print("Data successfully saved!")
76        else
77            print("There was an error saving the data.")
78            warn(errormessage)
79        end
80end)
81 
82game:BindToClose(function()
83    print("BindToClose Function For Leaderboard Runs Now!")
84    for _, player in pairs(game.Players:GetPlayers()) do -- notice that you can loop through every player left in the server so the function can run for them
85        local data = {
86            Coins = player.leaderstats.Coins.Value;
87            Checkpoint = player.leaderstats.Stage.Value;
88            Rebirth = player.leaderstats.Rebirth.value;
89        } -- whatever you want to save
90        myDataStore:SetAsync(player.UserId, data)
91    end
92end)
 View all 92 lines...

And below is my Skips Script:

01local DataStoreService = game:GetService("DataStoreService")
02local DataStore = DataStoreService:GetDataStore("SkipsSavingSystem")
03 
04game.Players.PlayerAdded:Connect(function(player)
05    local SkipStages = Instance.new("Folder", player)
06    SkipStages.Name = "SkipStages"
07 
08    local Skips = Instance.new("IntValue", SkipStages)
09    Skips.Name = "Skips"
10    Skips.Value = 3
11 
12 
13    local data
14    local success, errormessage = pcall(function()
15        data = DataStore:GetAsync(player.UserId)
16    end)
17 
18    if success and data then
19        Skips.Value = data.Skips
20    else
21        print("Error while fetching data!")
22        warn(errormessage)
23    end
24 
25 
26end)
27 
28 
29game.Players.PlayerRemoving:Connect(function(player)
30    local success, errormessage = pcall(function()
31        local data = {
32            Skips = player.SkipStages.Skips.Value
33        }
34 
35        DataStore:SetAsync(player.UserId, data)
36    end)
37 
38    if success then
39        print("Skips Successfully Saved!")
40    else
41        print("There was an error while saving Skips!")
42        warn(errormessage)
43    end
44 
45end)
46 
47 
48game:BindToClose(function()
49    print("BindToClose Function For Skips Runs Now!")
50    for _, player in pairs(game.Players:GetPlayers()) do -- notice that you can loop through every player left in the server so the function can run for them
51        local data = {
52            Skips = player.SkipStages.Skips.Value
53        } -- whatever you want to save
54        DataStore:SetAsync(player.UserId, data)
55    end
56end)
 View all 56 lines...

So whenever I stop the game, I get the error "DataStore request was added to queue. If request queue fills, further requests will be dropped. Try sending fewer requests.Key"

How can I remove this error so that the data is still going to get saved properly.

And can someone also explain me how to fix this issue because I may need to save more things other than these in the future. So if I can understand how to fix this than it will help a lot.

P.S: Can you check if I have implemented the BindToClose() function properly since I recently learnt it?

Thanks for any help

3 answers

Answered by

EllaTheFloofyFox 106

4 years ago

That means any datastores your sending are being disregarded because your sending too many, you could get by that by making data save as a player leaves or manually save it though. And hey upvote this if you want im almost at 100 rep :)

So am I supposed to remove the BindToClose() function? Soban06 410 — 4y

no, check out my answer krowten024nabrU 463 — 4y

Answered by

krowten024nabrU 463

4 years ago

Try wrapping them in coroutines. Do it like this:

01game:BindToClose(function()
02    for _, player in ipairs(game.Players:GetPlayers()) do -- it doesn't really matter if it's pairs or ipairs
03        local data = {
04                Coins = player.leaderstats.Coins.Value;
05                Checkpoint = player.leaderstats.Stage.Value;
06                Rebirth = player.leaderstats.Rebirth.Value;
07            }
08        local success, err = pcall(function()
09            coroutine.wrap(function()
10                DataStore:UpdateAsync(player.UserId, function(oldTable) -- i don't know why i need so many `function()` things
11                    local newTable = oldTable
12                    newTable = data
13                    return newTable
14                end)
15            end)(player)
16        end)
17    end
18end)

^^ for your first saving script, vv

01game:BindToClose(function()
02    for _, player in ipairs(game.Players:GetPlayers()) do
03        local data = {
04                Skips = player.SkipStages.Skips.Value
05            }
06        local success, err = pcall(function()
07            coroutine.wrap(function()
08                DataStore:UpdateAsync(player.UserId, function(oldTable) 
09                    local newTable = oldTable
10                    newTable = data
11                    return newTable
12                end)
13            end)(player)
14        end)
15    end
16end)

for saving skips. Hope this helps!

Answered by

BestCreativeBoy 1395

4 years ago

Edited 4 years ago

When BindToClose fires in Studio, PlayerRemoving also fires which results in data being in queue.

First thing, add this line in BindToClose :

1local RunService = game:GetService("RunService")
2 
3if RunService:IsStudio() then return end -- It will ensure that BindToClose won't fire while testing in studio

But, if you really want to test the saving in Studio:

01-- You MUST comment down the PlayerRemoving function (because when BindToClose fires, PlayerRemoving also fires[ONLY IN THE CASE OF STUDIO])
02--[[ game.Players.PlayerRemoving:Connect(function(plr)
03    coroutine.resume(coroutine.create(function()
04        DataSave(plr) -- Just an example function for saving
05    end))
06end)    ]]
07 
08game:BindToClose(function()
09    local RunService = game:GetService("RunService")
10 
11--  if RunService:IsStudio() then return end
12 
13    for _, plr in ipairs(game.Players:GetPlayers()) do -- Try using 'ipairs' as it is faster than 'pairs', but there's no 'i' in 'ipairs'. Use 'ipairs' in the case of arrays only.
14        coroutine.resume(coroutine.create(function()
15            DataSave(plr)
16        end))
17    end
18end)

Lemme know if it helps!

Getting DataStore Error "DataStore Request Added To Queue, further requests will be dropped"?

3 answers

Answer this question