How do I optimize my Region3 player detection?

Asked by

4 years ago

Edited 4 years ago

I'm trying to make a mock auto duels for practice, as the applicability of using Region3s extends far beyond that scope. The issue I'm having is that the system has troubles detecting the player's character, and, probably more consistently, detecting when the character leaves the region.

Server Script:

01local Players = game:GetService("Players")
02--------------------------------------
03local Arena = workspace.Arena
04local Room = Arena.Room
05local Spawns = Arena.Spawns
06local Pads = Arena.Pads
07local StatusBoard = Arena.StatusBoard
08--------------------------------------
09local Regions = {}
10 
11for i,v in pairs(Pads.Team1Pads:GetChildren()) do
12    local SelectedPad = v
13    Regions[i] = {Pad = v,Area = Region3.new(SelectedPad.Position,Vector3.new(SelectedPad.Position.X,SelectedPad.Position.Y + 12.9,SelectedPad.Position.Z))}
14end
15 
16for i,v in pairs(Pads.Team2Pads:GetChildren()) do
17    local SelectedPad = v
18    Regions[i + 3] = {Pad = v,Area = Region3.new(SelectedPad.Position,Vector3.new(SelectedPad.Position.X,SelectedPad.Position.Y + 12.9,SelectedPad.Position.Z))}
19end
20 
21while true do
22    wait(.1)
23    for i,v in pairs(Regions) do
24        local Parts = workspace:FindPartsInRegion3(v.Area,Pads,math.huge)
25        for _,Part in pairs(Parts) do
26            local Character = Players:GetPlayerFromCharacter(Part.Parent) 
27            if Character then
28                v.Pad.BrickColor = BrickColor.new("Really red")
29            else
30                v.Pad.BrickColor = BrickColor.new("Medium stone grey")
31            end
32        end
33    end
34end
 View all 34 lines...

As I mentioned, the above code does work. It simply doesn't work well, and I'm unsure of what else I can do to optimize it. Any help would be greatly appreciated.

Edited Code

01local Players = game:GetService("Players")
02--------------------------------------
03local Arena = workspace.Arena
04local Room = Arena.Room
05local Spawns = Arena.Spawns
06local Pads = Arena.Pads
07local StatusBoard = Arena.StatusBoard
08--------------------------------------
09local Regions = {}
10local PlayerRoots = {}
11 
12Players.PlayerAdded:Connect(function(Player)
13    Player.CharacterAdded:Connect(function(Character)
14        local Root = Character:WaitForChild("HumanoidRootPart")
15        if not PlayerRoots[Root] then
16            table.insert(PlayerRoots,Root)
17        end
18    end)
19    Player.CharacterRemoving:Connect(function(Character)
20        local Root = Character:WaitForChild("HumanoidRootPart")
21        for i,v in pairs(PlayerRoots) do
22            if v == Root then
23                table.remove(PlayerRoots,i)
24            end
25        end
26    end)
27end)
28 
29for i,v in pairs(Pads.Team1Pads:GetChildren()) do
30    local SelectedPad = v
31    Regions[i] = {Pad = v,Area = Region3.new(SelectedPad.Position,Vector3.new(SelectedPad.Position.X,SelectedPad.Position.Y + 12.9,SelectedPad.Position.Z))}
32end
33 
34for i,v in pairs(Pads.Team2Pads:GetChildren()) do
35    local SelectedPad = v
36    Regions[i + 3] = {Pad = v,Area = Region3.new(SelectedPad.Position,Vector3.new(SelectedPad.Position.X,SelectedPad.Position.Y + 12.9,SelectedPad.Position.Z))}
37end
38 
39while true do
40    wait(.1)
41    for i,v in pairs(Regions) do
42        local Parts = workspace:FindPartsInRegion3WithWhiteList(v.Area,PlayerRoots,math.huge)
43        if #Parts == 0 and v.Pad.BrickColor == BrickColor.new("Really red") then
44            v.Pad.BrickColor = BrickColor.new("Medium stone grey")
45        end
46        for _,Part in pairs(Parts) do
47            local Player = Players:GetPlayerFromCharacter(Part.Parent) 
48            if Player then
49                v.Pad.BrickColor = BrickColor.new("Really red")
50            else
51                v.Pad.BrickColor = BrickColor.new("Medium stone grey")
52            end
53        end
54    end
55end
 View all 55 lines...

Hey, I just made a topic on the devforum asking for a substitute for while loops, I'll be looking at this question in case it gets a good answer, and you can look at the topic in case someone asnwers it: https://devforum.roblox.com/t/how-would-i-detect-players-in-a-certain-region3-without-the-use-of-while-loops/831960 User#32819 0 — 4y

How do I optimize my Region3 player detection?

1 answer

Answer this question