Scripting Helpers is winding down operations and is now read-only. More info→

Super glitchy script help? Return end?

Asked by

WelpNathan 307

10 years ago

Please make your question title relevant to your question content. It should be a one-sentence summary in question form.

Hello, so I recently just finished my Meltdown Detector script what I am making for my Nuclear Powerplant for my project at school. But recently found out it glitches really bad. Please take a look at my script:

PS: It is huge.

There is no errors but it glitches out like this: https://www.youtube.com/watch?v=hoLFW7123vs

1Glitches: There is suppost to be more fire on the screen
2           More emergencylights should spin
3           The screen should not keep on switching. I think I know why this is happening but I have 
4           no experience of  return end.
5           The lights should change to orange or red when mode is switched.

001currentTemp=game.Workspace:WaitForChild("TemperatureValue")
002AlarmMinorS=game.Workspace.AlarmMinor
003AlarmMajorS=game.Workspace.AlarmMajor
004MainframeStatus=game.Workspace.MainframeStatus.SurfaceGui.TextLabel
005 
006local firethree = workspace.Mainframe_Status_Fire_Parts:GetChildren()
007local mainframelights = workspace.MainframeLights:GetChildren()
008local emergencylightson2 = workspace.EmergencyLights:GetChildren()
009local lightson2 = workspace.EnteranceLights:GetChildren()
010local lightsonfloor2 = workspace.EnteranceFloorLights:GetChildren()
011 
012local emergencylightson = workspace.EmergencyLights:GetChildren()
013local fireone = workspace.Mainframe_Status_Fire_Parts:GetChildren()
014local mainframelightstwo = workspace.MainframeLights:GetChildren()
015local lightsoff = workspace.EnteranceLights:GetChildren()
016local lightsofffloor = workspace.EnteranceFloorLights:GetChildren()
017 
018local mainframelightsthree = workspace.MainframeLights:GetChildren()
019local emergencylightsoff = workspace.EmergencyLights:GetChildren()
020local lightson = workspace.EnteranceLights:GetChildren()
021local lightsonfloor = workspace.EnteranceFloorLights:GetChildren()
022 
023function alarmMinor()
024    if currentTemp.Value >= 700 then
025        AlarmMinorS:Play()
026        AlarmMajorS:Stop()
027        wait(3)
028        MainframeStatus.Text = "LavaBlast://Core_Status/Issue"
029        MainframeStatus.TextColor3 = Color3.new(255, 85, 0)
030        wait(3)
031        for i = 1, #firethree do
032        firethree[i].Fire.Enabled = false
033        wait(0.5)
034 
035        for i = 1, #mainframelights do
036        mainframelights[i].Light.PointLight.Color = Color3.new(1, 170/255, 0)
037        mainframelights[i].Light.PointLight.Color = Color3.new(255, 170/255, 0)
038        mainframelights[i].Light.BrickColor = BrickColor.new("Orange")
039        wait(0.5)
040 
041        for i = 1, #emergencylightson2 do
042        emergencylightson2[i].Toggle.Value = false
043        wait(0.5)
044 
045        for i = 1, #lightson2 do
046        lightson2[i].Part.SpotLight.Enabled = true
047        wait(0.5)
048 
049        for i = 1, #lightsonfloor2 do
050        lightsonfloor2[i].Light.PointLight.Enabled = true
051        wait(0.5)
052        end
053    end
054        end
055        end
056        end
057    end
058end
059 
060function alarmMajor()
061    if currentTemp.Value >= 1000 then
062        AlarmMajorS:Play()
063        AlarmMinorS:Stop()
064        MainframeStatus.Text = "LavaBlast://Core_Status/Major"
065        MainframeStatus.TextColor3 = Color3.new(255, 0, 0)
066        wait(3)
067 
068        for i = 1, #emergencylightson do
069        emergencylightson[i].Toggle.Value = true
070        wait(0.5)
071 
072        for i = 1, #fireone do
073        fireone[i].Fire.Enabled = true
074        wait(0.5)
075 
076        for i = 1, #mainframelightstwo do
077        mainframelightstwo[i].Light.PointLight.Color = Color3.new(1, 0, 0)
078        mainframelightstwo[i].Light.PointLight.Color = Color3.new(1, 0, 0)
079        mainframelightstwo[i].Light.BrickColor = BrickColor.new("Red")
080        wait(0.5)
081 
082        for i = 1, #lightsoff do
083        lightsoff[i].Part.SpotLight.Enabled = false
084        wait(0.5)
085 
086        for i = 1, #lightsofffloor do
087        lightsofffloor[i].Light.PointLight.Enabled = false
088        wait(0.5)
089        end
090        end
091        end
092        end
093        end
094    end
095end
096 
097 
098function normalTemperature()
099    if currentTemp.Value < 699 then
100        AlarmMinorS:Stop()
101        AlarmMajorS:Stop()
102        wait(3)
103 
104        MainframeStatus.Text = "LavaBlast://Core_Status/Stable"
105        MainframeStatus.TextColor3 = Color3.new(255, 255, 255)
106 
107        for i = 1, #fireone do
108        fireone[i].Fire.Enabled = false
109        wait(0.5)
110 
111        for i = 1, #mainframelightsthree do
112        mainframelightsthree[i].Light.PointLight.Color = Color3.new(255, 255, 255)
113        mainframelightsthree[i].Light.PointLight.Color = Color3.new(255, 255, 255)
114        mainframelightsthree[i].Light.BrickColor = BrickColor.new("White")  
115        wait(0.5)
116 
117        for i = 1, #emergencylightsoff do
118        emergencylightsoff[i].Toggle.Value = false
119        wait(0.5)
120 
121        for i = 1, #lightson do
122        lightson[i].Part.SpotLight.Enabled = true
123        wait(0.5)
124 
125        for i = 1, #lightsonfloor do
126        lightsonfloor[i].Light.PointLight.Enabled = true
127        wait(0.5)
128        end
129        end
130        end
131        end
132        end
133    end
134end
135 
136 
137while true do
138    wait(5)
139    print "lol"
140    spawn (alarmMinor)
141    spawn (alarmMajor)
142    spawn (normalTemperature)
143end
 View all 143 lines...

1 answer

Answered by

BlackJPI 2658

10 years ago

This is a little inefficient.

Here are some of the errors I found:

For loop ends positioned improperly (loops inside loops)

AlarmMinor and AlarmMajor functions both fire when above 1000 (no upper restriction on Alarm Minor)

What I would do is use the Changed event of the NumberValue object to check the temperature every time it is changed. Then you won't have to wait 5 seconds to update.

001currentTemp=game.Workspace:WaitForChild("TemperatureValue")
002AlarmMinorS=game.Workspace.AlarmMinor
003AlarmMajorS=game.Workspace.AlarmMajor
004MainframeStatus=game.Workspace.MainframeStatus.SurfaceGui.TextLabel
005 
006local firethree = workspace.Mainframe_Status_Fire_Parts:GetChildren()
007local mainframelights = workspace.MainframeLights:GetChildren()
008local emergencylightson2 = workspace.EmergencyLights:GetChildren()
009local lightson2 = workspace.EnteranceLights:GetChildren()
010local lightsonfloor2 = workspace.EnteranceFloorLights:GetChildren()
011 
012local emergencylightson = workspace.EmergencyLights:GetChildren()
013local fireone = workspace.Mainframe_Status_Fire_Parts:GetChildren()
014local mainframelightstwo = workspace.MainframeLights:GetChildren()
015local lightsoff = workspace.EnteranceLights:GetChildren()
016local lightsofffloor = workspace.EnteranceFloorLights:GetChildren()
017 
018local mainframelightsthree = workspace.MainframeLights:GetChildren()
019local emergencylightsoff = workspace.EmergencyLights:GetChildren()
020local lightson = workspace.EnteranceLights:GetChildren()
021local lightsonfloor = workspace.EnteranceFloorLights:GetChildren()
022 
023local state = nil -- current alarm level
024 
025currentTemp.Changed:connect(function() -- Changed event
026    if currentTemp.Value >= 700 and currentTemp.Value < 1000 and state ~= 'MinorAlarm' then -- Between 700 and 1000 and not already fired
027        state = 'MinorAlarm' -- Sets alarm level to Minor
028            AlarmMinorS:Play()
029            AlarmMajorS:Stop()
030            wait(3)
031            MainframeStatus.Text = "LavaBlast://Core_Status/Issue"
032            MainframeStatus.TextColor3 = Color3.new(255, 85, 0)
033            wait(3)
034 
035            for i = 1, #firethree do
036                firethree[i].Fire.Enabled = false
037                wait(0.5)
038        end
039 
040            for i = 1, #mainframelights do
041                mainframelights[i].Light.PointLight.Color = Color3.new(1, 170/255, 0)
042                mainframelights[i].Light.PointLight.Color = Color3.new(255, 170/255, 0)
043                mainframelights[i].Light.BrickColor = BrickColor.new("Orange")
044                wait(0.5)
045        end
046 
047            for i = 1, #emergencylightson2 do
048                emergencylightson2[i].Toggle.Value = false
049                wait(0.5)
050        end
051 
052            for i = 1, #lightson2 do
053                lightson2[i].Part.SpotLight.Enabled = true
054                wait(0.5)
055        end
056 
057            for i = 1, #lightsonfloor2 do
058                lightsonfloor2[i].Light.PointLight.Enabled = true
059                wait(0.5)
060            end
061 
062    elseif currentTemp.Value >= 1000 and state ~= 'MajorAlarm' then -- Above 1000 and not already fired
063        state = 'MajorAlarm' -- Sets Alarm Level to Major
064            AlarmMajorS:Play()
065            AlarmMinorS:Stop()
066            MainframeStatus.Text = "LavaBlast://Core_Status/Major"
067            MainframeStatus.TextColor3 = Color3.new(255, 0, 0)
068            wait(3)
069 
070            for i = 1, #emergencylightson do
071                emergencylightson[i].Toggle.Value = true
072                wait(0.5)
073        end
074 
075            for i = 1, #fireone do
076                fireone[i].Fire.Enabled = true
077                wait(0.5)
078        end
079 
080            for i = 1, #mainframelightstwo do
081                mainframelightstwo[i].Light.PointLight.Color = Color3.new(1, 0, 0)
082                mainframelightstwo[i].Light.PointLight.Color = Color3.new(1, 0, 0)
083                mainframelightstwo[i].Light.BrickColor = BrickColor.new("Red")
084                wait(0.5)
085        end
086 
087            for i = 1, #lightsoff do
088                lightsoff[i].Part.SpotLight.Enabled = false
089                wait(0.5)
090        end
091 
092            for i = 1, #lightsofffloor do
093                lightsofffloor[i].Light.PointLight.Enabled = false
094                wait(0.5)
095            end
096 
097    elseif currentTemp.Value < 700 and state ~= 'NoAlarm' then -- Below 700 and not already fired
098        state = 'NoAlarm'
099            AlarmMinorS:Stop()
100            AlarmMajorS:Stop()
101            wait(3)
102 
103            MainframeStatus.Text = "LavaBlast://Core_Status/Stable"
104            MainframeStatus.TextColor3 = Color3.new(255, 255, 255)
105 
106            for i = 1, #fireone do
107                fireone[i].Fire.Enabled = false
108                wait(0.5)
109        end
110 
111            for i = 1, #mainframelightsthree do
112                mainframelightsthree[i].Light.PointLight.Color = Color3.new(255, 255, 255)
113                mainframelightsthree[i].Light.PointLight.Color = Color3.new(255, 255, 255)
114                mainframelightsthree[i].Light.BrickColor = BrickColor.new("White")  
115                wait(0.5)
116        end
117 
118            for i = 1, #emergencylightsoff do
119                emergencylightsoff[i].Toggle.Value = false
120                wait(0.5)
121        end
122 
123            for i = 1, #lightson do
124                lightson[i].Part.SpotLight.Enabled = true
125                wait(0.5)
126        end
127 
128            for i = 1, #lightsonfloor do
129                lightsonfloor[i].Light.PointLight.Enabled = true
130                wait(0.5)
131            end
132        end
133end)
 View all 133 lines...

Sorry for such the late reply. I cannot run the script because it says Workspace.Meltdown Detector:98: 'end' expected (to close 'function' at line 25) near 'elseif' Help please? :) WelpNathan 307 — 10y

There was an extra end on line 98, my bad! Should work now BlackJPI 2658 — 10y

Thank you! :) Will give credit when server released :) WelpNathan 307 — 10y

Super glitchy script help? Return end?

1 answer

Answer this question