Scripting Helpers is winding down operations and is now read-only. More info→

How do you change a value with a local script?

Asked by

MediaHQ 53

4 years ago

Edited 4 years ago

I have a game that I am working on. It has a paycheck system that uses an int value in the leaderboard script. The int value sets the amount of pay with a script. Here is the problem though, The script that sets the amount doesn't change the value. I use teams to get the value. I am new to scripting

Leaderboard (Script) (With data saving):

01local datastore = game:GetService("DataStoreService")
02local ds1 = datastore:GetDataStore("CashSaveSystem")
03 
04game.Players.PlayerAdded:connect(function(plr)
05    local folder = Instance.new("Folder", plr)
06    folder.Name = "leaderstats"
07    local cash = Instance.new("IntValue", folder)
08    cash.Name = "Money"
09 
10    cash.Value = ds1:GetAsync(plr.UserId) or 500
11    ds1:SetAsync(plr.UserId, cash.Value)
12 
13    cash.Changed:connect(function()
14        ds1:SetAsync(plr.UserId, cash.Value)
15    end)
16    while true do
17        wait(60)
18        cash.Value = cash.Value + script.PayCheck.Value
19    end
20end)

Pay Check setting script (Local)

01local player = game.Players.LocalPlayer
02local leaderstats = player:WaitForChild("leaderstats")
03local paycheck = game.Workspace.Leaderboard.PayCheck.Value
04local teams = game:GetService("Teams")
05 
06if player.Team == teams.Citizen then
07    paycheck = 120
08end
09if player.Team == teams.Criminal then
10    paycheck = 150
11end
12if player.Team == teams.Inmate then
13    paycheck = 0
14end
15if player.Team == teams.Police then
16    paycheck = 200
17end
18if player.Team == teams.HeavyGunDealer then
19    paycheck = 225
20end
21if player.Team == teams.GunDealer then
22    paycheck = 165
23end
24if player.Team == teams.AdminOnDuty then
25    paycheck = 10000
26end
 View all 26 lines...

I'd assume this is because you are using a local script, since that only changes the stats locally, not globally. Maybe try using a regular script? (Corrected) oreiboon 0 — 4y

Use remote function or event. Feelings_La 399 — 4y

3 answers

Answered by

BestCreativeBoy 1395

4 years ago

Edited 4 years ago

Well, I would recommend you to do it on Server-Side to prevent any type of exploitation. This is what you might do :

01local datastore = game:GetService("DataStoreService")
02local ds1 = datastore:GetDataStore("CashSaveSystem")
03 
04game.Players.PlayerAdded:Connect(function(plr) -- Capital 'C'
05    local folder = Instance.new("Folder", plr)
06        folder.Name = "leaderstats"
07        local cash = Instance.new("IntValue", folder)
08        cash.Name = "Money"
09 
10        cash.Value = ds1:GetAsync(plr.UserId) or 500
11        ds1:SetAsync(plr.UserId, cash.Value)
12 
13        cash.Changed:connect(function()
14            ds1:SetAsync(plr.UserId, cash.Value)
15        end)
16 
17    local function PayCheck() -- Creating a function
18        local paycheck = workspace.Leaderboard.PayCheck
19        local teams = game:GetService("Teams")
20 
21        local payCheckTable = {
22            ["Citizen"] = 120,
23                ["Criminal"] = 150,
24                ["Inmate"] = 0,
25                ["Police"] = 200,
26            ["HeavyGunDealer"] = 225,
27                ["GunDealer"] = 165,
28                ["AdminOnDuty"] = 1000     
29        } -- Thanks to Feelings_La
30 
31        -- Time for checking the player's team
32        for i, v in pairs(payCheckTable) do -- i = team of the player, v = price of paycheck
33            if plr.Team == team[i] then -- Checks if the player is in the team in the table
34                paycheck.Value = v
35            end
36        end
37    end
38 
39        while wait(60) do
40        PayCheck() -- Triggers our function
41            cash.Value = cash.Value + script.PayCheck.Value
42        end
43 
44    -- Don't add code after a while loop, as it is never ending. So, the code after the while loop never gets checked
45end)
 View all 45 lines...

Lemme know if it helps!

This one works MediaHQ 53 — 4y

Answered by

Feelings_La 399

4 years ago

Edited 4 years ago

You are changing your value locally not globally.

Use Remote Function or Events. They are great to allow you communicate between server and client! Becareful when you are using remote function/events though. Since exploiters can manipulate it.

More info about Remote Function/Events:

On your local script: I'd suggest you to make a table for paycheck instead of messy giant script.

01local player = game.Players.LocalPlayer
02local leaderstats = player:WaitForChild("leaderstats")
03local leaderboard = game.Workspace.Leaderboard
04 
05 
06local ReplicatedStorage = game:GetService("ReplicatedStorage")
07local UpdateBoard = ReplicatedStorage.UpdateBoard -- create a new remote function
08 
09local payChecks = {
10    ["Citizen"] = 120,
11    ["Criminal"] = 150,
12    ["Inmate"] = 0,
13    ["Police"] = 200,
14    ["HeavyGunDealer"] = 225,
15    ["GunDealer"] = 165,
16    ["AdminOnDuty"] = 10000
17 
18}
19 
20for team, paycheck in pairs(payChecks) do
21    if player.Team == game:GetService("Teams")[team] then
22        leaderboard.PayCheck.Value = paycheck
23    end
24end
25 
26while wait(60) do -- DO THIS on local script instead of server!
27    UpdateBoard:InvokeServer(leaderboard.PayCheck.Value)
28end
 View all 28 lines...

Then on your server script:

01-- THIS IS FOR SAFETY REASON
02local payChecks = {
03    ["Citizen"] = 120,
04    ["Criminal"] = 150,
05    ["Inmate"] = 0,
06    ["Police"] = 200,
07    ["HeavyGunDealer"] = 225,
08    ["GunDealer"] = 165,
09    ["AdminOnDuty"] = 10000
10 
11}
12local RS = game:GetService("ReplicatedStorage")
13local UpdateBoard = ReplicatedStorage.UpdateBoard
14 
15UpdateBoard.OnServerInvoke = function(plr, payCheck)
16    if payCheck == payChecks[player.Team] then
17        plr.leaderstats.Cash.Value = plr.leaderstats.Cash.Value + payCheck
18    end
19end

Still gives me 0 MediaHQ 53 — 4y

Answered by

lord_lol -5

4 years ago

you should use a remote event and do it from a server script cus if u change the value in a local script it wont register to the server and it will only save the data thats on the server so you'll need a server script to change the value

How do you change a value with a local script?

3 answers

Answer this question