How Come One Of My Conditionals Never Runs In My Chat Command Script?

Asked by

4 years ago

Edited 4 years ago

I'm making Chat Commands and recently I've added a new one. This Command is meant to speed up the targeted player by adjusting the walk speed of the humanoid. However, although the Speed All Part works, targeting a specific player (via name) never does. To Be Able To Convert the string to an actual number, I use the tonumber() method. Help Appreciated!

Edit: I updated the script to what I currently have

Full Code

01local Valid_Commands_Table = require(game:GetService("ServerStorage").ValidCommands)
02local Permitted_Players = require(game:GetService("ServerStorage").PlayerNamesPermitted)
03local ToWarnEvent = game:GetService("ReplicatedStorage").ToWarn
04local Maximum_Amount_Of_Warns = 3
05function Check(Plr)
06    for _, Permitted_Player in pairs(Permitted_Players) do
07        if Plr.Name == Permitted_Player then
08            return true
09        else
10            return false
11        end
12    end
13end
14game:GetService("Players").PlayerAdded:Connect(function(Player)
15    local Warns_Num_Value = Instance.new("NumberValue")
16    Warns_Num_Value .Parent = Player
17    Warns_Num_Value.Name = "Warns"
18    Player.Chatted:Connect(function(StringMsg)
19        local SplitString = StringMsg:split(" ")
20        if Check(Player) and SplitString[1] == Valid_Commands_Table[1] then --Kick Command
21            local NameOfPlayer = SplitString[2]
22            local ActualPlayer = game:GetService("Players"):FindFirstChild(NameOfPlayer)
23            if ActualPlayer then
24                local Reason = StringMsg:split(NameOfPlayer)[2]
25                ActualPlayer:Kick(Reason)
26            end
27        elseif Check(Player) and SplitString[1] == Valid_Commands_Table[2] then
28            local Name_Of_Player = SplitString[2]
29            local PlayerToWarn = game:GetService("Players"):FindFirstChild(Name_Of_Player)
30            local Reason = StringMsg:split(Name_Of_Player)[2]
31            local WarnsInPlayer = PlayerToWarn:WaitForChild("Warns")
32            if WarnsInPlayer then
33                WarnsInPlayer.Value += 1
34                ToWarnEvent:FireClient(PlayerToWarn)
35                if WarnsInPlayer.Value >= 3 then
36                    PlayerToWarn:Kick("Max Number Of Warns Reached, therefore you have been kicked from the server.")
37                end
38            end
39        elseif Check(Player) and SplitString[1] == Valid_Commands_Table[3] then
40            local Targets = SplitString[2]
41            if Targets == "All" then
42                for _, TargetedPlayer in pairs(game:GetService("Players"):GetChildren()) do
43                    local Char_Of_Plr = TargetedPlayer.Character
44                    local HumanoidOfTP = Char_Of_Plr.Humanoid
45                    HumanoidOfTP:TakeDamage(HumanoidOfTP.MaxHealth)
46                end
47            else
48                local NameOfTargetedPlr = SplitString[2]
49                local ActualPlayer = game:GetService("Players"):FindFirstChild(NameOfTargetedPlr)
50                if ActualPlayer then
51                    ActualPlayer.Character.Humanoid:TakeDamage(ActualPlayer.Character.Humanoid.MaxHealth)
52                end
53            end
54        elseif Check(Player) and SplitString[1] == Valid_Commands_Table[4] then
55            local Target = SplitString[2]
56            if  not Target == "All" then
57                local NameOfPlr = SplitString[2]
58                local ActualPlayer = game:GetService("Players"):FindFirstChild(NameOfPlr)
59                if ActualPlayer then
60                    ActualPlayer.Character:WaitForChild("Humanoid").WalkSpeed = tonumber(StringMsg:split(NameOfPlr)[2])
61                end
62            elseif Target == "All" then
63                for _, plr in pairs(game:GetService("Players"):GetChildren()) do
64                    plr.Character.Humanoid.WalkSpeed = tonumber(StringMsg:split(Target)[2])
65                end
66            end
67        end
68    end)
69end)
 View all 69 lines...

Part That Doesn't Run

1local Target = SplitString[2]
2        if  not Target == "All" then
3            local NameOfPlr = SplitString[2]
4            local ActualPlayer = game:GetService("Players"):FindFirstChild(NameOfPlr)
5            if ActualPlayer then
6                ActualPlayer.Character:WaitForChild("Humanoid").WalkSpeed = tonumber(StringMsg:split(NameOfPlr)[2])
7            end

You're not letting the Check function fully evaluate each expression; let it iterate through each "Permitted Player" until** it finds a match. Ziffixture 6913 — 4y

k so i dont do the return Plr.Name == plrPermitted, but instead make it check if it matches a player, and if it does then i return true? JeffTheEpicRobloxian 258 — 4y

ill try that JeffTheEpicRobloxian 258 — 4y

nvrmind it didnt work JeffTheEpicRobloxian 258 — 4y

View all comments (4 more)

Of course it didn't, you're still not letting it traverse. A return statement cancels the scope. Use "return false" outside of the enumeration, that way, the logic states that if no match was found, it'll give a false impression. Ziffixture 6913 — 4y

Alr JeffTheEpicRobloxian 258 — 4y

NEVER use PlayerName. It's unsecure and if someone changesa their username it won't work. Use Player.UserId instead nekosiwifi 398 — 4y

Alr Ill change that then JeffTheEpicRobloxian 258 — 4y

How Come One Of My Conditionals Never Runs In My Chat Command Script?

1 answer

Answer this question