Scripting Helpers is winding down operations and is now read-only. More info→

Why is my for in pairs() loop not running? (script includes pathfinding)

Asked by

Gmorcad12345 434

4 years ago

Hello. I am trying to use PathfindingService to create a path for an NPC to walk when a player touches a part. At line 45 of the code (the one that says for _, in pairs()) , the for loop doesn't run. I think that's the case since the print() statement at line 47 wasn't printed.

the script goes like so: when the player steps on "activate", the function(OnPartTouched) will run.

i've included which statements have been printed. this script is in starter character scripts and its a local script.

any idea why for in pairs() loop isn't running?

any help is appreciated!

my code is pasted below.

01local PathFindingService = game:GetService("PathfindingService")
02local ReplicatedStorage = game:GetService("ReplicatedStorage")
03 
04local T1NPC1 = game.Workspace.T1NPC["1"].T1NPC1
05local NPCHumanoid = T1NPC1.Humanoid
06local Activate = game.Workspace.T1NPC["1"].Activate
07 
08 
09local path = PathFindingService:CreatePath()
10 
11local CanMakePath = true
12 
13local function OnPartTouched(hit)
14 
15    if CanMakePath == true then
16 
17        CanMakePath = false
18 
19        print("Function fired")--printed
20        local LocalPlayer = game.Players.LocalPlayer
21        local LocalPlayerCharacter = LocalPlayer.Character
22        local IsBattled = LocalPlayer.NPCsBattled.T1["1"].IsBattled
23 
24        if IsBattled.Value == false and LocalPlayerCharacter and LocalPlayerCharacter:FindFirstChildOfClass("Humanoid")then
25 
26            local PlayerHumanoid = LocalPlayerCharacter.Humanoid
27            PlayerHumanoid.WalkSpeed = 0
28            local CreatePart = Instance.new("Part")
29            CreatePart.Position = LocalPlayerCharacter.HumanoidRootPart.Position - Vector3.new(0,2.5,0)
30            CreatePart.Name = LocalPlayer.Name.."'sAlertPart" --this part has been created
31            CreatePart.Transparency,CreatePart.Anchored,CreatePart.CanCollide = 1,true,false
32            CreatePart.Parent = workspace
33            print(LocalPlayer.Name.." has created a part due to encountering an NPC")--printed
34 
35            warn(tostring(LocalPlayer.Name.." is gonna create a part."))--warned/printed
36 
37            path:ComputeAsync(T1NPC1.HumanoidRootPart.Position,CreatePart.Position)
38 
39            print("the NPC gonna find a way to da player")--printed
40 
41            local waypoints = path:GetWaypoints()
42 
43            print("NPC got waypoints")--printed
44 
45            for _, waypoint in pairs(waypoints) do
46 
47                print("NPC will move") --this doesn't print, which means this for loop didn't fire at all
48                local WP = Instance.new("Part")
49                WP.Shape = "Ball"
50                WP.Material = "Neon"
51                WP.Size = Vector3.new(0.6, 0.6, 0.6)
52                WP.Position = waypoint.Position
53                WP.Anchored = true
54                WP.CanCollide = false
55                WP.Parent = game.Workspace
56 
57                NPCHumanoid:MoveTo(waypoint.Position)
58                NPCHumanoid.MoveToFinished:Wait()
59 
60 
61            end
62 
63        end
64 
65    end
66 
67 
68 
69end
70 
71Activate.Touched:Connect(OnPartTouched)
72--this script is inside startercharacterscripts and its a Localscript
73--there are no error messages
 View all 73 lines...

i forgot to mention that there is no error in the output Gmorcad12345 434 — 4y

do print(unpack(waypoints)) before the loop mixgingengerina10 223 — 4y

i've added it in, and it didn't print Gmorcad12345 434 — 4y

does that mean that the script/pathfindingservice couldn't get any waypoints? Gmorcad12345 434 — 4y

2 answers

Answered by

Elyzzia 1294

4 years ago

Edited 4 years ago

if PathfindingService isn't able to find a valid path between the starting and ending point, or if there's something intersecting the starting point or ending point, it won't create any waypoints

it's probably caused by the ending point being 2.5 studs below the player ((which is literally right next to the ground))

also, there's no reason to create a new part just to get its position, you can just use the HumanoidRootPart's position directly

also also, even if PathfindingService was able to create the waypoints, unless the client has network ownership over the npc for some reason or the npc was created on the client, they wouldn't be able to move it, so you'd have to move this to the server anyway

there are no obstacles stopping the NPC and i've already edited to script so that its destination is the player's humanoidrootpart. however there are still no waypoints. could u help me? thx for your time Gmorcad12345 434 — 4y

also i can't move the script to the server as I only want the local player to be able to see the npc move Gmorcad12345 434 — 4y

my NPC is also parented to a folder in a workspace, just wondering if it affects the results Gmorcad12345 434 — 4y

or is the reason of the problem becoz of the local script Gmorcad12345 434 — 4y

Answered by

Gmorcad12345 434

4 years ago

hey elyzzia, could you take a look at the comments below your answer? thx for your time and help

Why is my for in pairs() loop not running? (script includes pathfinding)

2 answers

Answer this question