Scripting Helpers is winding down operations and is now read-only. More info→

Script Running Faster Each Time Pressed?

Asked by

pilotly 15

4 years ago

Hello im having a issue with one of my scripts.

Every time it runs it runs a thouthand times. Execpt it keeps getting quicker.

-- Code in question

01runService.Heartbeat:Connect(function()
02    for index, players in pairs(players:GetChildren())do
03        local turnTime = players.Turn
04        local name = players.Name
05 
06 
07        if not turnTable[name] then
08            if turnTime.Value > maxTime then
09                turnTime.Value = maxTime
10            elseif turnTime.Value < maxTime then
11                turnTime.Value = turnTime.Value + regen
12 
13            end
14        else
15            if turnTime.Value >= cost then
16                turnTime.Value = turnTime.Value - cost
17 
18            else
19                turnTable[name] = nil
20            end
21 
22        end
23    end
24end)
 View all 24 lines...

-- full code

01local replicatedStorge = game:GetService("ReplicatedStorage")
02 
03local runService = game:GetService("RunService")
04 
05 
06local players = game:GetService("Players")
07local turnpart = game.Workspace.TurnTo
08 
09 
10local maxTime = 500
11local regen = 1
12local cost = 1
13 
14 
15local turnTable = {}
16 
17 
18 
19players.PlayerAdded:Connect(function(player)
20    local turnTime = Instance.new("IntValue",player)
21    turnTime.Value = 500
22    turnTime.Name = "Turn"
23 
24    turnTime.Changed:Connect(function(property)
25        replicatedStorge.Remotes.ResetUpdate:FireClient(player,turnTime.Value, maxTime)
26        print("firingf21")
27    end)
28end)
29 
30 
31replicatedStorge.Remotes.LowerBar.OnServerEvent:Connect(function(player,state,seat)
32    local character = player.Character
33    local humanoid = character:FindFirstChild("Humanoid")
34    local root = humanoid:FindFirstChild("HumanoidRootPart")
35    local car = seat.Parent
36    local gyro = seat.BodyGyro
37    local turn = false
38    local turnTime2 = player.Turn
39 
40    if state == "Begin" then
41        turnTable[player.Name] = true
42    elseif state == "Ended" and turnTable[player.Name] then
43        turnTable[player.Name] = nil
44 
45    end
46 
47 
48    runService.Heartbeat:Connect(function()
49        for index, players in pairs(players:GetChildren())do
50            local turnTime = players.Turn
51            local name = players.Name
52 
53 
54            if not turnTable[name] then
55                if turnTime.Value > maxTime then
56                    turnTime.Value = maxTime
57                elseif turnTime.Value < maxTime then
58                    turnTime.Value = turnTime.Value + regen
59 
60                end
61            else
62                if turnTime.Value >= cost then
63                    turnTime.Value = turnTime.Value - cost
64 
65                else
66                    turnTable[name] = nil
67                end
68 
69            end
70        end
71    end)
 View all 71 lines...

1 answer

Answered by

appxritixn 2235

4 years ago

The issue with your code is simple: You have a remote event nested inside of another remote event.

Each time replicatedStorge.Remotes.LowerBar.OnServerEvent:Connect is called, it starts a new listener for runService.Heartbeat:Connect. This inturn makes your code execute more.

Solution: (Take the event in question and un-nest it)

01local replicatedStorge = game:GetService("ReplicatedStorage")
02 
03local runService = game:GetService("RunService")
04 
05 
06local players = game:GetService("Players")
07local turnpart = game.Workspace.TurnTo
08 
09 
10local maxTime = 500
11local regen = 1
12local cost = 1
13 
14 
15local turnTable = {}
16 
17 
18 
19players.PlayerAdded:Connect(function(player)
20    local turnTime = Instance.new("IntValue",player)
21    turnTime.Value = 500
22    turnTime.Name = "Turn"
23 
24    turnTime.Changed:Connect(function(property)
25        replicatedStorge.Remotes.ResetUpdate:FireClient(player,turnTime.Value, maxTime)
26        print("firingf21")
27    end)
28end)
29 
30 
31replicatedStorge.Remotes.LowerBar.OnServerEvent:Connect(function(player,state,seat)
32    local character = player.Character
33    local humanoid = character:FindFirstChild("Humanoid")
34    local root = humanoid:FindFirstChild("HumanoidRootPart")
35    local car = seat.Parent
36    local gyro = seat.BodyGyro
37    local turn = false
38    local turnTime2 = player.Turn
39 
40    if state == "Begin" then
41        turnTable[player.Name] = true
42    elseif state == "Ended" and turnTable[player.Name] then
43        turnTable[player.Name] = nil
44 
45    end
46end)
47 
48runService.Heartbeat:Connect(function()
49    for index, players in pairs(players:GetChildren())do
50        local turnTime = players.Turn
51        local name = players.Name
52 
53 
54        if not turnTable[name] then
55            if turnTime.Value > maxTime then
56                turnTime.Value = maxTime
57            elseif turnTime.Value < maxTime then
58                turnTime.Value = turnTime.Value + regen
59 
60            end
61        else
62            if turnTime.Value >= cost then
63                turnTime.Value = turnTime.Value - cost
64 
65            else
66                turnTable[name] = nil
67            end
68 
69        end
70    end
71end)
 View all 71 lines...

Perfect Solution. Plus learn a lesson! Thanks pilotly 15 — 4y

Script Running Faster Each Time Pressed?

1 answer

Answer this question