Scripting Helpers is winding down operations and is now read-only. More info→

(SOLVED) How do I fix my bow hurting me when attacking an npc?

Asked by

VVTF_RU 18

4 years ago

Edited 4 years ago

Hello, I have created a bow and arrow recently and one of my scripts is not working right, Whenever I hit any NPC/Player the arrow will damage me and not the player I hit. I have 2 scripts a local script and a server script, the error is from the server script however. Here is the script

01local tool = script.Parent
02local handle = tool:WaitForChild('Handle')
03local event = tool:WaitForChild('RemoteEvent')
04local debounce = true
05local cooldownTime = 0.5
06local arrow = game.ReplicatedStorage.Arrow
07 
08event.OnServerEvent:Connect(function(player,pos)
09    local humanoid = tool.Parent:FindFirstChildWhichIsA('Humanoid')
10    if humanoid and humanoid.Health > 0 and debounce == true then
11        debounce = false
12        local newArrow = arrow:Clone()
13        newArrow.Parent = workspace
14        newArrow.CanCollide = false
15        newArrow.CFrame = CFrame.new(handle.Position,pos)
16        local velocity = Instance.new('BodyVelocity')
17        velocity.Parent = newArrow
18        velocity.Velocity = newArrow.CFrame.LookVector.Unit*75
19        velocity.MaxForce = Vector3.new('inf','inf','inf')
20        game.Debris:AddItem(velocity,25)
21        newArrow.Touched:Connect(function(hit)
22            local human = hit.Parent:FindFirstChildWhichIsA('Humanoid')
23            if human and humanoid.Health > 0 and human ~= humanoid then
24                humanoid:TakeDamage(55)
25                newArrow:Destroy()
26            elseif not human and hit.Cancollide == true and not hit:IsDescendantOf(humanoid.Parent) and not hit:IsDescendantof(tool) then
27                if velocity then
28                    velocity:Destroy()
29                end
30                local weld = Instance.new('WeldConstraint')
31                weld.Parent = newArrow
32                weld.Part0 = newArrow
33                weld.Part1 = hit
34                newArrow.Massless = true
35                newArrow.CanCollide = false
36            end
37        end)
38        game.Debris:AddItem(newArrow,10)
39        wait(cooldownTime)
40        debounce = true
41    end
42end)
 View all 42 lines...

and if you need to know here is the local script

1local tool = script.Parent
2local handle = tool:WaitForChild('Handle')
3local event = tool:WaitForChild('RemoteEvent')
4local player = game.Players.LocalPlayer
5local mouse = player:GetMouse()
6 
7tool.Activated:Connect(function()
8    event:FireServer(mouse.Hit.Position)
9end)

1 answer

Answered by

Loughdough 291

4 years ago

You accidentally keep using the variables Human (the hit target's humanoid) and Humanoid (the player's humanoid) interchangeably. This is an easy fix. Just go through the script and make sure you have the variables correct. For example, here's a fix to lines 23 & 24:

1local human = hit.Parent:FindFirstChildWhichIsA('Humanoid')
2            if human and human.Health > 0 and human ~= humanoid then
3                human:TakeDamage(55)

In this case, you were checking if the player's health was greater than 0 and then taking the damage from the player instead of the target. Hope this helped.

Dude, I was so confused at first cause I thought you were talking about line 9 and 10 then I realized you said HUMAN and were referring to that one LOL. Thank you alot, that helps me so much! VVTF_RU 18 — 4y

(SOLVED) How do I fix my bow hurting me when attacking an npc?

1 answer

Answer this question