Scripting Helpers is winding down operations and is now read-only. More info→

Trying To Make ToolSave Not Dupe Tools AND Making Tool Check?

Asked by

MightBeAHaxxer 24

4 years ago

The Title Is Confusing IK Buuuutt i will try to explain it

The First Script im making is a script to save tools and when you reset it duplicates the basic starter tool, so i want it to not dupe and i have tried an IF statement shown here:

01char.Humanoid.Died:connect(function()
02            char.Humanoid:UnequipTools()
03            if player.Backpack:WaitForChild("Basic Halo") == true
04            then
05                print("Already Has Basic")
06                else
07        local old = player.StarterGear:GetChildren()
08        for i = 1, #old do
09            old[i]:Destroy()
10        end
11 
12        local new = player.Backpack:GetChildren()
13        for i = 1, #new do
14            new[i].Parent = player.StarterGear
15        end    
16            end
17            end)    

Second Script: the second one is a local script to check if the player has the Molten Halo Tool when joining if the player does it will not give them the starter halo....

ToolSave Script (Normal Script, Server Script Service)

001local ds = game:GetService("DataStoreService")
002local store = ds:GetDataStore("saveStore")
003local library = game:GetService("ServerStorage").ShopItems
004 
005--< directory functions
006 
007local dir = {}
008 
009local function edit(player, list)
010    dir[player.Name] = list
011end
012 
013local function setup(player, list)
014    for i = 1, #list do
015        local tool = library:FindFirstChild(list[i])
016        if tool then
017            local clone = tool:Clone()
018            clone.Parent = player.Backpack
019        else
020            print(list[i] .. " not found")
021        end
022    end
023end
024 
025--< player events
026 
027game.Players.PlayerAdded:connect(function(player)
028 
029local ready = false
030 
031    player.CharacterAdded:connect(function(char)
032 
033    local bp = player.Backpack
034    local data = nil
035 
036    if ready == false then
037        ready = true
038 
039        data = store:GetAsync(player.UserId)
040 
041        if data then
042            setup(player, data)
043            edit(player, data)
044        end
045    end
046 
047    char.Humanoid.Died:connect(function()
048            char.Humanoid:UnequipTools()
049            if player.Backpack:WaitForChild("Basic Halo") == true
050            then
051                print("Already Has Basic")
052                else
053        local old = player.StarterGear:GetChildren()
054        for i = 1, #old do
055            old[i]:Destroy()
056        end
057 
058        local new = player.Backpack:GetChildren()
059        for i = 1, #new do
060            new[i].Parent = player.StarterGear
061        end    
062            end
063            end)    
064 
065 
066    --< adjuster
067 
068    local count = 0
069 
070    local function adjust()
071 
072    if char.Humanoid.Health > 0 then
073 
074        local list = {}
075 
076        local equipped = char:FindFirstChildOfClass("Tool")
077        if equipped then
078            table.insert(list, equipped.Name)
079        end
080 
081        local tools = bp:GetChildren()
082        for i = 1, #tools do
083            table.insert(list, tools[i].Name)
084        end
085 
086        if count ~= #list then
087            edit(player, list)
088            count = #list
089        end
090    end
091    end
092 
093    --< child events
094 
095    bp.ChildAdded:connect(adjust)   
096    bp.ChildRemoved:connect(adjust) 
097 
098    char.ChildAdded:connect(function(child)
099        if child.ClassName == "Tool" then
100            adjust()
101        end
102    end)
103 
104    char.ChildRemoved:connect(function(child)
105        if child.ClassName == "Tool" then
106            adjust()
107        end
108    end)    
109 
110    end)
111end)
112 
113game.Players.PlayerRemoving:connect(function(player)
114    store:SetAsync(player.UserId, dir[player.Name])
115    dir[player.Name] = nil
116end)
117 
118--< safety
119 
120game:BindToClose(function()
121    wait(5)
122end)
123 
124--[[ Shiro75 ]]--
 View all 124 lines...

the local script to check if the player has the tool:

01local player = game.Players.LocalPlayer
02 
03function checkBasic()
04    wait(0.6)
05    if player.Backpack:GetFirstChild("Molten Halo") == true
06        then
07        player.Backpack:GetFirstChild("Basic Halo"):Destroy()
08        end
09    end
10 
11game.Players.ChildAdded:Connect(checkBasic)

Thanks Joe.

1 answer

Answered by

nekosiwifi 398

4 years ago

Edited 4 years ago

This script was taken from a youtuber's video. You're most likely getting errors because you didn't modify the script and instead just copied and pasted it with a little name change.

Also to note, you should ALWAYS check server-side, never trust the client. Exploiters can easily spoof the client.

The first script is unecessary, that is what is most likely causing the duplication of tools. StarterGear is what tools the player will spawn with. When player respawns with a tool in their StarterGear they get their tool back, you also clone the same tool to their backpack thus making 2 copies of that tool.

01local DSS = game:GetService("DataStoreService")
02local DataStore = DSS:GetDataStore("YourDataStoreHere")
03local toolStorage = game:GetService("ServerStorage"):WaitForChild("ShopTools") --The folder might not be loaded it so we use WaitForChild just in case
04 
05local function onPlayerAdded(Player)
06    local Data
07    local suc,err = pcall(function() --Make a pcall function
08        Data = DataStore:GetAsync(Player.UserId)
09    end)
10    if suc then
11        print("Success!") --If the pcall was a success we let the server know
12    else
13        print("Error!") --If the pcall was erroring we let the server know
14    end
15    if Data then --If the player has tools saved then
16        for _,v in pairs(Data) do
17            for _,t in pairs(toolStorage:GetChildren()) do --Iterate through the folder
18                if v == t.Name --If the tool name and the player data tools match then
19                    t:Clone().Parent = Player.StarterGear
20                    if not Player.Backpack:FindFirstChild("t.Name") then
21                        t:Clone().Parent = Player.Backpack
22                    end
23                end
24            end
25        end
26    else
27        if not Player.Backpack:FindFirstChild("TheTool") then --Replace TheTool with your tool name
28            toolStorage.TheTool:Clone().Parent = Player.Backpack
29            toolStorage.TheTool:Clone().Parent = Player.StarterGear
30        end
31    end
32end
33 
34local function onPlayerRemoved(Player)
35    local DataToSave = {}
36    for _,v in pairs(Player.StarterGear:GetChildren()) do
37        table.insert(DataToSave, v.name)
38    end
39    local suc,err = pcall(function()
40        DataStore:SetAsync(Player.UserId, DataToSave)
41    end)
42end)
43 
44game:GetService("Players").PlayerAdded:Connect(onPlayerAdded)
45game:GetService("Players").PlayerRemoving:Connect(onPlayerRemoved)
46 
47game:BindToClose(function()
48    for _,Player in pairs(game:GetService("Players"):GetPlayers()) do
49        onPlayerRemoved(Player)
50    end
51end)
 View all 51 lines...

The script you provided had a lot of deprecated functions which I had to replace. I'm sorry if this didn't work. I rushly typed this so comment on this answer if you're receiving errors and I'll happily help you.

Trying To Make ToolSave Not Dupe Tools AND Making Tool Check?

1 answer

Answer this question