Scripting Helpers is winding down operations and is now read-only. More info→

Roblox Scripting | display gui when inround true doesnt work! Help?

Asked by

4 years ago

So, im making an murder mystery game, and the thing that appears on start of the round is the "show my role" gui or "show me if im murderer or innocent or sheriff" gui, and i first tried to do it in the script in the serverscriptservice because thats where my main stuff about rounds and intermission timing and stuff is located, but that didnt work, the next thing i tried was to do it with the boolvalue (i had 2 of them in my script, one for saying when the round starts and ends, and one that says to display the "show my role" gui), and that didnt work either, so a few minutes before, i tried to do it with the inround value(which in fact did work) but then the text stopped to change, and after that it just breaks, and shows the gui when the player is in lobby, and hides it when the player is in round.

My code is (Main Script):

01local roundLength = 5
02local intermissionLength = 5
03local status = game.ReplicatedStorage.IntermissionStatus
04local inround = game.ReplicatedStorage.InRound
05local chosenRandomNumberValue = game.ReplicatedStorage.chosenNumber
06local displaychosenrole = game.StarterGui.areyoumurdorsherifforinno.Chosen.TextLabel
07local tof = game.ReplicatedStorage.displayChosenTOF
08local player = game.Players.LocalPlayer
09local chosenRoleValue = game.ReplicatedStorage.TheChosenRole
10 
11local murdererteam = game.Teams.Murderer
12local sheriffteam = game.Teams.Sheriff
13local innocentteam = game.Teams.Innocent
14 
15local mineshaft = game.Workspace.MineshaftSpawn
16local milbase = game.Workspace.MilbaseSpawn
17local lobby = game.Workspace.LobbySpawn
18 
19local colorRed = Color3.new(255/255, 0/255, 4/255)
20local colorBlue = Color3.new(16/255, 40/255, 255/255)
21local colorGreen = Color3.new(3/255, 255/255, 19/255)
22 
23inround.Changed:Connect(function()
24    if inround.Value == true then  
25 
26        for _, player in pairs(game.Players:GetChildren()) do
27 
28            local char = player.Character
29            local randomMapNumber = math.random(1,2)
30            if randomMapNumber == 1 then
31 
32                char.HumanoidRootPart.CFrame = mineshaft.CFrame
33            elseif randomMapNumber == 2 then
34 
35                char.HumanoidRootPart.CFrame = milbase.CFrame
36            end
37 
38            local randomNumber = math.random(1,3)
39            if randomNumber == 1 then
40 
41                player.TeamColor = BrickColor.new("Really red")
42                chosenRoleValue.Value = "MURDERER"
43            elseif randomNumber == 2 then
44 
45                player.TeamColor = BrickColor.new("Electric blue")
46                chosenRoleValue.Value = "SHERIFF"
47            elseif randomNumber == 3 then
48 
49                player.TeamColor = BrickColor.new("Lime green")
50                chosenRoleValue.Value = "INNOCENT"
51            end
52 
53        end
54    else
55        for _,player in pairs(game.Players:GetChildren()) do
56            local char = player.Character
57            char.HumanoidRootPart.CFrame = lobby.CFrame     
58            player.TeamColor = BrickColor.new("White")
59            chosenRoleValue.Value = "NEUTRAL"
60        end
61    end
62 
63end)
64 
65 
66 
67local function roundTimer()
68 
69    while wait() do
70        for i = intermissionLength, 1, -1 do
71            inround.Value = false
72            wait(1)
73            status.Value = "Intermission: ".. i .." seconds left!"
74            wait(1)
75 
76        end
77    for i = roundLength, 1, -1 do
78            inround.Value = true
79            wait(1)
80 
81            status.Value = "Game: ".. i .." seconds left!"
82 
83        end
84 
85    end
86 
87end
88 
89spawn(roundTimer)
 View all 89 lines...

My code for the gui script:

01local chosenNumber = game.ReplicatedStorage.chosenNumber
02local status = script.Parent.TextLabel
03local tof = game.ReplicatedStorage.displayChosenTOF
04local chosenRole = game.ReplicatedStorage.TheChosenRole
05local inround = game.ReplicatedStorage.InRound
06 
07 
08 
09chosenRole.Changed:Connect(function()
10 
11    if chosenRole.Value == "MURDERER" then
12        status.TextColor3 = Color3.new(255/255, 0/255, 4/255)
13        status.Text = "MURDERER"
14        if inround.Value == true then
15            script.Parent.Parent.Chosen.Visible = true
16            wait(5)
17            script.Parent.Parent.Chosen.Visible = false
18        end
19    elseif chosenRole.Value == "SHERIFF" then
20        status.TextColor3 = Color3.new(16/255, 40/255, 255/255)
21        status.Text = "SHERIFF"
22        if inround.Value == true then
23            script.Parent.Parent.Chosen.Visible = true
24            wait(5)
25            script.Parent.Parent.Chosen.Visible = false
26        end
27    elseif chosenRole.Value == "INNOCENT" then
28        status.TextColor3 = Color3.new(3/255, 255/255, 19/255)
29        status.Text = "INNOCENT"
30        if inround.Value == true then
31            script.Parent.Parent.Chosen.Visible = true
32            wait(5)
33            script.Parent.Parent.Chosen.Visible = false
34        end
35    elseif chosenRole.Value == "NEUTRAL" then
36        status.TextColor3 = Color3.new(255/255, 255/255, 255/255)
37        status.Text = "NEUTRAL"
38        if inround.Value == true then
39            script.Parent.Parent.Chosen.Visible = true
40            wait(5)
41            script.Parent.Parent.Chosen.Visible = false
42        end
43    end
44end)
 View all 44 lines...

also the main script is an "script" and the second is an "local script"

1 answer

Answered by

Nckripted 580

4 years ago

I noticed a couple problems with your script here:

You are using a server sided value called chosenRole, but the problem is in the local script, you are looking for every time it is changed. What I mean is, everyone will be the murderer when they start the game. Instead, use a remote event, and fire it with the team that they will be on instead of changing a value.
You are being heavily dependent on ReplicatedStorage, but the thing is, exploiters can easily change these values to their liking. Use remote events and functions instead of changing a value directly.
Instead of complicating stuff and using Color3.new, use Color3.fromRGB, this will allow you to change color much more easily.
There is a for loop that is not properly indented on line 77.

I’m sorry if I sound like a know it all, but the thing is, your script needs a major rewrite. It needs to be a bit more cleaner and safer from exploiters.

I’ll post another answer with some scripts you could use if you’d like.

Also, please note I made an error while typing. I meant that everybody would be Neutral, because the change is broadcasted everywhere. Nckripted 580 — 4y

that didnt help me, but it gave me an idea on how to make my game safer from exploiters VikkiVuk 74 — 4y

Glad to hear that! I’ll continue to look at the script and see if I can find any fixes for the issues you just listed. Nckripted 580 — 4y

also i have an question, how do you get the "if event is fired" value VikkiVuk 74 — 4y

View all comments (6 more)

Use OnServerEvent on a server script and OnClientEvent on a local script. For more information on remote events, go here: https://developer.roblox.com/en-us/articles/Remote-Functions-and-Events Nckripted 580 — 4y

umm its been awhile... VikkiVuk 74 — 4y

He literally said what you need to do lmao. Dovydas1118 1495 — 4y

Yes, and didnt work VikkiVuk 74 — 4y

I listed a resource on Remote Events and Functions. Did you read that? Nckripted 580 — 4y

Roblox Scripting | display gui when inround true doesnt work! Help?

1 answer

Answer this question