Scripting Helpers is winding down operations and is now read-only. More info→

My disco floor script isn't working and I don't know why, can someone fix it?

Asked by

4 years ago

So basically I have a model with a disco floor in it, all the parts inside of it except for one is called "DiscoFloor" the other is called "DiscoScreen", it only is lighting up "DiscoScreen" and I thought it would light up all of them, can someone fix this? Here is my code

01local floors = script.Parent:GetChildren()
02 
03 
04for _,p in pairs(floors) do
05    while true do
06        if p:IsA("Part") then
07            p.Color = Color3.new(math.random(), math.random(), math.random())
08            wait(.5)
09    end
10    end
11    end

Not a request site my man EiOooAxea 70 — 4y

3 answers

Answered by

JB_SuperGamer 165

4 years ago

I have a simple but effective way to fix it. 1st, name all the Discop Floor parts with a number at the end. (Part1, Part2, etc.) Place this Folder into game.Workspace and name it 'GameScriptService'. Insert a script into it and name the script 'DiscoFloor'. Type the following:

01local num = 1
02local color1 = Color3.fromRGB(0, 255, 0)
03local color2 = Color3.fromRGB(0, 0, 255)
04while true do
05    local parts = game.Workspace.DiscoFloor:GetChildren() --change if you need to
06    for i = 1,#parts do
07        if num == 1 then
08            if parts[i].Name == "Part1" or parts[i].Name == "Part3" then --Add more if necessary. This may not be the simplest way to do it, but it's the only way I know right now.
09                parts[i].Color = color1
10            else
11                parts[i].Color = color2
12            end
13            num = 2
14        else
15            if parts[i].Name == "Part1" or parts[i].Name == "Part3" then --Add more if necessary.
16                parts[i].Color = color2
17            else
18                parts[i].Color = color1
19            end
20            num = 1
21        end
22    end
23end
 View all 23 lines...

If this doesn't work, let me know and I'll try something else.

Doesn't work sadly, I'm getting an error that says: "Script timeout: exhausted allowed execution time" on line 20, any fixes? Stea_my 48 — 4y

There isn't any waits in the while loop. you could put a wait() at the end or you could change "while true do" to "while wait() do" NordicM 77 — 4y

Ah yes. My bad. Change it to while true do to while wait(1) do - Then it should work. Sorry. JB_SuperGamer 165 — 4y

Change 'while true do' to 'while wait(1) do' JB_SuperGamer 165 — 4y

Thank you! After I changed "while true do" to "while wait(1) do" it worked, I'm very glad that now my game doesn't have to lag due to lots of scripts! Stea_my 48 — 4y

Answered by

MagicPineappleLOLKA -6

4 years ago

just rename all "disco floor" into "disco screen"

Answered by

Shounak123 461

4 years ago

Edited 4 years ago

I know what caused your problem. You gave while true do so it will forever go on looping the same brick. The script I gave below will change the color of every part and set it to random color every second.

Just rewrite the whole script as:

1while true do
2    for _,p in pairs(script.Parent:GetChildren()) do
3        if p:IsA("Part") then
4            p.Color = BrickColor.random()
5        end
6    end
7    wait(1)
8end

I hope that helps :D

My script is very simple. Write it in the script and it will work. Shounak123 461 — 4y

My disco floor script isn't working and I don't know why, can someone fix it?

3 answers

Answer this question