After unequipping tool, script.Parent.Activated:Connect executes twice?

Asked by

rookiecookie153 53

4 years ago

WARNING: VERY CRAPPY CODE!

Whenever I unequip my gun (not dropping) and re-equip, it works normally except for

script.Parent.Activated:Connect(function() @ (Line 81)

The line executes multiple times for a reason I cant explain. Here is my local script:

001-- Preference Locals
002local MaxAmmo = 1
003local ShootDelay = 0.2
004local MaxCamShake = 1
005local ReloadTime = 7.5
006-- Main Locals
007local Unequipped = false
008local Ammo = MaxAmmo
009local Reloading = false
010local MuzzleOn = false
011local player = game.Players.LocalPlayer
012local char = player.Character or player.CharacterAdded:wait()
013local humanoid = char:WaitForChild("Humanoid")
014local Mouse = game.Players.LocalPlayer:GetMouse()
015local camera = workspace.CurrentCamera
016local counter = 0
017 
018 
019--Animation Locals
020local AnimationStatus = "Off"
021local animationOn = script.Parent:WaitForChild('On')
022local On = humanoid:LoadAnimation(animationOn)
023 
024--Main Stuff lol
025--I suck at coding but ill optimize this crap latrrrr
026--here i am procrastinating by adding useless green text thats probably gonna be removesd later
027local function nowits6rlly()
028    if AnimationStatus == "On" then
029        On:Play()
030        On.Looped = true
031    elseif AnimationStatus == "Off" then
032        On:Stop()
033        On.Looped = false
034    end
035end
036 
037local function CreateMotor6D()
038    local PlayerGunConnect = Instance.new("Motor6D")
039    PlayerGunConnect.Part0 = player.Character:WaitForChild("Right Arm")
040    PlayerGunConnect.Part1 = script.Parent.MainAssembly
041    PlayerGunConnect.C0 = CFrame.new(0,-3.5,-0.63)
042    PlayerGunConnect.C1 = CFrame.Angles(math.rad(90), 0, math.rad(180))
043    PlayerGunConnect.Parent = script.Parent.Motor6D
044end
045 
046local function DestroyMotor6D()
047    local test = script.Parent.Motor6D:FindFirstChild("Motor6D")
048    if test then
049        script.Parent.Motor6D.Motor6D:Destroy()
050    end
051end
052 
053local function CamShake()
054    for i = 1,10 do
055        wait(0.025)
056        char.Humanoid.CameraOffset = Vector3.new(math.random(-MaxCamShake,MaxCamShake), math.random(-MaxCamShake,MaxCamShake), math.random(-MaxCamShake,MaxCamShake))
057    end
058    char.Humanoid.CameraOffset = Vector3.new(0,0,0)
059end
060 
061script.Parent.Equipped:Connect(function()
062    CreateMotor6D()
063    AnimationStatus = "On"
064    nowits6rlly()
065    MuzzleOn = false
066    script.Parent.MuzzleFlash:FireServer(MuzzleOn)
067    Mouse.Icon = "rbxasset://textures/GunCursor.png"
068    local function Reload()
069        Reloading = true
070        Mouse.Icon = "rbxasset://textures/GunWaitCursor.png"
071        script.Parent.RELOAD:FireServer()
072        local animationReload = script.Parent:WaitForChild('Reload')
073        local Reload = humanoid:LoadAnimation(animationReload)
074        Reload.Looped = false
075        Reload:Play()
076        wait(ReloadTime)
077        Ammo = MaxAmmo
078        Reloading = false
079        Mouse.Icon = "rbxasset://textures/GunCursor.png"
080    end
081    script.Parent.Activated:Connect(function()
082        if Ammo>0 and not Reloading and counter==0 or counter==1 then
083            Ammo=Ammo-1
084            script.Parent.RayCastEvent:FireServer(script.Parent.BulHol.CFrame.Position, Mouse.Hit.Position)
085            local animationShoot = script.Parent:WaitForChild('Shoot')
086            local Shoot = humanoid:LoadAnimation(animationShoot)
087            Shoot:Play()
088            MuzzleOn = true
089            script.Parent.MuzzleFlash:FireServer(MuzzleOn)
090            CamShake()
091            MuzzleOn = false
092            script.Parent.MuzzleFlash:FireServer(MuzzleOn)
093            if Unequipped == true then
094                counter = 1
095            end
096        elseif not Reloading and Ammo==0 and counter==0 then
097            print("reload")
098            Reload()
099        elseif counter==1 then
100            counter=0 --My attempt at fixing the bug
101        end
102    end)
103    print(counter .. "yes")--Some print()'s are my way of finding the bug.
104    print(Ammo)
105end)
106 
107script.Parent.Unequipped:Connect(function()
108    print("unequipped, ammo is at  " .. Ammo .. "  bullet(s)")--Like this one
109    DestroyMotor6D()
110    Mouse.Icon = "rbxasset://SystemCursors/Arrow"
111    AnimationStatus = "Off"
112    nowits6rlly()
113    Unequipped = true
114end)
 View all 114 lines...

Please accept the answer that works User#30567 0 — 4y

sorry needed to check if it works rookiecookie153 53 — 4y

After unequipping tool, script.Parent.Activated:Connect executes twice?

1 answer

Answer this question