Scripting Helpers is winding down operations and is now read-only. More info→
Log in to vote
1
Can you fix this script?
Please make your question title relevant to your question content. It should be a one-sentence summary in question form.
So I made a Bool value, and I want it to go false when a player dies, but it's not going well with me. Can you help? I'd appreciate it if you can!
1 | h = script.Parent:FindFirstChild("Humanoid") |
2 | player = h:GetPlayerFromCharacter(script.Parent.Parent) |
3 | x = player:FindFirstChild("Ingame") |
4 |
5 | if h.Health == 0 then |
6 | x.Value = false |
7 | end |
1 answer
Log in to vote
2
Humanoid.Health is a floating-point value, (aka a Number), so it will most likely never be exactly 0. Also, there exists a Died event for Humanoids, so you don't have to check the health at all. GetPlayerFromCharacter is a method of Players, not a Humanoid.
Really, this could be better done using the PlayerAdded and CharacterAdded Events, so I'll give you a fixed version of your code, and a version using those two:
01 | h = script.Parent:FindFirstChild("Humanoid") |
02 | if h then |
03 | player = Game.Players:GetPlayerFromCharacter(script.Parent.Parent) |
04 | if player then |
05 | x = player:WaitForChild("Ingame") --Safer than FindFirstChild, will yield the thread until Ingame exists. |
06 |
07 | h.Died:connect(function() |
08 | x.Value = false |
09 | end) |
10 | end |
11 | end |
1 | Game.Players.PlayerAdded:connect(function(player) |
2 | local x = player:WaitForChild("Ingame") |
3 | player.CharacterAdded:connect(function(character) |
4 | wait() --Wait for the character to fully load. |
5 | character.Humanoid.Died:connect(function() |
6 | x.Value = false |
7 | end) |
8 | end) |
9 | end) |
2
The statement about "never exactly zero" is not really accurate. Humanoids cannot have negative health, so TakeDamage or even subtracting from Health directly will very likely result in exactly 0, as well as environment deaths like falling or being broken apart. BlueTaslem 18071 — 10y
0
Thanks for the advice! chill22518 145 — 10y