why wont the server find the player?
hi hello i am making a game
this is the part where i tell you to forcefully fix my code so here it is:
CLIENT:
01 | --#FUNCTIONS |
02 | function checkProfile(playerName) |
03 |
04 | local xpLVL, description, roundsCompleted = game.ReplicatedStorage.Remotes.Profile.CheckPlayerStats:FireServer(playerName) |
05 |
06 | script.Parent.profileFrame.XPlevel.Text = "experience level: "..xpLVL |
07 | script.Parent.profileFrame.description.Text = description |
08 | script.Parent.profileFrame.roundsCompleted.Text = "rounds completed: "..roundsCompleted |
09 |
10 | end |
11 |
12 | script.Parent.titlescreen.profile.MouseButton1Click:Connect(function() |
13 |
14 | checkProfile(game.Players.LocalPlayer.Name) |
15 |
16 | end) |
SERVER:
01 | game.ReplicatedStorage.Remotes.Profile.CheckPlayerStats.OnServerEvent:Connect(function(playerName) |
02 |
03 | local player = game.Players:GetPlayerFromCharacter(playerName) |
04 |
05 | if player then |
06 |
07 | if player:FindFirstChild("xpLVL") and player:FindFirstChild("desc") and player:FindFirstChild("keyboard") and player:FindFirstChild("roundsCompleted") then |
08 |
09 | return player.xpLVL.Value, player.desc.Value, player.roundsCompleted.Value |
10 |
11 | else |
12 |
13 | print(">:(") |
14 |
15 | end |
the problem is that it keeps returning the player stats as nil. for some reason the server wont find the player. i've tried this multiple times before in my other games, and it worked. can y'all please tell me why the error keeps happening? thanks :)
server error: ServerScriptService.Remotes:18: invalid argument #2(string expected, got Instance) client error: Players.L_0ID.PlayerGui.mainGui.main.Core:37: attempt to concatenate string with nil
0
1 answer
EDIT: It seems like you're using RemoteEvent to fetch the player profile. Consider using RemoteFunction instead! Sorry for slipping through that!
TL;DR: Use RemoteFunction instead, and the parameters in the Server script is incorrect. Instead of just (playerName), it should be (plr, playerName), since the first parameter of OnServerEvent/OnServerInvoke is always the player client that sent this request to the server.
okay first:
The first parameter of OnServerEvent and OnServerInvoke (from RemoteFunction class) is by default, the Player object that tells you the client that the RemoteFunction is fired from. Check this
This brings us to:
01 | --SERVER SCRIPT (To illustrate what you should do) |
02 | --We should use RemoteFunction here if you want the results to be passed to the client. |
03 | --Bind the function to the RemoteFunction |
04 | game.ReplicatedStorage.Remotes.Profile.CheckPlayerStats.OnServerInvoke = function(plr, playerName) |
05 | --plr will return the player client that fired this event, while playerName will be passed as the first parameter that the client has fired from. |
06 | --Rest of your script |
07 |
08 | --Return your results after some scavenging |
09 | if found then |
10 | return result, blabla, anything |
11 | end |
12 |
13 | --Don't forget to put a return here in case if the condition above is not true |
14 | return nil |
15 | end) |
Since we're using RemoteFunction for this task, from the Client script, instead of calling :FireServer()method, use :InvokeServer() instead. They're the same for communication through Server and Client, but there is a difference. Here's a comprehensive documentation of those two, which explains how these function in case you're interested!
Second: From the Server script I read, you don't have to use GetPlayerFromCharacter, especially in this case where you're passing just the player's name only, not the player's Character (which is a Model, not a string, not written in text)
game.Players contains all the Players instances you need, which also includes you and the person you want to check. We'll apply this fix:
1 | --Replace this |
2 | local player = game.Players:GetPlayerFromCharacter(playerName) |
3 | --To this: |
4 | local player = game.Players:FindFirstChild(playerName) |
I'm on mobile right now, so these are untested... If anything, please let me know about any faults I made or if this problem persists. cheers c:
0