Scripting Helpers is winding down operations and is now read-only. More info→

My while true do loop will not run at all, why is this so?

Asked by

jorcorrs 76

4 years ago

Edited 4 years ago

So I am trying to make an elevator game. But the main code will not run, why is this so? There's no errors

My code is

01local plrs = {}
02game.Workspace:WaitForChild("TpCframe1").Touched:Connect(function(hit)
03if hit.Parent:FindFirstChild("Humanoid") and db == false then
04    db = true
05    hit.Parent.HumanoidRootPart.CFrame = game.Workspace.TpCframe2.CFrame
06    local player = game.Players:GetPlayerFromCharacter(hit)
07    if not table.find(plrs,player) then -- detecting if player is not in the table
08        table.insert(plrs,player) -- adding player in table
09            print("Added player to table.")
10            wait(1)
11            db = false
12        end
13    end
14end)
15while true do
16    wait(0.01)
17    if #plrs >= 1 then
18        wait(1)
19        for i = 10,0,-1 do
20            wait(1)
21            game.ReplicatedStorage.Timer.Value = i
22            if i == 0 then
23                local event = game.ServerStorage.Floors:GetChildren()
24                local chosenEvent = event[math.random(1,#event)]
25                local clonedEvent = chosenEvent:Clone()
26                clonedEvent.Parent = workspace
27                wait(2)
28                open()
29                wait(0.5)
30                if chosenEvent.Name == "No Chill" then
31                    clonedEvent.Board.chill.Face = Enum.NormalId.Front
32                    wait(1)
33                    clonedEvent.Board.chill.Face = Enum.NormalId.Top
34                    clonedEvent.Board.wrong.Face = Enum.NormalId.Front
35                    game.Workspace["WRONG!"]:Play()
36                    wait(1)
37                    clonedEvent.Board.checkit.Face = Enum.NormalId.Front
38                    clonedEvent.Board.wrong.Face = Enum.NormalId.Top
39                    wait(1)
40                    clonedEvent.Board.checkit.Face = Enum.NormalId.Top
41                    clonedEvent.Board.correct.Face = Enum.NormalId.Front
42                    game.Workspace.correct:Play()
43                    wait(1)
44                end
45                for i,v in pairs(game.Players:GetPlayers()) do
46                    if v then
47                        v.Character:WaitForChild("Humanoid").Died:Connect(function()
48                            table.remove(plrs,v)
49                        end)
50                    end
51                end
52                game.Players.PlayerRemoving:Connect(function(plr)
53                    table.remove(plrs,plr)
54                end)
55                wait(15)
56                clonedEvent:Destroy()
57                break
58            end
59        end
60    end
61    wait()
62end
 View all 62 lines...

2 answers

Answered by

UraniumBanana5 33

4 years ago

Try adding a wait like this:

01while true do
02    if #plrs >= 1 then
03        wait(1)
04        for i = 10,0,-1 do
05            wait(1)
06            game.ReplicatedStorage.Timer.Value = i
07            if i == 0 then
08                local event = game.ServerStorage.Floors:GetChildren()
09                local chosenEvent = event[math.random(1,#event)]
10                local clonedEvent = chosenEvent:Clone()
11                clonedEvent.Parent = workspace
12                wait(2)
13                open()
14                wait(0.5)
15                if chosenEvent.Name == "No Chill" then
16                    clonedEvent.Board.chill.Face = Enum.NormalId.Front
17                    wait(1)
18                    clonedEvent.Board.chill.Face = Enum.NormalId.Top
19                    clonedEvent.Board.wrong.Face = Enum.NormalId.Front
20                    game.Workspace["WRONG!"]:Play()
21                    wait(1)
22                    clonedEvent.Board.checkit.Face = Enum.NormalId.Front
23                    clonedEvent.Board.wrong.Face = Enum.NormalId.Top
24                    wait(1)
25                    clonedEvent.Board.checkit.Face = Enum.NormalId.Top
26                    clonedEvent.Board.correct.Face = Enum.NormalId.Front
27                    game.Workspace.correct:Play()
28                    wait(1)
29                end
30                wait(15)
31                clonedEvent:Destroy()
32            end
33        end
34    end
35    wait()
36end
 View all 36 lines...

If this doesn't work, just let me know.

this would work, upvoted raid6n 2196 — 4y

Answered by

TheLuminent 1204

4 years ago

I don't necessarily see any issues but here's my rewrite because I'm not going to just read this and leave you hanging.

01local Workspace = (workspace ~= nil and workspace) or game:GetService("Workspace")
02local Players = game:GetService("Players")
03local ReplicatedStorage = game:GetService("ReplicatedStorage")
04local RunService = game:GetService("RunService")
05local ServerStorage = game:GetService("ServerStorage")
06local CoordinateFrameMarker = Workspace:FindFirstChild("TpCframe1")
07local PlayerList = {}
08 
09local function swait(num)
10    for i = 1,(num ~= nil and num) or 1,1 do
11        return RunService.Stepped:Wait()
12    end
13end
14 
15repeat
16    swait()
17until CoordinateFrameMarker ~= nil
18 
19CoordinateFrameMarker.Touched:Connect(function(Hit)
20    local Character = (Hit.Parent:IsA("Model") and Hit.Parent) or Hit:FindFirstAncestorOfClass("Model")
21    if not Character then
22        return
23    end
24    pcall(function()
25        local Humanoid = Character:FindFirstChildOfClass("Humanoid")
26        local HumanoidRootPart = Character:FindFirstChild("HumanoidRootPart") or Humanoid.RootPart
27        local Player = Players:GetPlayerFromCharacter(Character)
28        if not table.find(PlayerList,Player) then
29            table.insert(Players,Player)
30            print("Player added to playerlist table.");
31            wait(1);
32            db = false
33        end
34    end)
35end)
36 
37coroutine.resume(coroutine.create(function()
38    while true do
39        swait()
40        if #PlayerList >= 1 then
41            wait(1)
42            for i = 10,0,-1 do
43                wait(1)
44                ReplicatedStorage.Timer.Value = i
45                local RandomEvent = ServerStorage.Floor:GetChildren()[math.random(1,#ServerStorage.Floor:GetChildren())];
46                local ClonedEvent = RandomEvent:Clone()
47                ClonedEvent.Parent = Workspace
48                wait(2)
49                open()
50                wait(.5)
51                if string.lower(ClonedEvent.Name) == ("no chill") then
52                    ClonedEvent.Board.chill.Face = Enum.NormalId.Front
53                    wait(1)
54                    ClonedEvent.Board.chill.Face = Enum.NormalId.Top
55                    ClonedEvent.Board.wrong.Face = Enum.NormalId.Front
56                    Workspace["WRONG!"]:Play()
57                    wait(1)
58                    ClonedEvent.Board.checkit.Face = Enum.NormalId.Front
59                    ClonedEvent.Board.wrnog.Face = Enum.NormalId.Top
60                    wait(1)
61                    ClonedEvent.Board.checkit.Face = Enum.NormalId.Top
62                    ClonedEvent.Board.correct.Face = Enum.NormalId.Front
63                    Workspace.correct:Play()
64                    wait(1)
65                end
66                for i,v in pairs(Players:GetPlayers()) do
67                    pcall(function()
68                        coroutine.resume(coroutine.create(function()
69                            repeat
70                                wait()
71                            until v.Character:FindFirstChildOfClass("Humanoid")
72                            local Humanoid = v.Character:FindFirstChildOfClass("Humanoid")
73                            Humanoid.Died:Connect(function()
74                                pcall(function()
75                                    table.remove(PlayerList,v)
76                                end)
77                            end)
78                        end))
79                    end)
80                end
81                Players.PlayerRemoving:Connect(function(Player)
82                    pcall(function()
83                        table.remove(PlayerList,Player)
84                    end)
85                end)
86                wait(15)
87                ClonedEvent:Destroy()
88                break
89            end
90        end
91        wait()
92    end
93end))
 View all 93 lines...

My while true do loop will not run at all, why is this so?

2 answers

Answer this question