Scripting Helpers is winding down operations and is now read-only. More info→

Why won't my property change gui work?

Asked by

4 years ago

Hello, I'm trying to make a property change gui to easily change some properties of a part for a part of teaching my friends how to script, by observing the properties of a part and changing them. Can anyone help me fix this issue? Thanks! I know this script may be messy, I'm sorry, but I just made this script and I'm not sure where the issue is, it's not outputted. Once again, thank you!:

PartPropertyHandler (ServerScriptService):

01local allowed = {"ISkyLordDoge"}
02 
03game.Players.PlayerAdded:Connect(function(player)
04    for i, v in pairs(allowed) do
05        if player.Name == v then
06            script.SendProperties:Clone().Parent = player:WaitForChild("PlayerGui")
07        end
08    end
09end)
10 
11game.ReplicatedStorage.ChangeProperties.OnServerEvent:Connect(function(player,BrickColorText,Material,Orientation,Position,Transparency)
12    for i,v in pairs(allowed) do
13        if player.Name == v then
14            game.ReplicatedStorage.ChangeProperties:FireAllClients(BrickColorText,Material,Orientation,Position,Transparency)
15            game.ReplicatedStorage.CanChange.Value = false
16            wait(5)
17            game.ReplicatedStorage.CanChange.Value = true
18        end
19    end
20end)

Local Script (In the GUI):

01local frame = script.Parent.Frame
02local BrickColorText = frame.BrickColor.Text
03local Material = frame.Material.Text
04local Orientation = frame.Orientation.Text
05local Position = frame.PositionE.Text
06local Transparency = frame.TransparencyE.Text
07 
08 
09script.Parent.Parent:WaitForChild("Toggle").MouseButton1Click:Connect(function()
10    if script.Parent.Visible == true then
11        script.Parent.Visible = false
12    else
13        script.Parent.Visible = true
14    end
15end)
16 
17local db = true
18for i,property in pairs(script.Parent.Frame:GetChildren()) do
19    if property.Changed then
20        script.Parent.Submit.MouseButton1Click:Connect(function()
21            if game.ReplicatedStorage.CanChange.Value == true and db == true then
22                db = false
23                game.ReplicatedStorage.ChangeProperties:FireServer(BrickColorText,Material,Orientation,Position,Transparency)
24            else
25                db = false
26                script.Parent.Submit.Text = "Cannot send now"
27                wait(2)
28                db = true
29                script.Parent.Submit.Text = "Send"
30            end
31        end)    
32    end
33end    
34 
35script.Parent.Cancel.MouseButton1Click:Connect(function()
36    script.Parent.Visible = false  
37end)
 View all 37 lines...

Local Script (In the part I'm trying to change the property of):

1game.ReplicatedStorage.ChangeProperties.OnClientEvent:Connect(function(BrickColorText,Material,Orientation,Position,Transparency)
2    local part = game.Workspace.PropertyPart
3    part.BrickColor = BrickColor.new(tostring(BrickColorText))
4    part.Material = Enum.Material.Material
5    part.Orientation = Vector3.new(Orientation)
6    part.Position = Vector3.new(Position)
7    part.Transparency = Transparency
8end)

Why would you FireAllClients? Seems very useless Raccoonyz 1092 — 4y

i adapted that, but im not sure why it has a problem with EnumItem outputted: 20:59:35.409 - material1 is not a valid EnumItem 20:59:35.410 - Stack Begin 20:59:35.411 - Script 'Workspace.PropertyPart.Script', Line 4 20:59:35.412 - Stack End ISkyLordDoge 37 — 4y

tried switching to player gui rather than starter gui but still doesnt work :/ ISkyLordDoge 37 — 4y

What's the issue? Change line 4 to Enum.Material[Material] to fix the error above. ImTrev 344 — 4y

View all comments (9 more)

still doesn't work : / (sorry if i sound rude) ISkyLordDoge 37 — 4y

Also the server doesn't have access to PlayerGui. ImTrev 344 — 4y

i meant i changed player gui in the local script which was in the gui, btw the material variable is seen as '' (nothing, basically), by any chance, do you know the problem? thanks! ISkyLordDoge 37 — 4y

My Questions: 1. Can you see the GUI? 2. What happens when you press the Submit Button? 3. On line 19, is there a child object named "property"? ImTrev 344 — 4y

1: I can see the GUI. 2. When I press the submit button, it says 'Cannot Send'. 3. No. ISkyLordDoge 37 — 4y

What is the "Changed" after property because it's an event that fires when something is changed so it should connected to a function, and the "CanChange" value must be false because the debounce isn't. ImTrev 344 — 4y

I dont know how I didn't spot this before but you need to change the top variables without the .Text because it'll be blank since its taking the text when you first declared them. You need to add .Text to the ends of the parameters in your FireServer. ImTrev 344 — 4y

property's class is a TextBox and when it is changed i want to fire the server with parameters of the text which has been changed. also, where could I change the canChange value to false? ISkyLordDoge 37 — 4y

now it's just assuming 'Really red' as an enum value whilst its being classed for brickcolourtext which is not using enum ISkyLordDoge 37 — 4y

1 answer

Answered by

ImTrev 344

4 years ago

Edited 4 years ago

01-- Server Script
02 
03local Replicated = game:GetService("ReplicatedStorage")
04 
05local allowed = {"ISkyLordDoge"}
06local CanChange = Replicated.CanChange
07 
08game.Players.PlayerAdded:Connect(function(player)
09    for i, v in pairs(allowed) do
10        if player.Name == v then
11            script.SendProperties:Clone().Parent = player:WaitForChild("PlayerGui")
12        end
13    end
14end)
15 
16Replicated.ChangeProperties.OnServerEvent:Connect(function(player,BrickColorText,Material,Orientation,Position,Transparency)
17    for i,v in pairs(allowed) do
18        if player.Name == v then
19            Replicated.ChangeProperties:FireAllClients(BrickColorText,Material,Orientation,Position,Transparency)
20            CanChange.Value = false
21            wait(5)
22            CanChange.Value = true
23        end
24    end
25end)
26 
27 
28 
29-- LocalScript
30 
31local Replicated = game:GetService("ReplicatedStorage")
32 
33local frame = script.Parent.Frame
34local BrickColorText = frame.BrickColor
35local Material = frame.Material
36local Orientation = frame.Orientation
37local Position = frame.PositionE
38local Transparency = frame.TransparencyE
39 
40local part = worksapce.PropertyPart
41 
42 
43script.Parent.Parent:WaitForChild("Toggle").MouseButton1Click:Connect(function()
44    if script.Parent.Visible == true then
45        script.Parent.Visible = false
46    else
47        script.Parent.Visible = true
48    end
49end)
50 
51local db = true
52for i,property in pairs(frame:GetChildren()) do
53    script.Parent.Submit.MouseButton1Click:Connect(function()
54        if Replicated.CanChange.Value == true and db == true then
55            db = false
56            Replicated.ChangeProperties:FireServer(BrickColorText.Text,Material.Text,Orientation.Text,Position.Text,Transparency.Text)
57        else
58            db = false
59            script.Parent.Submit.Text = "Cannot send now"
60            wait(2)
61            db = true
62            script.Parent.Submit.Text = "Send"
63        end
64    end)    
65end    
66 
67script.Parent.Cancel.MouseButton1Click:Connect(function()
68    script.Parent.Visible = false  
69end)
70game.ReplicatedStorage.ChangeProperties.OnClientEvent:Connect(function(BrickColorText,Material,Orientation,Position,Transparency)
71    part.BrickColor = BrickColor.new(tostring(BrickColorText))
72    part.Material = Enum.Material[Material]
73    part.Orientation = Vector3.new(Orientation)
74    part.Position = Vector3.new(Position)
75    part.Transparency = Transparency
76end)
 View all 76 lines...

Oh my lord! Thank you so much! You don't know how much this will help when it comes to teaching my friends scripting! ISkyLordDoge 37 — 4y

Happy to help! ImTrev 344 — 4y

How would I make it affect the whole server instead of just my client? Is it possible? Thanks! ISkyLordDoge 37 — 4y

Delete lines 17 to 19 and replace it with lines 71 to 75 and then delete 70 down. ImTrev 344 — 4y

Why won't my property change gui work?

1 answer

Answer this question