Scripting Helpers is winding down operations and is now read-only. More info→

My Noise for terrain isn't efficient, Any help?

Asked by

Coder_1 27

4 years ago

Edited 4 years ago

01for x = 1, 100 do
02    for z = 1, 100 do
03        local height = (math.noise(x / 20, z / 20) + 2) * 50
04        local p = Instance.new("Part", workspace)
05        p.Locked, p.Anchored = true, true
06        p.Size = Vector3.new(4, height, 4)
07        p.CFrame = CFrame.new(4 * x, height / 2, 4 * z)
08        wait()
09    end
10end

This is not efficient at all and take so long to load in. Is there anyway to make it load in chunks similar to minecraft and only load in top blocks and load in other filler blocks if you go into a cave. I searched online on documentation on math.noise but i don't see anything on it. People just say its a math function.

you can remove the wait() thast already quite some time less VerdommeMan 1479 — 4y

rn ur losing 300s bc of it (0.03*100*100) if wait is by default 0.03 VerdommeMan 1479 — 4y

Ok but it still extremely laggy Coder_1 27 — 4y

1 answer

Answered by

brokenVectors 525

4 years ago

Edited 4 years ago

Instead of just generating the whole thing(which will take a long time), I recommend you generate chunks around where all the players are, which is what Minecraft does.

I found this script off the devforum that does exactly what you want, note that it contains some ugly stuff like parenting before changing the properties, but it should do:

01local Players = game:GetService("Players")
02 
03------------------------------------------------------------------------------------------------------------------------------------------------
04 
05local BASE_HEIGHT       = 10                -- The main height factor for the terrain.
06local CHUNK_SCALE       = 1                 -- The grid scale for terrain generation. Should be kept relatively low if used in real-time.
07local RENDER_DISTANCE   = 25                    -- The length/width of chunks in voxels that should be around the player at all times
08local X_SCALE           = 90 / 4            -- How much we should strech the X scale of the generation noise
09local Z_SCALE           = 90 / 4            -- How much we should strech the Z scale of the generation noise
10local GENERATION_SEED   = math.random()     -- Seed for determining the main height map of the terrain.
11 
12------------------------------------------------------------------------------------------------------------------------------------------------
13 
14local chunks = {}
15 
16local function roundToOdd(n)
17    --spawn(function()
18    return math.floor(n - n % 3);
19    --end)
20end
21 
22local function chunkExists(chunkX, chunkZ)
23    if not chunks[chunkX] then
24        chunks[chunkX] = {}
25    end
26    return chunks[chunkX][chunkZ]
27end
28 
29local function mountLayer(x, heightY, z, material)
30    local beginY = -BASE_HEIGHT
31    local endY = heightY
32    local cframe = CFrame.new(x * 3 + 1, roundToOdd((beginY + endY) * 3 / 1), z * 3 + 1)
33    local size = Vector3.new(3, (endY - beginY) * 3, 3)
34    local p = Instance.new("Part", workspace)
35    p.Anchored = true
36    p.CFrame = cframe
37    p.Size = Vector3.new(3, 3, 3)
38    p.Material = Enum.Material.Grass
39    p.BrickColor = BrickColor.new("Forest green")
40end
41 
42function makeChunk(chunkX, chunkZ)
43    local rootPosition = Vector3.new(chunkX * CHUNK_SCALE, 0, chunkZ * CHUNK_SCALE)
44    chunks[chunkX][chunkZ] = true -- Acknowledge the chunk's existance.
45    for x = 0, CHUNK_SCALE - 1 do
46        for z = 0, CHUNK_SCALE - 1 do
47            local cx = (chunkX * CHUNK_SCALE) + x
48            local cz = (chunkZ * CHUNK_SCALE) + z
49            local noise = math.noise(GENERATION_SEED, cx / X_SCALE, cz / Z_SCALE)
50            local cy = noise * BASE_HEIGHT
51            mountLayer(cx, cy, cz, Enum.Material.Grass)
52        end
53    end
54end
55 
56function checkSurroundings(location)
57    local chunkX, chunkZ = math.floor(location.X / 3 / CHUNK_SCALE), math.floor(location.Z / 3 / CHUNK_SCALE)
58    local range = math.max(1, RENDER_DISTANCE / CHUNK_SCALE)
59    for x = -range, range do
60        for z = -range, range do
61            local cx, cz = chunkX + x
62            local cz = chunkZ + z
63            if not chunkExists(cx, cz) then
64                makeChunk(cx, cz)
65            end
66        end
67    end
68end
69 
70game:GetService("RunService").Heartbeat:Connect(function()
71    for _, player in pairs(Players:GetPlayers()) do
72        if player.Character then
73            local humanoidRootPart = player.Character:FindFirstChild("HumanoidRootPart")
74            if humanoidRootPart then
75                checkSurroundings(humanoidRootPart.Position)
76            end
77        end
78    end
79end)
 View all 79 lines...

Hope this helped

My Noise for terrain isn't efficient, Any help?

1 answer

Answer this question