Car not working when spawned in using script?

Asked by

4 years ago

When its in the workspace, it works perfectly. When I spawn it in using a script, it doesn't work. I have the car in the serverstorage, in a "Cars" folder.

001--DriveScript
002local ServerStorage = game:GetService("ServerStorage")
003local Car = ServerStorage.Cars.Car
004local vehicleSeat = Car.Base.VehicleSeat
005 
006local motorFR = Car.WheelFR:FindFirstChildWhichIsA("CylindricalConstraint", true)
007local motorFL = Car.WheelFL:FindFirstChildWhichIsA("CylindricalConstraint", true)
008local motorBR = Car.WheelBR:FindFirstChildWhichIsA("CylindricalConstraint", true)
009local motorBL = Car.WheelBL:FindFirstChildWhichIsA("CylindricalConstraint", true)
010 
011local springFR = Car.WheelFR:FindFirstChildWhichIsA("SpringConstraint", true)
012local springFL = Car.WheelFL:FindFirstChildWhichIsA("SpringConstraint", true)
013local springBR = Car.WheelBR:FindFirstChildWhichIsA("SpringConstraint", true)
014local springBL = Car.WheelBL:FindFirstChildWhichIsA("SpringConstraint", true)
015 
016local wheelHingeR = Car.WheelFR:FindFirstChildWhichIsA("HingeConstraint", true)
017local wheelHingeL = Car.WheelFL:FindFirstChildWhichIsA("HingeConstraint", true)
018 
019 
020-- TUNING VALUES
021----------------------------------------
022-- Factor of torque applied to get the wheels spinning
023-- Larger number generally means faster acceleration
024local TORQUE = 8000
025 
026-- Factor of torque applied to change the wheel direction
027-- Larger number generally means faster braking
028local BRAKING_TORQUE = 8000
029 
030-- Max angle the wheels will reach when turning
031-- Higher number means sharper turning, but too high means the wheels might hit the car base
032local MAX_TURN_ANGLE = 30
033 
034-- Car max speed
035local MAX_SPEED = 140
036----------------------------------------
037 
038 
039-- HELPER FUNCTIONS
040----------------------------------------
041-- Set the "MotorMaxTorque" property on all of the CylindricalConstraint motors
042local function setMotorTorque(torque)
043    motorFR.MotorMaxTorque = torque
044    motorFL.MotorMaxTorque = torque
045    motorBR.MotorMaxTorque = torque
046    motorBL.MotorMaxTorque = torque
047end
048 
049-- Set the "AngularVelocity" property on all of the CylindricalConstraint motors
050local function setMotorVelocity(vel)
051    motorFL.AngularVelocity = vel
052    motorBL.AngularVelocity = vel
053    -- Motors on the right side are facing the opposite direction, so negative velocity must be used
054    motorFR.AngularVelocity = -vel
055    motorBR.AngularVelocity = -vel
056end
057 
058-- Calculate the average linear velocity of the car based on the rate at which all wheels are spinning
059local function getAverageVelocity()
060    local vFR = -motorFR.Attachment1.WorldAxis:Dot(motorFR.Attachment1.Parent.RotVelocity)
061    local vRR = -motorBR.Attachment1.WorldAxis:Dot(motorBR.Attachment1.Parent.RotVelocity)
062    local vFL = motorFL.Attachment1.WorldAxis:Dot(motorFL.Attachment1.Parent.RotVelocity)
063    local vRL = motorBL.Attachment1.WorldAxis:Dot(motorBL.Attachment1.Parent.RotVelocity)
064    return 0.25 * ( vFR + vFL + vRR + vRL )
065end
066 
067 
068-- DRIVE LOOP
069----------------------------------------
070while true do
071 
072    -- Input values taken from the VehicleSeat
073    local steerFloat = vehicleSeat.SteerFloat  -- Forward and backward direction, between -1 and 1
074    local throttle = vehicleSeat.ThrottleFloat  -- Left and right direction, between -1 and 1
075 
076    -- Convert "steerFloat" to an angle for the HingeConstraint servos
077    local turnAngle = steerFloat * MAX_TURN_ANGLE
078    wheelHingeR.TargetAngle = turnAngle
079    wheelHingeL.TargetAngle = turnAngle
080 
081    -- Apply torque to the CylindricalConstraint motors depending on our throttle input and the current speed of the car
082    local currentVel = getAverageVelocity()
083    local targetVel = 0
084    local motorTorque = 0
085 
086    -- Idling
087    if math.abs(throttle) < 0.1 then
088        motorTorque = 100
089 
090    -- Accelerating
091    elseif math.abs(throttle * currentVel) > 0 then
092        -- Reduce torque with speed (if torque was constant, there would be a jerk reaching the target velocity)
093        -- This also produces a reduction in speed when turning
094        local r = math.abs(currentVel) / MAX_SPEED
095        -- Torque should be more sensitive to input at low throttle than high, so square the "throttle" value
096        motorTorque = math.exp( - 3 * r * r ) * TORQUE * throttle * throttle
097        targetVel = math.sign(throttle) * 10000  -- Arbitrary large number
098 
099    -- Braking
100    else
101        motorTorque = BRAKING_TORQUE * throttle * throttle
102    end
103 
104    -- Use helper functions to apply torque and target velocity to all motors
105    setMotorTorque(motorTorque)
106    setMotorVelocity(targetVel)
107    wait()
108end
 View all 108 lines...

Next Script

01--CarSpawner
02local ServerStorage = game:GetService("ServerStorage")
03local ReplicatedStorage = game:GetService("ReplicatedStorage")
04local SpawnCarEvent = ReplicatedStorage:WaitForChild("SpawnCar")
05local DeleteCarEvent = ReplicatedStorage:WaitForChild("DeleteCar")
06 
07SpawnCarEvent.OnServerEvent:Connect(function(player, carName)
08    local Car = ServerStorage:FindFirstChild("Cars"):FindFirstChild(carName)
09    if Car then
10        local clonedCar = Car:Clone()
11        clonedCar.Name = player.Name .. 'sCar'
12        clonedCar.Parent = game.Workspace
13        clonedCar:MoveTo(player.Character.HumanoidRootPart.Position + player.Character.HumanoidRootPart.CFrame.LookVector * 15)
14    end
15end)
16 
17DeleteCarEvent.OnServerEvent:Connect(function(player, Car)
18    if Car then
19        Car:Remove()
20    end
21end)
22 
23game.Players.PlayerRemoving:Connect(function(player)
24    local Car = game.Workspace:FindFirstChild(player.Name .. 'sCar')
25    if Car then
26        Car:Remove()
27    end
28end)
29 
30game.Players.PlayerAdded:Connect(function(player)
31    player.CharacterAdded:Connect(function(character)
32        local Car = game.Workspace:FindFirstChild(player.Name .. 'sCar')
33        if Car then
34            Car:Remove()
35        end
36    end)
37end)
 View all 37 lines...

I can provide the delete and call scripts if needed.

Errors errors please are there any errors in the output? those are 130 lines and there might be more reasons. Please check the output imKirda 4491 — 4y

Ok, I figured out why. The script spawns the car into Workspace, with the name "playername'sCar'. For example, mcslimemansCar. How would I make 003 local Car = ServerStorage.Cars.Car into something like 003 local Car = workspace.playernamesCar ? mcslimeman 37 — 4y

Also, there are no errors in the output mcslimeman 37 — 4y

mhm you need to get the player and then do this: workspace[player.Name.."'Cat"]. It will look for your car then. imKirda 4491 — 4y

View all comments (2 more)

ok, how would i get the player? mcslimeman 37 — 4y

The scripts are on a normal script. mcslimeman 37 — 4y

Car not working when spawned in using script?

Answer this question